From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 3/4] drm/i915: Remove early exit on i915_gpu_idle Date: Sat, 15 Oct 2011 23:10:04 +0100 Message-ID: References: <1318711636-30109-1-git-send-email-ben@bwidawsk.net> <1318711636-30109-4-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga14.intel.com (mga14.intel.com [143.182.124.37]) by gabe.freedesktop.org (Postfix) with ESMTP id 84B029F30B for ; Sat, 15 Oct 2011 15:10:08 -0700 (PDT) In-Reply-To: <1318711636-30109-4-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Sat, 15 Oct 2011 13:47:15 -0700, Ben Widawsky wrote: > [Description from: Daniel Vetter] > I've just discussed this quickly with Chris on irc and it's probably > best to just kill the list_empty early bailout. gpu_idle isn't a > fastpath, so who cares. One candidate where we emit commands to the ring > without adding anything onto these lists is e.g. pageflip. There are > probably more. > > Signed-off-by: Ben Widawsky Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre