From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: check ACTHD of all rings Date: Sun, 27 Nov 2011 18:24:18 +0000 Message-ID: References: <1322416697-20861-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id EF1AC9E746 for ; Sun, 27 Nov 2011 10:24:38 -0800 (PST) In-Reply-To: <1322416697-20861-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Sun, 27 Nov 2011 18:58:17 +0100, Daniel Vetter wrote: > Otherwise hangcheck spuriously fires when running blitter/bsd-only > workloads. > > Contrary to a similar patch by Ben Widawsky this does not check > INSTDONE of the other rings. Chris Wilson implied that in a failure to > detect a hang, most likely because INSTDONE was fluctuating. Thus only > check ACTHD, which as far as I know is rather reliable. Also, blitter > and bsd rings can't launch complex tasks from a single instruction > (like 3D_PRIM on the render with complex or even infinite shaders). > > This fixes spurious gpu hang detection when running > tests/gem_hangcheck_forcewake on snb/ivb. > > Signed-Off-by: Daniel Vetter Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre