From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 2/5] drm/i915: Bump the inactive LRU on set-to-GTT-domain Date: Mon, 27 Feb 2012 19:00:54 +0000 Message-ID: References: <1330118022-5701-1-git-send-email-chris@chris-wilson.co.uk> <1330118022-5701-3-git-send-email-chris@chris-wilson.co.uk> <87k438jek6.fsf@eliezer.anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 045079E946 for ; Mon, 27 Feb 2012 11:00:59 -0800 (PST) In-Reply-To: <87k438jek6.fsf@eliezer.anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Eric Anholt , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, 27 Feb 2012 10:50:49 -0800, Eric Anholt wrote: > On Fri, 24 Feb 2012 21:13:39 +0000, Chris Wilson wrote: > > @@ -2923,6 +2914,9 @@ i915_gem_object_set_to_gtt_domain(struct drm_i915_gem_object *obj, bool write) > > old_read_domains, > > old_write_domain); > > > > + /* And bump the LRU for this access */ > > + list_move_tail(&obj->mm_list, &dev_priv->mm.inactive_list); > > I don't think you know that !obj->active here. For example, going to > GTT read of something that was currently active and in the SAMPLER read > domain. You're right, I was thinking the wait_rendering() was unconditional like for set-to-cpu-domain. Oh well, at least we can still benefit from not having to worry about being inactive-but-pinned... -Chris -- Chris Wilson, Intel Open Source Technology Centre