From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: hangcheck parameter Date: Wed, 22 Jun 2011 18:45:56 +0100 Message-ID: References: <1308763970-2989-1-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga14.intel.com (mga14.intel.com [143.182.124.37]) by gabe.freedesktop.org (Postfix) with ESMTP id 8ACB6A087D for ; Wed, 22 Jun 2011 10:45:59 -0700 (PDT) In-Reply-To: <1308763970-2989-1-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, 22 Jun 2011 10:32:50 -0700, Ben Widawsky wrote: > The hangcheck is undesirable when doing shader debugging. The debugger > interacts with the EU, and these may cause the hangcheck to fire at most > unfortunate times. > > This provides a way to let the user disable the hangcheck when they want > to do shader debugging. Looks like a reasonable idea, I'm tempted to suggest to make it the period in ms rather a boolean. But for actual use, either a new ioctl for enable/disable or another wakelock? Just in case we have more than one program trying to debug at the same time. (Not so far fetched, as the user may be snooping on the results whilst debugging in another process?) -Chris -- Chris Wilson, Intel Open Source Technology Centre