From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH V2 RESEND] drm/i915: gracefully bail out when init_clock_gating-pointer is not set Date: Mon, 04 Jul 2011 10:50:51 +0100 Message-ID: References: <1309772470-2618-1-git-send-email-w.sang@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id B7A8E9EEB5 for ; Mon, 4 Jul 2011 02:51:03 -0700 (PDT) In-Reply-To: <1309772470-2618-1-git-send-email-w.sang@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: dri-devel@lists.freedesktop.org Cc: Wolfram Sang List-Id: dri-devel@lists.freedesktop.org On Mon, 4 Jul 2011 11:41:10 +0200, Wolfram Sang wrote: > Commit 6067aa (drm/i915: split clock gating init into per-chipset > functions) introduces an init_clock_gating-pointer. There is one case, > however, where it does not get set, so that caused an OOPS. Change the > code to return -ENODEV in this case and propagate it to the upper > layers. > > Signed-off-by: Wolfram Sang > Reviewed-by: Jesse Barnes > Cc: Keith Packard Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre