From: "Jeremy Cline" <jeremy@jcline.org>
To: "Ryosuke Yasuoka" <ryasuoka@redhat.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
horms@kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
syoshida@redhat.com,
syzbot+7ea9413ea6749baf5574@syzkaller.appspotmail.com,
syzbot+29b5ca705d2e0f4a44d2@syzkaller.appspotmail.com
Subject: Re: [PATCH net v2] nfc: nci: Fix uninit-value in nci_dev_up and nci_ntf_packet
Date: Wed, 20 Mar 2024 10:11:49 -0400 [thread overview]
Message-ID: <d09d7505-7421-4975-a73d-3253d32c4db1@app.fastmail.com> (raw)
In-Reply-To: <20240320005412.905060-1-ryasuoka@redhat.com>
On Tue, Mar 19, 2024, at 8:54 PM, Ryosuke Yasuoka wrote:
> syzbot reported the following uninit-value access issue [1][2]:
>
> nci_rx_work() parses and processes received packet. When the payload
> length is zero, each message type handler reads uninitialized payload
> and KMSAN detects this issue. The receipt of a packet with a zero-size
> payload is considered unexpected, and therefore, such packets should be
> silently discarded.
>
> This patch resolved this issue by checking payload size before calling
> each message type handler codes.
>
> Fixes: 6a2968aaf50c ("NFC: basic NCI protocol implementation")
> Reported-and-tested-by: syzbot+7ea9413ea6749baf5574@syzkaller.appspotmail.com
> Reported-and-tested-by: syzbot+29b5ca705d2e0f4a44d2@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=7ea9413ea6749baf5574 [1]
> Closes: https://syzkaller.appspot.com/bug?extid=29b5ca705d2e0f4a44d2 [2]
> Signed-off-by: Ryosuke Yasuoka <ryasuoka@redhat.com>
> ---
For what it's worth,
Reviewed-by: Jeremy Cline <jeremy@jcline.org>
next prev parent reply other threads:[~2024-03-20 14:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 0:54 [PATCH net v2] nfc: nci: Fix uninit-value in nci_dev_up and nci_ntf_packet Ryosuke Yasuoka
2024-03-20 13:13 ` Jiri Pirko
2024-03-20 14:11 ` Jeremy Cline [this message]
2024-03-22 6:14 ` Krzysztof Kozlowski
2024-03-22 9:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d09d7505-7421-4975-a73d-3253d32c4db1@app.fastmail.com \
--to=jeremy@jcline.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ryasuoka@redhat.com \
--cc=syoshida@redhat.com \
--cc=syzbot+29b5ca705d2e0f4a44d2@syzkaller.appspotmail.com \
--cc=syzbot+7ea9413ea6749baf5574@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.