From: Reinette Chatre <reinette.chatre@intel.com>
To: "Luck, Tony" <tony.luck@intel.com>, "Moger, Babu" <babu.moger@amd.com>
Cc: "Yu, Fenghua" <fenghua.yu@intel.com>,
Peter Newman <peternewman@google.com>,
"x86@kernel.org" <x86@kernel.org>,
Shaopeng Tan <tan.shaopeng@fujitsu.com>,
James Morse <james.morse@arm.com>,
Jamie Iles <quic_jiles@quicinc.com>,
Randy Dunlap <rdunlap@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"patches@lists.linux.dev" <patches@lists.linux.dev>
Subject: Re: [PATCH v2] x86/resctrl: Fix unused variable warning in cache_alloc_hsw_probe()
Date: Fri, 3 Nov 2023 13:23:57 -0700 [thread overview]
Message-ID: <d0a6ca2d-250a-47e2-8dda-b4e7d74a7ffb@intel.com> (raw)
In-Reply-To: <SJ1PR11MB6083E6ABE4D467D5D275A309FCA6A@SJ1PR11MB6083.namprd11.prod.outlook.com>
On 11/2/2023 3:50 PM, Luck, Tony wrote:
>> This does seem a valid issue and my Ack remains. I'm just puzzled why I do not
>> encounter the same warning.
>
> Reinette,
>
> Some other CONFIG option changing CFLAGS?
>
> Here's what I have for a "make V=1 W=1" for core.o
>
Tony and I went a bit more back-and-forth on this one and it appears that the
relevant code is optimized out in my build while the same did not happen
for him.
I can now trigger the warning by enabling Xen support, with CONFIG_PARAVIRT_XXL
causing rdmsr() to be replaced by paravirt_read_msr(). With the relevant code
no longer optimized out, the warning is triggered.
Thanks Tony!
Reinette
prev parent reply other threads:[~2023-11-03 20:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 22:05 [PATCH] x86/resctrl: Fix unused variable warning in cache_alloc_hsw_probe() Tony Luck
2023-11-01 9:43 ` Bagas Sanjaya
2023-11-01 14:33 ` Luck, Tony
2023-11-01 20:26 ` Moger, Babu
2023-11-01 20:33 ` Luck, Tony
2023-11-01 20:42 ` Moger, Babu
2023-11-01 21:26 ` [PATCH v2] " Tony Luck
2023-11-02 13:02 ` Moger, Babu
2023-11-02 21:34 ` Reinette Chatre
2023-11-02 22:02 ` Luck, Tony
2023-11-02 22:23 ` Reinette Chatre
2023-11-02 22:50 ` Luck, Tony
2023-11-03 20:23 ` Reinette Chatre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0a6ca2d-250a-47e2-8dda-b4e7d74a7ffb@intel.com \
--to=reinette.chatre@intel.com \
--cc=babu.moger@amd.com \
--cc=fenghua.yu@intel.com \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=peternewman@google.com \
--cc=quic_jiles@quicinc.com \
--cc=rdunlap@infradead.org \
--cc=tan.shaopeng@fujitsu.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.