From: Charan Pedumuru <charan.pedumuru@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Vinod Koul <vkoul@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>
Cc: dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] dt-bindings: dma: nvidia,tegra20-apbdma: convert text based binding to json schema
Date: Tue, 6 May 2025 17:06:10 +0530 [thread overview]
Message-ID: <d0bfbcd7-4fde-41d4-a8fd-796dc7db814c@gmail.com> (raw)
In-Reply-To: <28757bb3-61b4-423d-850a-70fd5a4c2786@kernel.org>
On 06-05-2025 16:42, Krzysztof Kozlowski wrote:
> On 06/05/2025 13:02, Charan Pedumuru wrote:
>> +
>> +allOf:
>> + - $ref: dma-controller.yaml#
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/reset/tegra186-reset.h>
>> + dma-controller@6000a000 {
>> + compatible = "nvidia,tegra30-apbdma", "nvidia,tegra20-apbdma";
>> + reg = <0x6000a000 0x1200>;
>> + interrupts = <0 136 0x04>,
>
> You gave me little time to respond - 15 minutes - and then you sent v3.
>
> Use the header and its defines instead of hard-coding it. Wasn't this
> the entire point why you included the header in the first place in v1?
> Otherwise why was it included?
Oh my bad, now I got it, I will use #include <dt-bindings/interrupt-controller/arm-gic.h> header and redefine the interrupts with
interrupts = <GIC_SPI 76 IRQ_TYPE_LEVEL_HIGH> format instead of hard coding. Thanks for your patience and clarification.
>
>>
>
>
> Best regards,
> Krzysztof
--
Best Regards,
Charan.
next prev parent reply other threads:[~2025-05-06 11:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 11:02 [PATCH v3 0/2] dt-bindings: dma: nvidia,tegra20-apbdma: Add json schema for text binding Charan Pedumuru
2025-05-06 11:02 ` [PATCH v3 1/2] arm: dts: nvidia: tegra20,30: Rename the apbdma nodename to match with common dma-controller binding Charan Pedumuru
2025-05-06 11:02 ` [PATCH v3 2/2] dt-bindings: dma: nvidia,tegra20-apbdma: convert text based binding to json schema Charan Pedumuru
2025-05-06 11:12 ` Krzysztof Kozlowski
2025-05-06 11:36 ` Charan Pedumuru [this message]
2025-05-06 13:29 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0bfbcd7-4fde-41d4-a8fd-796dc7db814c@gmail.com \
--to=charan.pedumuru@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.