From: Jason Andryuk <jason.andryuk@amd.com>
To: "Oleksii Kurochko" <oleksii.kurochko@gmail.com>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Jan Beulich" <jbeulich@suse.com>
Cc: <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH for-4.22] Revert "xen/cpufreq: fix usages of align_timer() in the on-demand governor"
Date: Tue, 16 Jun 2026 10:33:12 -0400 [thread overview]
Message-ID: <d0d2eeb1-e94f-4210-a9d3-e7c9b4c3ade2@amd.com> (raw)
In-Reply-To: <a20eb654-8d77-4778-ad1b-09424065a69b@gmail.com>
On 2026-06-16 03:31, Oleksii Kurochko wrote:
>
>
> On 6/16/26 8:47 AM, Roger Pau Monné wrote:
>> On Tue, Jun 16, 2026 at 08:30:25AM +0200, Jan Beulich wrote:
>>> On 15.06.2026 21:39, Jason Andryuk wrote:
>>>> The original commit showed a ~6% regression in a benchmark. The
>>>> call to
>>>> align_timer(firsttick, period) rounds firsttick up to the next mutiple
>>>> of the period, if firsttick % period != 0:
>>>>
>>>> align_timer(0, period) -> 0
>>>> align_timer(1, period) -> period
>>>> align_timer(period, period) -> period
>>>> align_timer(period + 1, period) -> 2 * period
>>>>
>>>> So adding the period (sampling_rate) before calling align_timer() will
>>>> in most cases incease the expiration to 2 * period (sampling_rate) (the
>>>> exception being firsttick % period == 0). This longer timer slows the
>>>> reaction time of the algorithm.
>>>>
>>>> This reverts commit a0ed5bcfbeee81c91c574ad484faa057054eaf09.
>>>>
>>>> Signed-off-by: Jason Andryuk <jason.andryuk@amd.com>
>>
>> Acked-by: Roger Pau Monné <roger.pau@citrix.com>
>>
>> Adding Oleksii for a release-ack.
>>
>
> Release-Acked-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
Thanks everyone.
Sorry for forgetting to CC you, Oleskii, and mark as for-4.22.
add_maintainers.pl does the right thing... except during the code freeze.
Jan, thanks for fixing up the indent.
Regards,
Jason
next prev parent reply other threads:[~2026-06-16 14:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-15 19:39 [PATCH] Revert "xen/cpufreq: fix usages of align_timer() in the on-demand governor" Jason Andryuk
2026-06-16 6:30 ` Jan Beulich
2026-06-16 6:47 ` [PATCH for-4.22] " Roger Pau Monné
2026-06-16 7:31 ` Oleksii Kurochko
2026-06-16 14:33 ` Jason Andryuk [this message]
2026-06-16 6:31 ` [PATCH] " Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0d2eeb1-e94f-4210-a9d3-e7c9b4c3ade2@amd.com \
--to=jason.andryuk@amd.com \
--cc=jbeulich@suse.com \
--cc=oleksii.kurochko@gmail.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.