From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63A51C83F1A for ; Mon, 21 Jul 2025 07:20:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vSa3gO5OFwH3jq6CccEFga3VN016AwIcvcus/HWmBFY=; b=xc/tCshgDlBrA3wTbFRSzd4PW2 5yQf5ETS74outvT/zjbJvfBtVtmeL/CKgrPLppQfubADfYEVmkg3pu7WCYLRTx06Jf0UZovujOKEE CZzqvMJrrkgeMFunAL65aoxj83fQvaRZtgSs/AnDRQbo6yeegMKeg15aA83v86b1poscfghkHhpkx USJ8fZpwI1AHTINx1f3eu/4W+qkOxH2vBOC3GEvUUoPzTGfBidZOLuqsygahddI0/Wr3qXby5BzRY zdrJzfnjiq2AXxAiUuIqRuZWIdaI97Bi3bBxfJM2K5Q+GiK6HC7X+0Rc1/nQcf5SR09HiqoN+7ixN W5eOax8w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1udkp9-0000000GTk8-0lzA; Mon, 21 Jul 2025 07:20:35 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1udkmi-0000000GTZ1-45iR for linux-arm-kernel@lists.infradead.org; Mon, 21 Jul 2025 07:18:06 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id DF6715C44A8; Mon, 21 Jul 2025 07:18:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 07355C4CEED; Mon, 21 Jul 2025 07:17:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753082283; bh=1s2KWA7tcb/MOyIOVFgvc6VCEGCoanOpC0pWVed+jWM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=HT2WtPZpN58l+taN0yRBydcUEukBxJNSQtelllZMQs6BB2IaOMCXK16LojQHy2Kpw bJxJ3eN9z3TPTYq064MEcEZneXeSq2mh7Y1ejCTVk1Uh0XwTlUPhQYkAdVPC/Ieix3 gUjnvYWMD/PDEz7UGfjmdE6cDJWoekgKEC51yAL4dhsLmWedWbcau5zxiY2KnTSV/a AbpeD0MWRzGjrg8QGI+FPtObFMJzFq35ZLYJ7DM0Pa0PsMPwLkRGkkOdEqpNBXVAir mLJKMM1CvCuTLtxAr8bCFPw6nCq/FBTIrL3F/a4V0EOrU6mCEWD+7etGruH4dNKbmc +lhuZ2h2rUGNQ== Message-ID: Date: Mon, 21 Jul 2025 09:17:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 14/16] arm64: dts: axis: Add initial device tree support To: sungmin park , ksk4725@coasia.com, Jesper Nilsson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Linus Walleij , Tomasz Figa , Catalin Marinas , Will Deacon , Arnd Bergmann , Ravi Patel Cc: kenkim , Jongshin Park , GunWoo Kim , HaGyeong Kim , GyoungBo Min , Pankaj Dubey , Shradha Todi , Inbaraj E , Swathi K S , Hrishikesh , Dongjin Yang , Sang Min Kim , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@axis.com, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, soc@lists.linux.dev References: <20250710002047.1573841-1-ksk4725@coasia.com> <20250710002047.1573841-15-ksk4725@coasia.com> <5998de2a-f3ae-46bf-a975-081da20bab03@kernel.org> <79482a4ec841743af1ef13ea9eea58bada47c42f.camel@coasia.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <79482a4ec841743af1ef13ea9eea58bada47c42f.camel@coasia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250721_001805_098527_0D5BCF07 X-CRM114-Status: GOOD ( 19.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21/07/2025 09:08, sungmin park wrote: >>> index fa1e04e87d1d..371005f3f41a 100644 >>> --- a/MAINTAINERS >>> +++ b/MAINTAINERS >>> @@ -2320,6 +2320,20 @@ F:       drivers/crypto/axis >>>  F:     drivers/mmc/host/usdhi6rol0.c >>>  F:     drivers/pinctrl/pinctrl-artpec* >>>   >>> +ARM/ARTPEC ARM64 MACHINE SUPPORT >> >> This is samsung soc, so I need a pattern for that as well as I will >> be >> handling patches. > > Can you please explain what you mean to say? Something like I sent for Tesla the same day or shortly after I commented on this. > >> >>> +M:     Jesper Nilsson >>> +M:     Ravi Patel >>> +M:     SeonGu Kang >>> +M:     SungMin Park >> >> Please keep only maintainers who will actually perform reviews of the >> code. I am not even sure if this is worth separate entry outside of >> Samsung. Please list the IP blocks which are not Samsung here. Are you going to implement this in the next patch? > > Is it fine if I merge the list with existing ARTPEC entry? No. Did you read my message? I am not maintainer of existing ARTPEC SoC. > Samsung and Coasia entry can be removed from list as Axis will be only > maintaining the ARTPEC-8 SoC in future. > Please suggest your opinion here. > >> >>> +L:     linux-arm-kernel@lists.infradead.org (moderated for non- >>> subscribers) >>> +L:     linux-samsung-soc@vger.kernel.org >>> +L:     linux-arm-kernel@axis.com >>> +S:     Maintained >>> +F:     Documentation/devicetree/bindings/clock/axis,artpec*- >>> clock.yaml >>> +F:     arch/arm64/boot/dts/axis/ >>> +F:     drivers/clk/samsung/clk-artpec*.c >>> +F:     include/dt-bindings/clock/axis,artpec*-clk.h >>> + >>>  ARM/ASPEED I2C DRIVER >>>  M:     Ryan Chen >>>  R:     Benjamin Herrenschmidt >>> diff --git a/arch/arm64/Kconfig.platforms >>> b/arch/arm64/Kconfig.platforms >>> index 8b76821f190f..418ee47227c1 100644 >>> --- a/arch/arm64/Kconfig.platforms >>> +++ b/arch/arm64/Kconfig.platforms >>> @@ -40,6 +40,19 @@ config ARCH_APPLE >>>           This enables support for Apple's in-house ARM SoC family, >>> such >>>           as the Apple M1. >>>   >>> +config ARCH_ARTPEC >>> +       bool "Axis Communications ARTPEC SoC Family" >>> +       help >>> +          This enables support for the ARMv8 based ARTPEC SoC >>> Family. >>> + >>> +config ARCH_ARTPEC8 >> >> No, drop. One ARCH symbol. >> >>> +       bool "Axis ARTPEC-8 SoC Platform" >>> +       depends on ARCH_ARTPEC >>> +       depends on ARCH_EXYNOS >> >> And that's the proof that this is Samsung SoC. > > Should I move the axis folder inside exynos just like google did? In > that case we don't need separate ARCH entry anymore. > Or should I follow the tesla FSD style to add axis folder outside > exynos? In that case I will keep ARCH_ARTPEC entry only. > Please suggest your opinion here. You did not describe the hardware really. Neither in commit msg, nor in cover letter nor here where I asked to list the non-Samsung IP blocks. I will not provide you guidelines based on magic crystal ball guesses. Best regards, Krzysztof