From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7124DC433E0 for ; Thu, 28 Jan 2021 09:35:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1BE6B64DE6 for ; Thu, 28 Jan 2021 09:35:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1BE6B64DE6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IbNwGib2Id9PZVw/F7ThGzPmp6J6rxrLWf8WiUiPvuU=; b=pc9xIfFQEB0GJGvf+u8ewfVl/ Fve2U53hv46wMbuD6eX4R2wDu+/OyVfNFdss/HdmeFZRKkfJhVmYH/wGel7ib3TW7KRrDVEdtPwQ9 Sf465mwsiz8J7lmZyn+qW5Vi/fz9HXUb/MvxtzVRduBm3y0BC4hgdM3vp1Djju08Qd53BmiFCEwXe 9St9kf67Iu/uBCWin9FffQG3k1feNkiV1eEMcgn/toLUFZlM+WXNk5JYN0xVEdxSfmvvyY3hKRsrf H1t9zHYePB7p0DxCuO1BORJK6xjJN1hyTpjXGgR7OH6c6YHeWsKjzjeI59jkGa8exYMKc3d4VkJH3 U7NTCKgLA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l53h1-0003hJ-Nu; Thu, 28 Jan 2021 09:34:23 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l53gy-0003gh-Pp for linux-arm-kernel@lists.infradead.org; Thu, 28 Jan 2021 09:34:21 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7B229106F; Thu, 28 Jan 2021 01:34:19 -0800 (PST) Received: from [10.57.45.249] (unknown [10.57.45.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2CE0D3F766; Thu, 28 Jan 2021 01:34:17 -0800 (PST) Subject: Re: [PATCH V3 10/14] arm64: nvhe: Allow TRBE access at EL1 To: Marc Zyngier , Anshuman Khandual References: <1611737738-1493-1-git-send-email-anshuman.khandual@arm.com> <1611737738-1493-11-git-send-email-anshuman.khandual@arm.com> <12b1572e2568d4936f0458649065fe64@kernel.org> From: Suzuki K Poulose Message-ID: Date: Thu, 28 Jan 2021 09:34:11 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <12b1572e2568d4936f0458649065fe64@kernel.org> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210128_043420_893635_F8CC0D10 X-CRM114-Status: GOOD ( 19.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , mathieu.poirier@linaro.org, Catalin Marinas , coresight@lists.linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Will Deacon , lcherian@marvell.com, mike.leach@linaro.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMS8yNy8yMSA5OjU4IEFNLCBNYXJjIFp5bmdpZXIgd3JvdGU6Cj4gT24gMjAyMS0wMS0yNyAw ODo1NSwgQW5zaHVtYW4gS2hhbmR1YWwgd3JvdGU6Cj4+IEZyb206IFN1enVraSBLIFBvdWxvc2Ug PHN1enVraS5wb3Vsb3NlQGFybS5jb20+Cj4+Cj4+IFdoZW4gdGhlIGtlcm5lbCBpcyBib290ZWQg YXQgRUwyIGluIGEgbnZoZSBjb25maWd1cmF0aW9uLAo+PiBlbmFibGUgdGhlIFRSQkUgYWNjZXNz IHRvIHRoZSBFTDEuIFRoZSBFTDEgc3RpbGwgY2FuJ3QgdHJhY2UKPj4gRUwyLCB1bmxlc3MgRUwy IHBlcm1pdHMgZXhwbGljaXRseSB2aWEgVFJGQ1JfRUwyLkUyVFJFLgo+Pgo+PiBDYzogV2lsbCBE ZWFjb24gPHdpbGxAa2VybmVsLm9yZz4KPj4gQ2M6IENhdGFsaW4gTWFyaW5hcyA8Y2F0YWxpbi5t YXJpbmFzQGFybS5jb20+Cj4+IENjOiBNYXJjIFp5bmdpZXIgPG1hekBrZXJuZWwub3JnPgo+PiBD YzogTWFyayBSdXRsYW5kIDxtYXJrLnJ1dGxhbmRAYXJtLmNvbT4KPj4gY2M6IEFuc2h1bWFuIEto YW5kdWFsIDxhbnNodW1hbi5raGFuZHVhbEBhcm0uY29tPgo+PiBTaWduZWQtb2ZmLWJ5OiBTdXp1 a2kgSyBQb3Vsb3NlIDxzdXp1a2kucG91bG9zZUBhcm0uY29tPgo+PiBTaWduZWQtb2ZmLWJ5OiBB bnNodW1hbiBLaGFuZHVhbCA8YW5zaHVtYW4ua2hhbmR1YWxAYXJtLmNvbT4KPiAKPiBBY2tlZC1i eTogTWFyYyBaeW5naWVyIDxtYXpAa2VybmVsLm9yZz4KPiAKPiBPbmUgY29tbWVudCBiZWxvdywg dGhvdWdoOgo+IAo+PiAtLS0KPj4gwqBhcmNoL2FybTY0L2luY2x1ZGUvYXNtL2VsMl9zZXR1cC5o IHwgMTkgKysrKysrKysrKysrKysrKysrKwo+PiDCoGFyY2gvYXJtNjQvaW5jbHVkZS9hc20va3Zt X2FybS5owqDCoCB8wqAgMiArKwo+PiDCoDIgZmlsZXMgY2hhbmdlZCwgMjEgaW5zZXJ0aW9ucygr KQo+Pgo+PiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9pbmNsdWRlL2FzbS9lbDJfc2V0dXAuaAo+ PiBiL2FyY2gvYXJtNjQvaW5jbHVkZS9hc20vZWwyX3NldHVwLmgKPj4gaW5kZXggYTdmNWExYi4u MDVlY2NlOSAxMDA2NDQKPj4gLS0tIGEvYXJjaC9hcm02NC9pbmNsdWRlL2FzbS9lbDJfc2V0dXAu aAo+PiArKysgYi9hcmNoL2FybTY0L2luY2x1ZGUvYXNtL2VsMl9zZXR1cC5oCj4+IEBAIC03Miw2 ICs3MiwyNSBAQAo+PiDCoC5lbmRpZgo+Pgo+PiDCoDM6Cj4+ICsKPj4gKy5pZmVxc8KgwqDCoCAi XG1vZGUiLCAibnZoZSIKPj4gK8KgwqDCoCAvKgo+PiArwqDCoMKgwqAgKiBJZiB0aGUgVHJhY2Ug QnVmZmVyIGlzIGF2YWlsYWJsZSwgYWxsb3cKPj4gK8KgwqDCoMKgICogdGhlIEVMMSB0byBvd24g aXQuIE5vdGUgdGhhdCBFTDEgY2Fubm90Cj4+ICvCoMKgwqDCoCAqIHRyYWNlIHRoZSBFTDIsIGFz IGl0IGlzIHByZXZlbnRlZCBieQo+PiArwqDCoMKgwqAgKiBUUkZDUl9FTDIuRTJUUkUgPT0gMC4K Pj4gK8KgwqDCoMKgICovCj4+ICvCoMKgwqAgdWJmeMKgwqDCoCB4MCwgeDEsICNJRF9BQTY0REZS MF9UUkJFX1NISUZULCAjNAo+PiArwqDCoMKgIGNiesKgwqDCoCB4MCwgMWYKPj4gKwo+PiArwqDC oMKgIG1yc19zwqDCoMKgIHgwLCBTWVNfVFJCSURSX0VMMQo+PiArwqDCoMKgIGFuZMKgwqDCoCB4 MCwgeDAsIFRSQklEUl9QUk9HCj4+ICvCoMKgwqAgY2JuesKgwqDCoCB4MCwgMWYKPj4gK8KgwqDC oCBtb3bCoMKgwqAgeDAsICMoTURDUl9FTDJfRTJUQl9FTDFfT1dOIDw8IE1EQ1JfRUwyX0UyVEJf U0hJRlQpCj4+ICvCoMKgwqAgb3JywqDCoMKgIHgyLCB4MiwgeDAKPj4gKy5lbmRpZgo+PiArCj4+ ICsxOgo+IAo+IE5vdGUgdGhhdCB0aGlzIHdpbGwgKGJhZGx5KSBjb25mbGljdCB3aXRoIHRoZSBs YXRlLVZIRSBwYXRjaGVzWzFdLAo+IHdoZXJlIHRoaXMgY29kZSBwYXRoIGhhcyBiZWVuIHJld29y a2VkLgoKVGhhbmtzIGZvciB0aGUgaGVhZHMgdXAuIFdlIHdpbGwgbmVlZCB0byBzZWUgaG93IHRo aW5ncyBnZXQgbWVyZ2VkLgpJZGVhbGx5IHRoaXMgcGF0Y2ggYW5kIHRoZSBwcmV2aW91cyBvbmUg KFRSQkUgZGVmaW5pdGlvbnMgY291bGQgZ28KdmlhIHRoZSBhcm02NCB0cmVlIC8ga3ZtIHRyZWUp LCBpbiB3aGljaCBjYXNlIHdlIGNvdWxkIHJlYmFzZSB0aGVzZQp0d28gcGF0Y2hlcyBvbiB0aGUg cmVzcGVjdGl2ZSB0cmVlLgoKQ2hlZXJzClN1enVraQoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGlu dXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09D92C433E6 for ; Thu, 28 Jan 2021 09:40:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA6F164DA1 for ; Thu, 28 Jan 2021 09:40:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231316AbhA1Jkb (ORCPT ); Thu, 28 Jan 2021 04:40:31 -0500 Received: from foss.arm.com ([217.140.110.172]:55276 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232468AbhA1JfG (ORCPT ); Thu, 28 Jan 2021 04:35:06 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7B229106F; Thu, 28 Jan 2021 01:34:19 -0800 (PST) Received: from [10.57.45.249] (unknown [10.57.45.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2CE0D3F766; Thu, 28 Jan 2021 01:34:17 -0800 (PST) Subject: Re: [PATCH V3 10/14] arm64: nvhe: Allow TRBE access at EL1 To: Marc Zyngier , Anshuman Khandual Cc: linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org, mathieu.poirier@linaro.org, mike.leach@linaro.org, lcherian@marvell.com, linux-kernel@vger.kernel.org, Will Deacon , Catalin Marinas , Mark Rutland References: <1611737738-1493-1-git-send-email-anshuman.khandual@arm.com> <1611737738-1493-11-git-send-email-anshuman.khandual@arm.com> <12b1572e2568d4936f0458649065fe64@kernel.org> From: Suzuki K Poulose Message-ID: Date: Thu, 28 Jan 2021 09:34:11 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <12b1572e2568d4936f0458649065fe64@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/27/21 9:58 AM, Marc Zyngier wrote: > On 2021-01-27 08:55, Anshuman Khandual wrote: >> From: Suzuki K Poulose >> >> When the kernel is booted at EL2 in a nvhe configuration, >> enable the TRBE access to the EL1. The EL1 still can't trace >> EL2, unless EL2 permits explicitly via TRFCR_EL2.E2TRE. >> >> Cc: Will Deacon >> Cc: Catalin Marinas >> Cc: Marc Zyngier >> Cc: Mark Rutland >> cc: Anshuman Khandual >> Signed-off-by: Suzuki K Poulose >> Signed-off-by: Anshuman Khandual > > Acked-by: Marc Zyngier > > One comment below, though: > >> --- >>  arch/arm64/include/asm/el2_setup.h | 19 +++++++++++++++++++ >>  arch/arm64/include/asm/kvm_arm.h   |  2 ++ >>  2 files changed, 21 insertions(+) >> >> diff --git a/arch/arm64/include/asm/el2_setup.h >> b/arch/arm64/include/asm/el2_setup.h >> index a7f5a1b..05ecce9 100644 >> --- a/arch/arm64/include/asm/el2_setup.h >> +++ b/arch/arm64/include/asm/el2_setup.h >> @@ -72,6 +72,25 @@ >>  .endif >> >>  3: >> + >> +.ifeqs    "\mode", "nvhe" >> +    /* >> +     * If the Trace Buffer is available, allow >> +     * the EL1 to own it. Note that EL1 cannot >> +     * trace the EL2, as it is prevented by >> +     * TRFCR_EL2.E2TRE == 0. >> +     */ >> +    ubfx    x0, x1, #ID_AA64DFR0_TRBE_SHIFT, #4 >> +    cbz    x0, 1f >> + >> +    mrs_s    x0, SYS_TRBIDR_EL1 >> +    and    x0, x0, TRBIDR_PROG >> +    cbnz    x0, 1f >> +    mov    x0, #(MDCR_EL2_E2TB_EL1_OWN << MDCR_EL2_E2TB_SHIFT) >> +    orr    x2, x2, x0 >> +.endif >> + >> +1: > > Note that this will (badly) conflict with the late-VHE patches[1], > where this code path has been reworked. Thanks for the heads up. We will need to see how things get merged. Ideally this patch and the previous one (TRBE definitions could go via the arm64 tree / kvm tree), in which case we could rebase these two patches on the respective tree. Cheers Suzuki