From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3CCFCC0032E for ; Wed, 25 Oct 2023 14:39:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sAaqfqmyH61dJ8eqx1wgjOUCWEcPjiLmi14QZ63F/yQ=; b=PPW1NV6CAMB4xj kvz7rOJlaHq+dGzqT9TJ+0D1sRKGLlkf9AQnx68CfYiztxlhxG6nclDcTaXRtwpuSm9wdk5eQypUM zqFFA04M0WpipJj6tTHwF1p5DSogQ19zoTRXHYjoaM+4bEniz9GJrLt8Qwmw37FB8NmnOyLUZcKyF sbmzT2mX5AbU3KYCKTKXa6usvzc1VFhV/Sdl8zYfoZpL8r6TTuAWrykGc/kl7ymFLU/AalstaP0J0 oMvREISRlszuEzF0PE5fjw8aSKl0rqzCM2duyI3/NsxxgC3FwdPiA9oI9tMbY+TUqNQB0ajpZ6K/w oPwPbi4U0tYQ1iKDqWAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qvf2b-00CXNe-2P; Wed, 25 Oct 2023 14:39:25 +0000 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qvf2Z-00CXMZ-0X for linux-riscv@lists.infradead.org; Wed, 25 Oct 2023 14:39:24 +0000 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-4081ccf69dcso5854895e9.0 for ; Wed, 25 Oct 2023 07:39:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1698244759; x=1698849559; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CB2fosNyHpnLw68d0tSWZGOJRnHryfe3IEs9QTF/RYI=; b=HHhMZSaeBIpaXDQq0glVyGws3BQkHmVoVWAbhgBwIEQs2cc6Q8xvr+Polx/YcOVHcJ ThY0m9NY3q0g4L4bI55Z4JB5XfxI8KfX91XYm6bw4DVpa/D/0S4YXITl1wBM1hMk4rn4 EIjetBTPdmwwt3SIf5JDRdhik5aYe2iiMX2owP7P5MuqxvhzeE0vlPG1lHoOvHn5Uqam B/sy3L//YzOMAyMjPB0jHTQ1hwVQI0Xz+Gvo/XC70jou+SKMUDTcRv26vKn5VOc+bTX6 oPviVwmZdQMLPHPDjp8gsatJhsWnMocnIZ+ayHxCuvwNNeJ6T/DXnsSx/00SKWTaMQir RA4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698244759; x=1698849559; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CB2fosNyHpnLw68d0tSWZGOJRnHryfe3IEs9QTF/RYI=; b=s+zoKcO5utAwPZ0Bn9Z5bS467i9QbCa9ZKmvu8bJx46aPmqVnTkxMWuo9PL/0gsDpK XewOITDPzG1DJGo6ubO12zVXv8HoT+95tMCo7EIVYzP2UMa520On5SvazxzzErJzMovV Nm5wD/j8fbcc60x3wLDSWZXfbaGquPV5+lzoA5m1Z/OJYh+JqHSFwF3uUBYZkLutbMHE FcS3ohmuv7AfcxTivnVOYardSV/7DhGbw6556Mqy+XViBKpR6QwFvIRI10bo9n5LeaAx ho6y9mpOrrmazLP7yGJZ8dGdIXzBIzwvvs8RodJOZ8umYoqkc5CNekgg8lnVjozgRBWJ FPag== X-Gm-Message-State: AOJu0Yxh69P2uDJl7SBVfvDmTiS7VAs5gQG4ttAgbcynpxqW/ha6VkB7 PKmXouAdytfsUKvvYtvYN50/dQ== X-Google-Smtp-Source: AGHT+IGqXcpRVWBXo+8Ix92wajAH3UIGgltE405zdSv3Pgfz1FUcUSG0CISD+Q5m0T1OIr23+ANGxQ== X-Received: by 2002:a05:600c:4fc6:b0:405:19dd:ad82 with SMTP id o6-20020a05600c4fc600b0040519ddad82mr15707940wmq.16.1698244758561; Wed, 25 Oct 2023 07:39:18 -0700 (PDT) Received: from [192.168.2.1] (146725694.box.freepro.com. [130.180.211.218]) by smtp.googlemail.com with ESMTPSA id o12-20020a05600c4fcc00b0040775501256sm14774508wmq.16.2023.10.25.07.39.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Oct 2023 07:39:18 -0700 (PDT) Message-ID: Date: Wed, 25 Oct 2023 16:39:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v7 2/3] clocksource: Add JH7110 timer driver Content-Language: en-US To: Xingyu Wu , Thomas Gleixner , Emil Renner Berthing , Christophe JAILLET Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Philipp Zabel , Walker Chen , Samin Guo , linux-kernel@vger.kernel.org, Conor Dooley References: <20231019053501.46899-1-xingyu.wu@starfivetech.com> <20231019053501.46899-3-xingyu.wu@starfivetech.com> <3f76f965-7c7b-109e-2ee0-3033e332e84b@linaro.org> From: Daniel Lezcano In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231025_073923_204927_619AF892 X-CRM114-Status: GOOD ( 23.49 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org CkhpIFhpbmd5dSwKCgpPbiAyNS8xMC8yMDIzIDExOjA0LCBYaW5neXUgV3Ugd3JvdGU6Cj4gT24g MjAyMy8xMC8yNCAyMjo1NiwgRGFuaWVsIExlemNhbm8gd3JvdGU6Cj4+Cj4+IEhpIFhpbmd5dSwK Pj4KPj4KPj4gT24gMTkvMTAvMjAyMyAwNzozNSwgWGluZ3l1IFd1IHdyb3RlOgo+Pj4gQWRkIHRp bWVyIGRyaXZlciBmb3IgdGhlIFN0YXJGaXZlIEpINzExMCBTb0MuCj4+Cj4+IEFzIGl0IGlzIGEg bmV3IHRpbWVyLCBwbGVhc2UgYWRkIGEgcHJvcGVyIG5pY2UgZGVzY3JpcHRpb24gZXhwbGFpbmlu ZyB0aGUgdGltZXIgaGFyZHdhcmUsIHRoYW5rcy4KPiAKPiBPSy4gV2lsbCBhZGQgdGhlIGRlc2Ny aXB0aW9uIGluIG5leHQgdmVyc2lvbi4KPiAKPj4KPj4+IFNpZ25lZC1vZmYtYnk6IFhpbmd5dSBX dSA8eGluZ3l1Lnd1QHN0YXJmaXZldGVjaC5jb20+Cj4+PiAtLS0KPj4+ICDCoCBNQUlOVEFJTkVS U8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfMKgwqAgNyAr Cj4+PiAgwqAgZHJpdmVycy9jbG9ja3NvdXJjZS9LY29uZmlnwqDCoMKgwqDCoMKgwqAgfMKgIDEx ICsKPj4+ICDCoCBkcml2ZXJzL2Nsb2Nrc291cmNlL01ha2VmaWxlwqDCoMKgwqDCoMKgIHzCoMKg IDEgKwo+Pj4gIMKgIGRyaXZlcnMvY2xvY2tzb3VyY2UvdGltZXItamg3MTEwLmMgfCAzODAgKysr KysrKysrKysrKysrKysrKysrKysrKysrKysKPj4+ICDCoCA0IGZpbGVzIGNoYW5nZWQsIDM5OSBp bnNlcnRpb25zKCspCj4+PiAgwqAgY3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvY2xvY2tzb3Vy Y2UvdGltZXItamg3MTEwLmMKPj4+Cj4+PiBkaWZmIC0tZ2l0IGEvTUFJTlRBSU5FUlMgYi9NQUlO VEFJTkVSUwo+Pj4gaW5kZXggN2E3YmQ4YmQ4MGU5Li45MWMwOWIzOTkxMzEgMTAwNjQ0Cj4+PiAt LS0gYS9NQUlOVEFJTkVSUwo+Pj4gKysrIGIvTUFJTlRBSU5FUlMKPj4+IEBAIC0yMDQ3Myw2ICsy MDQ3MywxMyBAQCBTOsKgwqDCoCBNYWludGFpbmVkCj4+PiAgwqAgRjrCoMKgwqAgRG9jdW1lbnRh dGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3NvdW5kL3N0YXJmaXZlLGpoNzExMC10ZG0ueWFtbAo+ Pj4gIMKgIEY6wqDCoMKgIHNvdW5kL3NvYy9zdGFyZml2ZS9qaDcxMTBfdGRtLmMKPj4+ICDCoCAr U1RBUkZJVkUgSkg3MTEwIFRJTUVSIERSSVZFUgo+Pj4gK006wqDCoMKgIFNhbWluIEd1byA8c2Ft aW4uZ3VvQHN0YXJmaXZldGVjaC5jb20+Cj4+PiArTTrCoMKgwqAgWGluZ3l1IFd1IDx4aW5neXUu d3VAc3RhcmZpdmV0ZWNoLmNvbT4KPj4+ICtTOsKgwqDCoCBTdXBwb3J0ZWQKPj4+ICtGOsKgwqDC oCBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvdGltZXIvc3RhcmZpdmUsamg3MTEw LXRpbWVyLnlhbWwKPj4+ICtGOsKgwqDCoCBkcml2ZXJzL2Nsb2Nrc291cmNlL3RpbWVyLWpoNzEx MC5jCj4+PiArCj4+PiAgwqAgU1RBUkZJVkUgSkg3MVgwIENMT0NLIERSSVZFUlMKPj4+ICDCoCBN OsKgwqDCoCBFbWlsIFJlbm5lciBCZXJ0aGluZyA8a2VybmVsQGVzbWlsLmRrPgo+Pj4gIMKgIE06 wqDCoMKgIEhhbCBGZW5nIDxoYWwuZmVuZ0BzdGFyZml2ZXRlY2guY29tPgo+Pj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvY2xvY2tzb3VyY2UvS2NvbmZpZyBiL2RyaXZlcnMvY2xvY2tzb3VyY2UvS2Nv bmZpZwo+Pj4gaW5kZXggMGJhMGRjNGVjZjA2Li44MjFhYmNjMWU1MTcgMTAwNjQ0Cj4+PiAtLS0g YS9kcml2ZXJzL2Nsb2Nrc291cmNlL0tjb25maWcKPj4+ICsrKyBiL2RyaXZlcnMvY2xvY2tzb3Vy Y2UvS2NvbmZpZwo+Pj4gQEAgLTY0MSw2ICs2NDEsMTcgQEAgY29uZmlnIFJJU0NWX1RJTUVSCj4+ PiAgwqDCoMKgwqDCoMKgwqAgaXMgYWNjZXNzZWQgdmlhIGJvdGggdGhlIFNCSSBhbmQgdGhlIHJk Y3ljbGUgaW5zdHJ1Y3Rpb24uwqAgVGhpcyBpcwo+Pj4gIMKgwqDCoMKgwqDCoMKgIHJlcXVpcmVk IGZvciBhbGwgUklTQy1WIHN5c3RlbXMuCj4+PiAgwqAgK2NvbmZpZyBTVEFSRklWRV9KSDcxMTBf VElNRVIKPj4+ICvCoMKgwqAgYm9vbCAiVGltZXIgZm9yIHRoZSBTVEFSRklWRSBKSDcxMTAgU29D Igo+Pj4gK8KgwqDCoCBkZXBlbmRzIG9uIEFSQ0hfU1RBUkZJVkUgfHwgQ09NUElMRV9URVNUCj4+ Cj4+IFlvdSBtYXkgd2FudCB0byB1c2UgQVJDSF9TVEFSRklWRSBvbmx5IGlmIHRoZSBwbGF0Zm9y bSBjYW4gbWFrZSB0aGlzIHRpbWVyIG9wdGlvbmFsLiBPdGhlcndpc2UsIHNldCB0aGUgb3B0aW9u IGZyb20gdGhlIHBsYXRmb3JtIEtjb25maWcgYW5kIHB1dCB0aGUgYm9vbCAiYmxhIGJsYSIgaWYg Q09NUElMRV9URVNUCj4gCj4gWWVzLCB0aGlzIHRpbWVyIG9ubHkgYmUgdXNlZCBvbiB0aGUgU3Rh ckZpdmUgU29DLiBTbyBJIGludGVuZCB0byBtb2RpZnkgdG8gdGhpczoKPiAKPiBib29sICJUaW1l ciBmb3IgdGhlIFNUQVJGSVZFIEpINzExMCBTb0MiIGlmIENPTVBJTEVfVEVTVAo+IGRlcGVuZHMg b24gQVJDSF9TVEFSRklWRQoKSW4gdGhpcyBjYXNlLCB5b3Ugc2hvdWxkIGNoYW5nZSB0aGUgcGxh dGZvcm0gY29uZmlnIGFuZCBzZWxlY3QgdGhlIHRpbWVyIApmcm9tIHRoZXJlLiBSZW1vdmUgdGhl IGRlcGVuZHMgb24gQVJDSF9TVEFSRklWRSBzbyBpdCBpcyBwb3NzaWJsZSBlbmFibGUgCmNyb3Nz IHRlc3QgY29tcGlsYXRpb24uIE90aGVyd2lzZSBDT01QSUxFX1RFU1Qgd2lsbCBub3Qgd29yayBv biBvdGhlciAKcGxhdGZvcm1zLgoKWyAuLi4gXQoKPj4+ICtzdHJ1Y3Qgamg3MTEwX2Nsa2V2dCB7 Cj4+PiArwqDCoMKgIHN0cnVjdCBjbG9ja19ldmVudF9kZXZpY2UgZXZ0Owo+Pj4gK8KgwqDCoCBz dHJ1Y3QgY2xvY2tzb3VyY2UgY3M7Cj4+PiArwqDCoMKgIGJvb2wgY3NfaXNfdmFsaWQ7Cj4+PiAr wqDCoMKgIHN0cnVjdCBjbGsgKmNsazsKPj4+ICvCoMKgwqAgc3RydWN0IHJlc2V0X2NvbnRyb2wg KnJzdDsKPj4+ICvCoMKgwqAgdTMyIHJhdGU7Cj4+PiArwqDCoMKgIHUzMiByZWxvYWRfdmFsOwo+ Pj4gK8KgwqDCoCB2b2lkIF9faW9tZW0gKmJhc2U7Cj4+PiArwqDCoMKgIGNoYXIgbmFtZVtzaXpl b2YoImpoNzExMC10aW1lci5jaFgiKV07Cj4+PiArfTsKPj4+ICsKPj4+ICtzdHJ1Y3Qgamg3MTEw X3RpbWVyX3ByaXYgewo+Pj4gK8KgwqDCoCBzdHJ1Y3QgY2xrICpwY2xrOwo+Pj4gK8KgwqDCoCBz dHJ1Y3QgcmVzZXRfY29udHJvbCAqcHJzdDsKPj4+ICvCoMKgwqAgc3RydWN0IGpoNzExMF9jbGtl dnQgY2xrZXZ0W0pINzExMF9USU1FUl9DSF9NQVhdOwo+Pgo+PiBXaHkgZG8geW91IG5lZWQgc2V2 ZXJhbCBjbG9jayBldmVudHMgYW5kIGNsb2NrIHNvdXJjZXMgPwo+IAo+IFRoaXMgdGltZXIgaGFz IGZvdXIgY291bnRlcnMgKGNoYW5uZWxzKSB3aGljaCBydW4gaW5kZXBlbmRlbnRseS4gU28gZWFj aCBjb3VudGVyIGNhbiBoYXZlIGl0cyBvd24gY2xvY2sgZXZlbnQgYW5kIGNsb2NrIHNvdXJjZSB0 byBjb25maWd1cmUgZGlmZmVyZW50IHNldHRpbmdzLgoKVGhlIGtlcm5lbCBvbmx5IG5lZWRzIG9u ZSBjbG9ja3NvdXJjZS4gVXN1YWxseSBtdWx0aXBsZSBjbG9ja2V2ZW50cyBhcmUgCnBlci1jcHUg YmFzZWQgc3lzdGVtLgoKVGhlIGRyaXZlciBkb2VzIG5vdCBzZWVtIHRvIGhhdmUgYSBwZXIgY3B1 IHRpbWVyIGJ1dCBqdXN0IGluaXRpYWxpemluZyAKbXVsdGlwbGUgY2xvY2tldmVudHMgd2hpY2gg d2lsbCBlbmQgdXAgdW51c2VkLCB3YXN0aW5nIGVuZXJneS4KCgotLSAKPGh0dHA6Ly93d3cubGlu YXJvLm9yZy8+IExpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBBUk0gU29D cwoKRm9sbG93IExpbmFybzogIDxodHRwOi8vd3d3LmZhY2Vib29rLmNvbS9wYWdlcy9MaW5hcm8+ IEZhY2Vib29rIHwKPGh0dHA6Ly90d2l0dGVyLmNvbS8jIS9saW5hcm9vcmc+IFR3aXR0ZXIgfAo8 aHR0cDovL3d3dy5saW5hcm8ub3JnL2xpbmFyby1ibG9nLz4gQmxvZwoKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LXJpc2N2IG1haWxpbmcgbGlz dApsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9106B2AB34 for ; Wed, 25 Oct 2023 14:39:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rqInz86u" Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D23A9DC for ; Wed, 25 Oct 2023 07:39:20 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-4081ccf69dcso5854905e9.0 for ; Wed, 25 Oct 2023 07:39:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1698244759; x=1698849559; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CB2fosNyHpnLw68d0tSWZGOJRnHryfe3IEs9QTF/RYI=; b=rqInz86ufeeDKaBhGjYlLXxAz+tTNal+VF/vrivCM2NlZtXNoD0FZEFV/+aqV8A5p6 wTLtVGlfve6UuxGhZ3map5eO72WOt+5O+ufVcSaab7d9anvxI1hC/F/fuPQUx0TP5RBm sw3exhZJvwCmgOgDHtKDOGGjRML7WRMxwYCnmvHOY5MBjhi1bd72eh1dv8qBZYlUhBiF KNnHYhiTmWLc51bU1CyMbpg5Nn8j2qXXt3wnZnguHgtvnvmTgLdYM8EnI319riGStdPz JaTePrfLFU+/BjgAJ+6J7MSg53jxTLOlOgnxa5OCYDXZVWOwwE/vHv0KddhU2ahuQiOK i5eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698244759; x=1698849559; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CB2fosNyHpnLw68d0tSWZGOJRnHryfe3IEs9QTF/RYI=; b=Q1784HzbpKp1Q9sspSXtbzqudBzfURrrXKmggfNUUiiljmhZizsOU9bIhs1+Wychnm qk7gumMld6J6Q0RODLUH42j4WZ4NLTrJQCGjuiErv6z58Mtz7XF2s5iEIAUevsL18p78 hixw092ZTNMv778Ow4gVy1+kRiK6tN2+6xCVaVX+edeTwC6pdPYCMxwewKswWD+ftajd ahPH6/sWH1Drh4hVqMQEUKirUtW9TK7W2GAIa/IpNDAsJvAaC3evL0GZ00/lDM+E5rmo DnUv1bg0UH/28zEyT08pr3rS2s5ilNveZtiVUyKnCAgfJi2HCSuTeI0n7qmWpa0xh6OU cnHA== X-Gm-Message-State: AOJu0YxjiHORjlUMmpetrau2w1J5KYaeb7dkots43C84mbPtDOTWjZop S4IZ9VuXUD0JzAVRkzm52ArYUwBFiwMPUcEoxuu6ew== X-Google-Smtp-Source: AGHT+IGqXcpRVWBXo+8Ix92wajAH3UIGgltE405zdSv3Pgfz1FUcUSG0CISD+Q5m0T1OIr23+ANGxQ== X-Received: by 2002:a05:600c:4fc6:b0:405:19dd:ad82 with SMTP id o6-20020a05600c4fc600b0040519ddad82mr15707940wmq.16.1698244758561; Wed, 25 Oct 2023 07:39:18 -0700 (PDT) Received: from [192.168.2.1] (146725694.box.freepro.com. [130.180.211.218]) by smtp.googlemail.com with ESMTPSA id o12-20020a05600c4fcc00b0040775501256sm14774508wmq.16.2023.10.25.07.39.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Oct 2023 07:39:18 -0700 (PDT) Message-ID: Date: Wed, 25 Oct 2023 16:39:14 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v7 2/3] clocksource: Add JH7110 timer driver Content-Language: en-US To: Xingyu Wu , Thomas Gleixner , Emil Renner Berthing , Christophe JAILLET Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Philipp Zabel , Walker Chen , Samin Guo , linux-kernel@vger.kernel.org, Conor Dooley References: <20231019053501.46899-1-xingyu.wu@starfivetech.com> <20231019053501.46899-3-xingyu.wu@starfivetech.com> <3f76f965-7c7b-109e-2ee0-3033e332e84b@linaro.org> From: Daniel Lezcano In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Xingyu, On 25/10/2023 11:04, Xingyu Wu wrote: > On 2023/10/24 22:56, Daniel Lezcano wrote: >> >> Hi Xingyu, >> >> >> On 19/10/2023 07:35, Xingyu Wu wrote: >>> Add timer driver for the StarFive JH7110 SoC. >> >> As it is a new timer, please add a proper nice description explaining the timer hardware, thanks. > > OK. Will add the description in next version. > >> >>> Signed-off-by: Xingyu Wu >>> --- >>>   MAINTAINERS                        |   7 + >>>   drivers/clocksource/Kconfig        |  11 + >>>   drivers/clocksource/Makefile       |   1 + >>>   drivers/clocksource/timer-jh7110.c | 380 +++++++++++++++++++++++++++++ >>>   4 files changed, 399 insertions(+) >>>   create mode 100644 drivers/clocksource/timer-jh7110.c >>> >>> diff --git a/MAINTAINERS b/MAINTAINERS >>> index 7a7bd8bd80e9..91c09b399131 100644 >>> --- a/MAINTAINERS >>> +++ b/MAINTAINERS >>> @@ -20473,6 +20473,13 @@ S:    Maintained >>>   F:    Documentation/devicetree/bindings/sound/starfive,jh7110-tdm.yaml >>>   F:    sound/soc/starfive/jh7110_tdm.c >>>   +STARFIVE JH7110 TIMER DRIVER >>> +M:    Samin Guo >>> +M:    Xingyu Wu >>> +S:    Supported >>> +F:    Documentation/devicetree/bindings/timer/starfive,jh7110-timer.yaml >>> +F:    drivers/clocksource/timer-jh7110.c >>> + >>>   STARFIVE JH71X0 CLOCK DRIVERS >>>   M:    Emil Renner Berthing >>>   M:    Hal Feng >>> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig >>> index 0ba0dc4ecf06..821abcc1e517 100644 >>> --- a/drivers/clocksource/Kconfig >>> +++ b/drivers/clocksource/Kconfig >>> @@ -641,6 +641,17 @@ config RISCV_TIMER >>>         is accessed via both the SBI and the rdcycle instruction.  This is >>>         required for all RISC-V systems. >>>   +config STARFIVE_JH7110_TIMER >>> +    bool "Timer for the STARFIVE JH7110 SoC" >>> +    depends on ARCH_STARFIVE || COMPILE_TEST >> >> You may want to use ARCH_STARFIVE only if the platform can make this timer optional. Otherwise, set the option from the platform Kconfig and put the bool "bla bla" if COMPILE_TEST > > Yes, this timer only be used on the StarFive SoC. So I intend to modify to this: > > bool "Timer for the STARFIVE JH7110 SoC" if COMPILE_TEST > depends on ARCH_STARFIVE In this case, you should change the platform config and select the timer from there. Remove the depends on ARCH_STARFIVE so it is possible enable cross test compilation. Otherwise COMPILE_TEST will not work on other platforms. [ ... ] >>> +struct jh7110_clkevt { >>> +    struct clock_event_device evt; >>> +    struct clocksource cs; >>> +    bool cs_is_valid; >>> +    struct clk *clk; >>> +    struct reset_control *rst; >>> +    u32 rate; >>> +    u32 reload_val; >>> +    void __iomem *base; >>> +    char name[sizeof("jh7110-timer.chX")]; >>> +}; >>> + >>> +struct jh7110_timer_priv { >>> +    struct clk *pclk; >>> +    struct reset_control *prst; >>> +    struct jh7110_clkevt clkevt[JH7110_TIMER_CH_MAX]; >> >> Why do you need several clock events and clock sources ? > > This timer has four counters (channels) which run independently. So each counter can have its own clock event and clock source to configure different settings. The kernel only needs one clocksource. Usually multiple clockevents are per-cpu based system. The driver does not seem to have a per cpu timer but just initializing multiple clockevents which will end up unused, wasting energy. -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog