Re: [PATCH v4] crypto/ccp: Introduce SNP_VERIFY_MITIGATION command

["Pratik R. Sampat" <prsampat@amd.com>]

On 6/9/26 3:48 PM, Tycho Andersen wrote:
> Hi Pratik,
> 
>>
>> See SEV-SNP Firmware ABI specifications 1.58, SNP_VERIFY_MITIGATION for
>> more details.
>>
>> Signed-off-by: Pratik R. Sampat <prsampat@amd.com>
> 
> Reviewed-by: Tycho Andersen (AMD) <tycho@kernel.org>
> 
>> +	if (dst.mit_failure_status) {
>> +		dev_err(sev->dev, "Verify Mitigation - failure status: 0x%x\n",
>> +			dst.mit_failure_status);
>> +		return -EIO;
> 
> Elsewhere the CCP uses EIO to represent a failure to communicate with
> the PSP, but here things worked, it was just in an invalid state.
> Maybe worth a different errno here, -EINVAL or so.
> 

-EIO is a bit awkward here for sure. -EINVAL seems to make more sense.

Thanks!
--Pratik