Re: [PATCH 2/3] miitool: clarify help text for default behavior and -s option

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

On 7/11/25 14:27, Bo Sun wrote:
> The -s option description was misleading about default behavior.
> Clarify that miitool without options shows all PHYs, and -s requires
> a device argument.
> 
> Signed-off-by: Bo Sun <bo@mboxify.com>

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

> ---
>  commands/miitool.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/commands/miitool.c b/commands/miitool.c
> index 0121fdc542..0c70b51ad3 100644
> --- a/commands/miitool.c
> +++ b/commands/miitool.c
> @@ -344,9 +344,11 @@ BAREBOX_CMD_HELP_TEXT("Media Independent Interface (MII) unit as well as allowin
>  BAREBOX_CMD_HELP_TEXT("register dummy PHY devices for raw MDIO access. Most fast ethernet")
>  BAREBOX_CMD_HELP_TEXT("adapters use an MII to autonegotiate link speed and duplex setting.")
>  BAREBOX_CMD_HELP_TEXT("")
> +BAREBOX_CMD_HELP_TEXT("When run without options, shows status of all PHYs.")
> +BAREBOX_CMD_HELP_TEXT("")
>  BAREBOX_CMD_HELP_TEXT("Options:")
>  BAREBOX_CMD_HELP_OPT("-v", "increase verbosity")
> -BAREBOX_CMD_HELP_OPT("-s <devpath/devname>", "show PHY status (not providing PHY prints status of all)")
> +BAREBOX_CMD_HELP_OPT("-s <devpath/devname>", "show PHY status for specified device")
>  BAREBOX_CMD_HELP_OPT("-r <busno>:<adr>", "register a PHY")
>  BAREBOX_CMD_HELP_END
>  
> 
> 

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |