From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v4] ethdev: replace bus specific struct with
	generic dev
Date: Tue, 3 Apr 2018 10:50:28 +0100
Message-ID: <d1154c85-c5c8-da0e-43da-c5dfd03bd849@intel.com>
References: <20180329175206.127943-1-ferruh.yigit@intel.com>
 <20180330151704.183495-1-ferruh.yigit@intel.com>
 <CALwxeUs+Hfhu2L=0F4U5yJLk9_5ZffvDZFcLLgdy4RtfS-GH3A@mail.gmail.com>
 <08358c50-1076-21c0-cf79-25d7a25d6255@caviumnetworks.com>
 <CALwxeUtEDmhYXCgnzx-fE-O-Ee54z1sdT6MMuwC9xKfF_b2GWQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, Shreyansh Jain <shreyansh.jain@nxp.com>,
 Allain Legacy <allain.legacy@windriver.com>,
 Tomasz Duszynski <tdu@semihalf.com>, Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@6wind.com>,
 santosh <santosh.shukla@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 33B3B1B6D2
 for <dev@dpdk.org>; Tue,  3 Apr 2018 12:00:35 +0200 (CEST)
In-Reply-To: <CALwxeUtEDmhYXCgnzx-fE-O-Ee54z1sdT6MMuwC9xKfF_b2GWQ@mail.gmail.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 4/3/2018 10:06 AM, David Marchand wrote:
> On Mon, Apr 2, 2018 at 6:13 PM, santosh
> <santosh.shukla@caviumnetworks.com> wrote:
>> On Friday 30 March 2018 08:59 PM, David Marchand wrote:
>>> I can see we enforce the driver name by putting it after the call to
>>> .dev_infos_get.
>>> http://dpdk.org/browse/dpdk/tree/lib/librte_ether/rte_ethdev.c#n2399
>>>
>>> octeontx pmd seems to try to do something about it:
>>> http://dpdk.org/browse/dpdk/tree/drivers/net/octeontx/octeontx_ethdev.c#n622
>>>
>>> Not sure it does something, might be a thing to cleanup.
>>>
>>>
>> In case, if your referring to driver_name update then
>> indeed its a cleanup [1].
>>
>> Otherwise, I don't see any issue with v4 Or
>> may be /I /misunderstood your comment.
> 
> I agree there is no fundamental issue.
> 
>     dev_info->device = dev->device;
> 
>     RTE_FUNC_PTR_OR_RET(*dev->dev_ops->dev_infos_get);
>     (*dev->dev_ops->dev_infos_get)(dev, dev_info);
>     dev_info->driver_name = dev->device->driver->name;
> 
> If somebody (I mean some pmd out there) has a usecase with
> dev_info->device != dev->device, why not.

Intentional let drivers update this variable although I don't also see any use
case of it.

This variable was set by PMDs before this patch, so I don't see any reason to be
so strict here.

If driver does anything ethdev will set dev_info->device for it, if it want to
overwrite, for any reason, it will have the capability.

> 
> Thomas ?
> 
>