From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from second.openwall.net (second.openwall.net [193.110.157.125]) by smtp.lore.kernel.org (Postfix) with SMTP id 8F745E64010 for ; Thu, 21 Nov 2024 20:35:53 +0000 (UTC) Received: (qmail 16151 invoked by uid 550); 21 Nov 2024 20:35:41 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 16098 invoked from network); 21 Nov 2024 20:35:41 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=rlelLu NxaQbOjS+AkBlNiz3aAj7rJ3O71jw+IWqCHcY=; b=FLFIZr1rr1BmrgPgUxiG3g Sn9cNjYHRsSVYuOrafvD0Oas8M5sJR3icX2DR4H+Ij8pW1K/nJ1dQ80N/VTGAfJb gUzKG2pWPH6ZwcS7EP/V5A85Z803GnU1c+1Pj0XfDxOkcnQU020QCLahQT6i/1Ee anToxEuakKvgsE2qEjn6OwHJRSEGLWzplZjyqgcyR2KALhJ6iuST4Ap9niIrbXek lmSmFnHLYvZxf1hDcNh3nvmSH52GrdPBsfQ2FxMXHw5I/46RlnCZt2b3PBSYYnkh WU2kJJDaY/8gGcEnFFq9zO4Zjz7tEFINhYu22GZYGE5uf9G8uY71LM5QXTQvt1xw == Message-ID: Subject: Re: [PATCH v21 6/6] samples/check-exec: Add an enlighten "inc" interpreter and 28 tests From: Mimi Zohar To: =?ISO-8859-1?Q?Micka=EBl_Sala=FCn?= , Al Viro , Christian Brauner , Kees Cook , Paul Moore , Serge Hallyn Cc: Adhemerval Zanella Netto , Alejandro Colomar , Aleksa Sarai , Andrew Morton , Andy Lutomirski , Arnd Bergmann , Casey Schaufler , Christian Heimes , Dmitry Vyukov , Elliott Hughes , Eric Biggers , Eric Chiang , Fan Wu , Florian Weimer , Geert Uytterhoeven , James Morris , Jan Kara , Jann Horn , Jeff Xu , Jonathan Corbet , Jordan R Abrahams , Lakshmi Ramasubramanian , Linus Torvalds , Luca Boccassi , Luis Chamberlain , "Madhavan T . Venkataraman" , Matt Bobrowski , Matthew Garrett , Matthew Wilcox , Miklos Szeredi , Nicolas Bouchinet , Scott Shell , Shuah Khan , Stephen Rothwell , Steve Dower , Steve Grubb , "Theodore Ts'o" , Thibaut Sautereau , Vincent Strubel , Xiaoming Ni , Yin Fengwei , kernel-hardening@lists.openwall.com, linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Date: Thu, 21 Nov 2024 15:34:47 -0500 In-Reply-To: <20241112191858.162021-7-mic@digikod.net> References: <20241112191858.162021-1-mic@digikod.net> <20241112191858.162021-7-mic@digikod.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.4 (3.52.4-2.fc40) MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 5j4NljDjvOK_TMG_-0z2jGGIPzeoKdQE X-Proofpoint-ORIG-GUID: y_4dWfxzFvg9Bphre9Ic1A5QOC1Kd_4I X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 suspectscore=0 adultscore=0 mlxlogscore=977 mlxscore=0 malwarescore=0 spamscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2411210153 Hi Micka=C3=ABl, On Tue, 2024-11-12 at 20:18 +0100, Micka=C3=ABl Sala=C3=BCn wrote: >=20 > + > +/* Returns 1 on error, 0 otherwise. */ > +static int interpret_stream(FILE *script, char *const script_name, > + char *const *const envp, const bool restrict_stream) > +{ > + int err; > + char *const script_argv[] =3D { script_name, NULL }; > + char buf[128] =3D {}; > + size_t buf_size =3D sizeof(buf); > + > + /* > + * We pass a valid argv and envp to the kernel to emulate a native > + * script execution. We must use the script file descriptor instead of > + * the script path name to avoid race conditions. > + */ > + err =3D execveat(fileno(script), "", script_argv, envp, > + AT_EMPTY_PATH | AT_EXECVE_CHECK); At least with v20, the AT_CHECK always was being set, independent of whethe= r set-exec.c set it. I'll re-test with v21. thanks, Mimi > + if (err && restrict_stream) { > + perror("ERROR: Script execution check"); > + return 1; > + } > + > + /* Reads script. */ > + buf_size =3D fread(buf, 1, buf_size - 1, script); > + return interpret_buffer(buf, buf_size); > +} > +