diff for duplicates of <d120d50005042107314cbacdea@mail.gmail.com> diff --git a/a/1.txt b/N1/1.txt index 3bf6f77..0ec792e 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -35,7 +35,7 @@ refcnt=%d.\n", 461 device_remove_file(&sl->dev, &sl->attr_val); 462 device_unregister(&sl->dev); 463 w1_family_put(sl->family); -. And caller does kfree(sl); +.. And caller does kfree(sl); Now, if application opens slave's sysfs attribute while other thread exited the loop and is about to remove attributes, then you will kfree @@ -65,7 +65,7 @@ dump for all kind of data (looks like debug one). You will not be able to cram all 1-wire devices into unified interface. You will need to build classes on top of it and you might use connector (I am not sure) bit not on w1 bus level. -.. +... > > w1-slave-attr-group.patc > > Add 2 default attributes "family" and "serial" to slave devices, every > > 1-Wire slave has them. Use attribute_group to handle. The rest of slave @@ -75,7 +75,7 @@ use connector (I am not sure) bit not on w1 bus level. > Why do you need separate files? Yeah, could probably drop them. -.. +... > > w1-drop-owner.patch > > Drop owner field from w1_master and w1_slave structures. Just having it > > there does not magically fixes lifetime rules. @@ -246,7 +246,7 @@ You need to fix lifetime rules. > > in regular sense. > > - rename w1_therm to w1_thermal. > -> smem = simple memory id, it is official name AFAIR. +> smem == simple memory id, it is official name AFAIR. > Renames are superfluous, family_ops contains a "must have" operations, > driver writer can easily add it's own if it is needed. diff --git a/a/content_digest b/N1/content_digest index 1635662..ec7cea7 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,8 +1,8 @@ "ref\0200504210207.02421.dtor_core@ameritech.net\0" "ref\01114089504.29655.93.camel@uganda\0" - "From\0dmitry.torokhov@gmail.com (Dmitry Torokhov)\0" - "Subject\0[RFC/PATCH 0/22] W1: sysfs, lifetime and other fixes\0" - "Date\0Thu, 19 May 2005 06:25:53 +0000\0" + "From\0Dmitry Torokhov <dmitry.torokhov@gmail.com>\0" + "Subject\0Re: [RFC/PATCH 0/22] W1: sysfs, lifetime and other fixes\0" + "Date\0Thu, 21 Apr 2005 09:31:44 -0500\0" "To\0johnpol@2ka.mipt.ru\0" "Cc\0sensors@stimpy.netroedge.com" LKML <linux-kernel@vger.kernel.org> @@ -46,7 +46,7 @@ "461 device_remove_file(&sl->dev, &sl->attr_val);\n" "462 device_unregister(&sl->dev);\n" "463 w1_family_put(sl->family);\n" - ". And caller does kfree(sl);\n" + ".. And caller does kfree(sl);\n" "\n" "Now, if application opens slave's sysfs attribute while other thread\n" "exited the loop and is about to remove attributes, then you will kfree\n" @@ -76,7 +76,7 @@ "You will not be able to cram all 1-wire devices into unified\n" "interface. You will need to build classes on top of it and you might\n" "use connector (I am not sure) bit not on w1 bus level.\n" - "..\n" + "...\n" "> > w1-slave-attr-group.patc\n" "> > Add 2 default attributes \"family\" and \"serial\" to slave devices, every\n" "> > 1-Wire slave has them. Use attribute_group to handle. The rest of slave\n" @@ -86,7 +86,7 @@ "> Why do you need separate files?\n" "\n" "Yeah, could probably drop them.\n" - "..\n" + "...\n" "> > w1-drop-owner.patch\n" "> > Drop owner field from w1_master and w1_slave structures. Just having it\n" "> > there does not magically fixes lifetime rules.\n" @@ -257,7 +257,7 @@ "> > in regular sense.\n" "> > - rename w1_therm to w1_thermal.\n" "> \n" - "> smem = simple memory id, it is official name AFAIR.\n" + "> smem == simple memory id, it is official name AFAIR.\n" "> Renames are superfluous, family_ops contains a \"must have\" operations,\n" "> driver writer can easily add it's own if it is needed.\n" "\n" @@ -320,4 +320,4 @@ "-- \n" Dmitry -374906db54b8c6d7d4242d7cda95096f4e37e47147bbff8f67b3f5de06464457 +0303b51d36021422f112394ba38697194cf8b7a9e9f475bcc3c54df8d828a415
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.