Re: [PATCH v2 1/6] vhost: decouple guest pages population from async datapath

[Maxime Coquelin <maxime.coquelin@redhat.com>]

On 9/4/26 9:46 AM, David Marchand wrote:
> The vhost crypto zero-copy feature relies on the
> RTE_VHOST_USER_ASYNC_COPY flag to enable guest page tracking
> (guest_pages array population and MAP_POPULATE during mmap).
> 
> Introduce a RTE_VHOST_USER_MAP_POPULATE flag that maps to
> RTE_VHOST_USER_ASYNC_COPY at this point in time.
> 
> Adjust vhost_crypto example and remove the unnecessary
> ALLOW_EXPERIMENTAL_API flag as this example does not use any
> experimental APIs.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>   doc/guides/prog_guide/vhost_lib.rst | 9 +++++++++
>   examples/vhost_crypto/Makefile      | 1 -
>   examples/vhost_crypto/main.c        | 2 +-
>   examples/vhost_crypto/meson.build   | 1 -
>   lib/vhost/rte_vhost.h               | 1 +
>   lib/vhost/socket.c                  | 9 +++++++++
>   lib/vhost/vhost.h                   | 1 +
>   lib/vhost/vhost_user.c              | 4 ++--
>   8 files changed, 23 insertions(+), 5 deletions(-)
> 
Sounds reasonable to keep the same value as RTE_VHOST_USER_ASYNC_COPY to
not break compatibility for existing Vhsot-crypto applications.

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime