From: James Feist <james.feist@linux.intel.com>
To: Patrick Venture <venture@google.com>, "Tanous, Ed" <ed.tanous@intel.com>
Cc: OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Peter Lundgren <peterlundgren@google.com>
Subject: Re: FruDevice - next device name matching
Date: Tue, 13 Aug 2019 09:05:24 -0700 [thread overview]
Message-ID: <d1536050-9b41-b84d-451e-ff75cd144811@linux.intel.com> (raw)
In-Reply-To: <CAO=noty9ksKUrPEvtgJGCmW0P01MBPGV72chtABF=vTyBCyuhg@mail.gmail.com>
On 8/13/19 9:03 AM, Patrick Venture wrote:
> I wanted to verify this was the expected behavior:
>
> |-/xyz/openbmc_project/FruDevice/Card
> |-/xyz/openbmc_project/FruDevice/Card_0
> |-/xyz/openbmc_project/FruDevice/Card_01
> |-/xyz/openbmc_project/FruDevice/Card_012
> |-/xyz/openbmc_project/FruDevice/Card_0123
>
> It's fine if that is, albeit in the case where we have 11 cards,
> that's going to be problematic. My theory is, it's meant to increment
> the last number part of the name. This can be done by a regex parsing
> of the name string and then pulling out the number, incrementing and
> tracking the highest number hit.
>
> https://github.com/openbmc/entity-manager/blob/master/src/FruDevice.cpp#L869
>
> If that's what it should be doing, then I can submit a patch after
> some testing, I just wanted to verify.
The path name just needs to be different, that patch would be great imo.
Thanks
James
>
> Patrick
>
next prev parent reply other threads:[~2019-08-13 16:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 16:03 FruDevice - next device name matching Patrick Venture
2019-08-13 16:05 ` James Feist [this message]
2019-08-13 16:06 ` Patrick Venture
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1536050-9b41-b84d-451e-ff75cd144811@linux.intel.com \
--to=james.feist@linux.intel.com \
--cc=ed.tanous@intel.com \
--cc=openbmc@lists.ozlabs.org \
--cc=peterlundgren@google.com \
--cc=venture@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.