From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH] drm/amdgpu: refine reboot debugfs operation in ras case Date: Mon, 21 Oct 2019 11:11:31 +0200 Message-ID: References: <20191021090735.19696-1-guchun.chen@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20191021090735.19696-1-guchun.chen-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Chen, Guchun" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , "Zhang, Hawking" , "Li, Dennis" , "Grodzovsky, Andrey" , "Zhou1, Tao" Cc: "Li, Candice" QW0gMjEuMTAuMTkgdW0gMTE6MDggc2NocmllYiBDaGVuLCBHdWNodW46Cj4gUmVib290IG9wZXJh dGlvbiBmb3IgcmFzIHJlY292ZXJ5IGlzIG9uZSBjb21tb24gZGVidWdmcwo+IGVudHJ5LCB3aGlj aCBzaG91bGQgZ2V0IHJpZCBvZiByYXNfY3RybCBub2RlIGFuZCByZW1vdmUKPiBpcCBkZXBlbmRl bmNlIHdoZW4gaW5wdXR0aW5nIGJ5IHVzZXIuIFNvIGFkZCBvbmUgbmV3Cj4gYXV0b19yZWJvb3Qg bm9kZSBpbiByYXMgZGVidWdmcyBkaXIgdG8gYWNoaWV2ZSB0aGlzLgoKV2UgbmVlZCBzb21lIGp1 c3RpZmljYXRpb24gd2h5IHRoaXMgY2FuJ3QgYmUgYSBtb2R1bGUgcGFyYW1ldGVyIGluc3RlYWQu CgpGb3IgZXhhbXBsZSB3cml0ZSBzb21ldGhpbmcgbGlrZSB3ZSB3YW50IHRvIGNvbnRyb2wgcmVi b290IGJlaGF2aW9yIG9uIGEgCnBlciBkZXZpY2UgYmFzaXMuCgpBcGFydCBmcm9tIHRoYXQgbG9v a3MgbGlrZSBhIG5pY2UgY2xlYW51cCB0byBtZS4KClJlZ2FyZHMsCkNocmlzdGlhbi4KCj4KPiBT aWduZWQtb2ZmLWJ5OiBHdWNodW4gQ2hlbiA8Z3VjaHVuLmNoZW5AYW1kLmNvbT4KPiAtLS0KPiAg IGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9yYXMuYyB8IDU1ICsrKysrKysrKysr KysrKysrKysrKystLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCA0OSBpbnNlcnRpb25zKCspLCA2IGRl bGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2Ft ZGdwdV9yYXMuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9yYXMuYwo+IGlu ZGV4IDYyMjAzOTQ1MjFlNC4uM2FkY2QyOWZlYjVmIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9yYXMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQv YW1kZ3B1L2FtZGdwdV9yYXMuYwo+IEBAIC0xNTMsOCArMTUzLDYgQEAgc3RhdGljIGludCBhbWRn cHVfcmFzX2RlYnVnZnNfY3RybF9wYXJzZV9kYXRhKHN0cnVjdCBmaWxlICpmLAo+ICAgCQlvcCA9 IDE7Cj4gICAJZWxzZSBpZiAoc3NjYW5mKHN0ciwgImluamVjdCAlMzJzICU4cyIsIGJsb2NrX25h bWUsIGVycikgPT0gMikKPiAgIAkJb3AgPSAyOwo+IC0JZWxzZSBpZiAoc3NjYW5mKHN0ciwgInJl Ym9vdCAlMzJzIiwgYmxvY2tfbmFtZSkgPT0gMSkKPiAtCQlvcCA9IDM7Cj4gICAJZWxzZSBpZiAo c3RyWzBdICYmIHN0clsxXSAmJiBzdHJbMl0gJiYgc3RyWzNdKQo+ICAgCQkvKiBhc2NpaSBzdHJp bmcsIGJ1dCBjb21tYW5kcyBhcmUgbm90IG1hdGNoZWQuICovCj4gICAJCXJldHVybiAtRUlOVkFM Owo+IEBAIC0yMjMsNyArMjIxLDYgQEAgc3RhdGljIHN0cnVjdCByYXNfbWFuYWdlciAqYW1kZ3B1 X3Jhc19maW5kX29iaihzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwKPiAgICAqIC0gMDogZGlz YWJsZSBSQVMgb24gdGhlIGJsb2NrLiBUYWtlIDo6aGVhZCBhcyBpdHMgZGF0YS4KPiAgICAqIC0g MTogZW5hYmxlIFJBUyBvbiB0aGUgYmxvY2suIFRha2UgOjpoZWFkIGFzIGl0cyBkYXRhLgo+ICAg ICogLSAyOiBpbmplY3QgZXJyb3JzIG9uIHRoZSBibG9jay4gVGFrZSA6OmluamVjdCBhcyBpdHMg ZGF0YS4KPiAtICogLSAzOiByZWJvb3Qgb24gdW5yZWNvdmVyYWJsZSBlcnJvcgo+ICAgICoKPiAg ICAqIEhvdyB0byB1c2UgdGhlIGludGVyZmFjZT8KPiAgICAqIHByb2dyYW1zOgo+IEBAIC0zMDUs OSArMzAyLDYgQEAgc3RhdGljIHNzaXplX3QgYW1kZ3B1X3Jhc19kZWJ1Z2ZzX2N0cmxfd3JpdGUo c3RydWN0IGZpbGUgKmYsIGNvbnN0IGNoYXIgX191c2VyICoKPiAgIAkJLyogZGF0YS5pbmplY3Qu YWRkcmVzcyBpcyBvZmZzZXQgaW5zdGVhZCBvZiBhYnNvbHV0ZSBncHUgYWRkcmVzcyAqLwo+ICAg CQlyZXQgPSBhbWRncHVfcmFzX2Vycm9yX2luamVjdChhZGV2LCAmZGF0YS5pbmplY3QpOwo+ICAg CQlicmVhazsKPiAtCWNhc2UgMzoKPiAtCQlhbWRncHVfcmFzX2dldF9jb250ZXh0KGFkZXYpLT5y ZWJvb3QgPSB0cnVlOwo+IC0JCWJyZWFrOwo+ICAgCWRlZmF1bHQ6Cj4gICAJCXJldCA9IC1FSU5W QUw7Cj4gICAJCWJyZWFrOwo+IEBAIC0zNDYsNiArMzQwLDQ2IEBAIHN0YXRpYyBzc2l6ZV90IGFt ZGdwdV9yYXNfZGVidWdmc19lZXByb21fd3JpdGUoc3RydWN0IGZpbGUgKmYsIGNvbnN0IGNoYXIg X191c2VyCj4gICAJcmV0dXJuIHJldCA9PSAxID8gc2l6ZSA6IC1FSU87Cj4gICB9Cj4gICAKPiAr LyoqCj4gKyAqIERPQzogQU1ER1BVIFJBUyBkZWJ1Z2ZzIGF1dG8gcmVib290IGludGVyZmFjZQo+ ICsgKgo+ICsgKiBBZnRlciBvbmUgdW5jb3JyZWN0YWJsZSBlcnJvciBoYXBwZW5zLCBHUFUgcmVj b3Zlcnkgd2lsbCBiZSBzY2hlZHVsZWQuCj4gKyAqIER1ZSB0byB0aGUga25vd24gcHJvYmxlbSBp biBHUFUgcmVjb3ZlcnkgZmFpbGluZyB0byBicmluZyBHUFUgYmFjaywgdGhpcwo+ICsgKiBpbnRl cmZhY2UgcHJvdmlkZXMgb25lIGRpcmVjdCB3YXkgdG8gdXNlciB0byByZWJvb3Qgc3lzdGVtIGF1 dG9tYXRpY2FsbHkKPiArICogaW4gc3VjaCBjYXNlIHdpdGhpbiBFUlJFVkVOVF9BVEhVQl9JTlRF UlJVUFQgZ2VuZXJhdGVkLiBOb3JtYWwgR1BVIHJlY292ZXJ5Cj4gKyAqIHJvdXRpbmUgd2lsbCBu ZXZlciBiZSBjYWxsZWQuCj4gKyAqCj4gKyAqIEVuYWJsZSBhdXRvX3JlYm9vdDoKPiArICoKPiAr ICoJZWNobyAxID4gL3N5cy9rZXJuZWwvZGVidWcvZHJpL3gvcmFzL2F1dG9fcmVib290Cj4gKyAq Cj4gKyAqIFJldmVydCBhdXRvX3JlYm9vdDoKPiArICoKPiArICogCWVjaG8gMCA+IC9zeXMva2Vy bmVsL2RlYnVnL2RyaS94L3Jhcy9hdXRvX3JlYm9vdAo+ICsgKgo+ICsgKi8KPiArc3RhdGljIHNz aXplX3QgYW1kZ3B1X3Jhc19kZWJ1Z2ZzX3JlYm9vdF93cml0ZShzdHJ1Y3QgZmlsZSAqZiwKPiAr CWNvbnN0IGNoYXIgX191c2VyICpidWYsIHNpemVfdCBzaXplLCBsb2ZmX3QgKnBvcykKPiArewo+ ICsJc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYgPQo+ICsJCShzdHJ1Y3QgYW1kZ3B1X2Rldmlj ZSAqKWZpbGVfaW5vZGUoZiktPmlfcHJpdmF0ZTsKPiArCWNoYXIgdG1wWzhdID0gezB9Owo+ICsJ aW50IHZhbHVlID0gLTE7Cj4gKwo+ICsJaWYgKHNpemUgIT0gc2ltcGxlX3dyaXRlX3RvX2J1ZmZl cih0bXAsIHNpemVvZih0bXApLCBwb3MsIGJ1Ziwgc2l6ZSkpCj4gKwkJcmV0dXJuIC1FSU5WQUw7 Cj4gKwo+ICsJaWYgKGtzdHJ0b2ludCh0bXAsIDEwLCAmdmFsdWUpKQo+ICsJCXJldHVybiAtRUlO VkFMOwo+ICsKPiArCWlmICh2YWx1ZSA9PSAxKQo+ICsJCWFtZGdwdV9yYXNfZ2V0X2NvbnRleHQo YWRldiktPnJlYm9vdCA9IHRydWU7Cj4gKwllbHNlIGlmICh2YWx1ZSA9PSAwKQo+ICsJCWFtZGdw dV9yYXNfZ2V0X2NvbnRleHQoYWRldiktPnJlYm9vdCA9IGZhbHNlOwo+ICsKPiArCXJldHVybiBz aXplOwo+ICt9Cj4gKwo+ICAgc3RhdGljIGNvbnN0IHN0cnVjdCBmaWxlX29wZXJhdGlvbnMgYW1k Z3B1X3Jhc19kZWJ1Z2ZzX2N0cmxfb3BzID0gewo+ICAgCS5vd25lciA9IFRISVNfTU9EVUxFLAo+ ICAgCS5yZWFkID0gTlVMTCwKPiBAQCAtMzYwLDYgKzM5NCwxMyBAQCBzdGF0aWMgY29uc3Qgc3Ry dWN0IGZpbGVfb3BlcmF0aW9ucyBhbWRncHVfcmFzX2RlYnVnZnNfZWVwcm9tX29wcyA9IHsKPiAg IAkubGxzZWVrID0gZGVmYXVsdF9sbHNlZWsKPiAgIH07Cj4gICAKPiArc3RhdGljIGNvbnN0IHN0 cnVjdCBmaWxlX29wZXJhdGlvbnMgYW1kZ3B1X3Jhc19kZWJ1Z2ZzX3JlYm9vdF9vcHMgPSB7Cj4g Kwkub3duZXIgPSBUSElTX01PRFVMRSwKPiArCS5yZWFkID0gTlVMTCwKPiArCS53cml0ZSA9IGFt ZGdwdV9yYXNfZGVidWdmc19yZWJvb3Rfd3JpdGUsCj4gKwkubGxzZWVrID0gZGVmYXVsdF9sbHNl ZWsKPiArfTsKPiArCj4gICAvKioKPiAgICAqIERPQzogQU1ER1BVIFJBUyBzeXNmcyBFcnJvciBD b3VudCBJbnRlcmZhY2UKPiAgICAqCj4gQEAgLTEwMzcsNiArMTA3OCw4IEBAIHN0YXRpYyB2b2lk IGFtZGdwdV9yYXNfZGVidWdmc19jcmVhdGVfY3RybF9ub2RlKHN0cnVjdCBhbWRncHVfZGV2aWNl ICphZGV2KQo+ICAgCQkJCWFkZXYsICZhbWRncHVfcmFzX2RlYnVnZnNfY3RybF9vcHMpOwo+ICAg CWRlYnVnZnNfY3JlYXRlX2ZpbGUoInJhc19lZXByb21fcmVzZXQiLCBTX0lXVUdPIHwgU19JUlVH TywgY29uLT5kaXIsCj4gICAJCQkJYWRldiwgJmFtZGdwdV9yYXNfZGVidWdmc19lZXByb21fb3Bz KTsKPiArCWRlYnVnZnNfY3JlYXRlX2ZpbGUoImF1dG9fcmVib290IiwgU19JV1VHTyB8IFNfSVJV R08sIGNvbi0+ZGlyLAo+ICsJCQkJYWRldiwgJmFtZGdwdV9yYXNfZGVidWdmc19yZWJvb3Rfb3Bz KTsKPiAgIH0KPiAgIAo+ICAgdm9pZCBhbWRncHVfcmFzX2RlYnVnZnNfY3JlYXRlKHN0cnVjdCBh bWRncHVfZGV2aWNlICphZGV2LAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQt Z2Z4