Re: [PATCH v2] xen/sched: Fix the sorted insertion in sched_domain_insert_unit()

[Juergen Gross <jgross@suse.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 684 bytes --]

On 27.10.26 00:39, Stefano Stabellini wrote:
> The loop links the new unit in front of the unit whose successor has a
> higher unit_id, rather than after it: inserting 1 into {0, 2} gives
> {1, 0, 2}. Stop at the first unit with a higher unit_id instead.
> 
> This goes unnoticed as long as units are inserted in unit_id order, as
> guest vCPUs typically are.
> 
> Also rename prev_unit to next_unit: the new unit is linked in front of
> *next_unit, not after it.
> 
> Fixes: 141db7fd4d2d ("xen/sched: build a linked list of struct sched_unit")
> Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3743 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]