All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Matthew Auld <matthew.auld@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: Use the BIT when checking the flags, not the index
Date: Wed, 15 Jan 2020 12:29:08 +0000	[thread overview]
Message-ID: <d1bb8db0-0f1f-fdc9-60fe-e55880dde400@linux.intel.com> (raw)
In-Reply-To: <20200115122509.2673075-1-chris@chris-wilson.co.uk>


On 15/01/2020 12:25, Chris Wilson wrote:
> In converting over to using set_bit()/test_bit(), when manually
> inspecting the rq->flags, we need to use BIT().
> 
> Fixes: e1c31fb5dde3 ("drm/i915: Merge i915_request.flags with i915_request.fence.flags")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Matthew Auld <matthew.auld@intel.com>
> ---
>   drivers/gpu/drm/i915/gt/intel_lrc.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c
> index 9e430590fb3a..a8fe2f16c910 100644
> --- a/drivers/gpu/drm/i915/gt/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c
> @@ -1535,7 +1535,8 @@ static bool can_merge_rq(const struct i915_request *prev,
>   		return true;
>   
>   	if (unlikely((prev->fence.flags ^ next->fence.flags) &
> -		     (I915_FENCE_FLAG_NOPREEMPT | I915_FENCE_FLAG_SENTINEL)))
> +		     (BIT(I915_FENCE_FLAG_NOPREEMPT) |
> +		      BIT(I915_FENCE_FLAG_SENTINEL))))
>   		return false;
>   
>   	if (!can_merge_ctx(prev->context, next->context))
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2020-01-15 12:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-15 12:25 [Intel-gfx] [PATCH] drm/i915/gt: Use the BIT when checking the flags, not the index Chris Wilson
2020-01-15 12:29 ` Tvrtko Ursulin [this message]
2020-01-15 14:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-01-15 14:53 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork
2020-01-17 23:40 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d1bb8db0-0f1f-fdc9-60fe-e55880dde400@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=matthew.auld@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.