From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0A1523A99F for ; Fri, 15 May 2026 14:32:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778855581; cv=none; b=pmZ5Sn54CmMaefXYGFl0b5FcMkJWXEL+lsmMKWbd9AIbLoM64tlQnvxxPG79X7mA9v54p/dS5xH9hyRbezM5j5tcg/WAHsaR3d1cgxiexWkxQYcEvU/1uCIosFAhMGmKTv/ICvyXGdHQEWyc4DMiWj9LUEqtF9opxJ5BMCphrZo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778855581; c=relaxed/simple; bh=kAEgfZSK5C29OjY8cBVCt366ZMFzV6dTwzkM+WmVv8s=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=j1lzb1aQe7x6VekK01JCIMXJmOsEis7MvV5gmTtjqUXsdK6J9anpnMNpLeXOJJBb+5OYfoa0mRNP0TLie07rPk06X7t7Y1++zFQZTpGUuymn8MRaJXVTQ8VufOXb5cgu8r9ITbspGP1cGL7AOLLJaY44Exf2eACyqPX3juZwtME= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=TUbzrFl5; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="TUbzrFl5" Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id DC54B26F36; Fri, 15 May 2026 16:32:56 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 6IHsimBjTI3C; Fri, 15 May 2026 16:32:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1778855576; bh=kAEgfZSK5C29OjY8cBVCt366ZMFzV6dTwzkM+WmVv8s=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=TUbzrFl5dBrZrJDT2cxvb1nPgTGCmS9FV5b/LWTV+R9Omd13XltdTAGXjrL52dbTA qh4Y/Ys23J/QZ401rRBVAZF4CPAVPBf42fSbnSn+jv6nVI8Qg2Nt1awxUOEjN87328 BsYX0ce27y2welkCLRr+qBv+JSiebNh8gqWdwO7fTS3QY1Aeh8QdhyYbv5iF+jP2Kq XS3hoHD6Wy28mJzw2Oz0G0jT4fqfqntKaWaVSWdxfIvNW0oT/EZbv6JU6Oh4rCKOTP zNb4WX9l+n3eCJFVzWypMnYQilqwVuhdCHiOLkZJr9tFdpElLsW90PeQRq5sHrbsDQ 3dfhOYr2A53lA== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Fri, 15 May 2026 14:32:51 +0000 From: Rustam Adilov To: markus.stockhausen@gmx.de Cc: 'Chris Packham' , 'Daniel Lezcano' , 'Thomas Gleixner' , linux-kernel@vger.kernel.org Subject: Re: AW: [PATCH] clocksource: rtl-otto: Change driver to use __raw reads and writes In-Reply-To: <021301dce3e3$4a530b70$def92250$@gmx.de> References: <20260511131520.98420-1-adilov@disroot.org> <4536f1b3a66411a36ca0d01538003fd4@disroot.org> <021301dce3e3$4a530b70$def92250$@gmx.de> Message-ID: X-Sender: adilov@disroot.org Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Hi Markus, On 2026-05-14 20:50, markus.stockhausen@gmx.de wrote: >> Von: Chris Packham >> Gesendet: Mittwoch, 13. Mai 2026 23:05 >> Betreff: Re: [PATCH] clocksource: rtl-otto: Change driver to use __raw reads and writes >> ... >>> Fix this by replacing all instances of ioread32 and iowrite32 with >>> __raw_readl and __raw_writel variants. Since they essentially do >>> the same register access, this shouldn't affect anything on other >>> machines. >>> >>> Signed-off-by: Rustam Adilov > > IIRC the current functions use memory barriers while the > new ones do not. Timers are critical and cost me a lot > of time in the past [1]. We nearly lost support for several > devices last year. So I like to have at least some stability > confirmation from downstream. As far as i can see, if you untangle the the BUILDIO_MEM(l, u32) in [1] you should see they do have barriers as denoted by barrier argument being set. So that means, in MIPS, both readl/writel are the same as their __raw variants. And both ioread32/iowrite32 are using readl/writel under the hood so... [1] - https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/mips/include/asm/io.h > Markus > > [1] https://lkml.org/lkml/2025/8/4/240 Best, Rustam