From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A7C8C433DF for ; Fri, 26 Jun 2020 12:23:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 38121207D8 for ; Fri, 26 Jun 2020 12:23:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FURfiTPQ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="mNpFLEY3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38121207D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4WIVNapBWxxswre4Jp2baaiZwU8hvm5wZIRc4duSliE=; b=FURfiTPQ4wvO3JxBl4koa0tgG UwifvZJDkbb1cMrslsf20witRdS+n1Vw9Q5lR6r7Z7FzheHmBrpydVBC/qLQuY5z7URBo0R7Egw5n fgLbiatwaTDji5D9au4GgSrW2Pi9kZcWC/yh14hg+GjWMhtdxYeHDq/uQ0SuG8mOyAL7hh+4gid74 jIrfVA+1s0klKzl8s6VJNElAvJfAG9hP7cXHq6kFoPHUbkEjcwyXPWc1Cnf3feeo62ns5+LdztA8d ulWzxehK7i7aDfr80HKzmeyO/9paDk8xb1dQgd3UN/OP47leBFjomM6VHEqzYB7R9J3mTi5XEiIog sEMbrNS9A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jonLs-0002oU-M4; Fri, 26 Jun 2020 12:21:04 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jon0C-0000kk-Gq for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 11:58:44 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 57EF22078D; Fri, 26 Jun 2020 11:58:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593172718; bh=KrlcYvveojBvps7yT4BO9KVDnyR+GciP2qARbjklwKY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mNpFLEY3w6NsKmmPOcBDruKtxGXFDfFlUKmD7vX2RiohVTGrHma+DBwVOe+3SGnkX kpJ6XoaJxdkxExT2ihoWt9fRmafyliiwDfNGBNWARic6KixqukgBZeCADkz9q0x3Bk y+aNeEc/EXvaUATbH7MkKyDESp80ZcHszLrE2BsA= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jon08-006cq9-RX; Fri, 26 Jun 2020 12:58:36 +0100 MIME-Version: 1.0 Date: Fri, 26 Jun 2020 12:58:36 +0100 From: Marc Zyngier To: Valentin Schneider Subject: Re: [PATCH v2 15/17] arm64: Remove custom IRQ stat accounting In-Reply-To: References: <20200624195811.435857-1-maz@kernel.org> <20200624195811.435857-16-maz@kernel.org> User-Agent: Roundcube Webmail/1.4.5 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: valentin.schneider@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, will@kernel.org, catalin.marinas@arm.com, linux@arm.linux.org.uk, tglx@linutronix.de, jason@lakedaemon.net, sumit.garg@linaro.org, f.fainelli@gmail.com, gregory.clement@bootlin.com, andrew@lunn.ch, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sumit Garg , Florian Fainelli , Russell King , Jason Cooper , kernel-team@android.com, Andrew Lunn , Catalin Marinas , Gregory Clement , linux-kernel@vger.kernel.org, Thomas Gleixner , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-06-25 19:26, Valentin Schneider wrote: > On 24/06/20 20:58, Marc Zyngier wrote: >> @@ -801,26 +802,15 @@ void show_ipi_list(struct seq_file *p, int prec) >> unsigned int cpu, i; >> >> for (i = 0; i < NR_IPI; i++) { >> + unsigned int irq = irq_desc_get_irq(ipi_desc[i]); >> seq_printf(p, "%*s%u:%s", prec - 1, "IPI", i, >> prec >= 4 ? " " : ""); >> for_each_online_cpu(cpu) >> - seq_printf(p, "%10u ", >> - __get_irq_stat(cpu, ipi_irqs[i])); >> + seq_printf(p, "%10u ", kstat_irqs_cpu(irq, cpu)); >> seq_printf(p, " %s\n", ipi_types[i]); > > How attached are we to that custom IPI printout? AIUI we *could* give > them > a "prettier" name in request_percpu_irq() and let the standard procfs > printout take the wheel. I wish. Unfortunately, /proc/interrupts is likely to be considered ABI, and I'm really worried to change this (see what happened last time we tried to update /proc/cpuinfo to be less braindead...). M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30D7EC433E0 for ; Fri, 26 Jun 2020 11:58:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B01220791 for ; Fri, 26 Jun 2020 11:58:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593172721; bh=KrlcYvveojBvps7yT4BO9KVDnyR+GciP2qARbjklwKY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=uToCdoVVMetiQlG31Z46FaoIo1xscenTq0s3+uX1kNk2I9HXu3CAcq8BTeiVVi4Ic o3w8imcnS1rcXlSWZIUFlMsPoEnKJ79K+fe47AonigwA8bzbRMVNTJcwV7IPASq7O6 Z/+/e9OXJ/from8y6EKFbLxfj9IZo+AHOUFXYz+E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727987AbgFZL6j (ORCPT ); Fri, 26 Jun 2020 07:58:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:60906 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726256AbgFZL6i (ORCPT ); Fri, 26 Jun 2020 07:58:38 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 57EF22078D; Fri, 26 Jun 2020 11:58:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593172718; bh=KrlcYvveojBvps7yT4BO9KVDnyR+GciP2qARbjklwKY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mNpFLEY3w6NsKmmPOcBDruKtxGXFDfFlUKmD7vX2RiohVTGrHma+DBwVOe+3SGnkX kpJ6XoaJxdkxExT2ihoWt9fRmafyliiwDfNGBNWARic6KixqukgBZeCADkz9q0x3Bk y+aNeEc/EXvaUATbH7MkKyDESp80ZcHszLrE2BsA= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jon08-006cq9-RX; Fri, 26 Jun 2020 12:58:36 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 26 Jun 2020 12:58:36 +0100 From: Marc Zyngier To: Valentin Schneider Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Will Deacon , Catalin Marinas , Russell King , Thomas Gleixner , Jason Cooper , Sumit Garg , Florian Fainelli , Gregory Clement , Andrew Lunn , kernel-team@android.com Subject: Re: [PATCH v2 15/17] arm64: Remove custom IRQ stat accounting In-Reply-To: References: <20200624195811.435857-1-maz@kernel.org> <20200624195811.435857-16-maz@kernel.org> User-Agent: Roundcube Webmail/1.4.5 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: valentin.schneider@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, will@kernel.org, catalin.marinas@arm.com, linux@arm.linux.org.uk, tglx@linutronix.de, jason@lakedaemon.net, sumit.garg@linaro.org, f.fainelli@gmail.com, gregory.clement@bootlin.com, andrew@lunn.ch, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-06-25 19:26, Valentin Schneider wrote: > On 24/06/20 20:58, Marc Zyngier wrote: >> @@ -801,26 +802,15 @@ void show_ipi_list(struct seq_file *p, int prec) >> unsigned int cpu, i; >> >> for (i = 0; i < NR_IPI; i++) { >> + unsigned int irq = irq_desc_get_irq(ipi_desc[i]); >> seq_printf(p, "%*s%u:%s", prec - 1, "IPI", i, >> prec >= 4 ? " " : ""); >> for_each_online_cpu(cpu) >> - seq_printf(p, "%10u ", >> - __get_irq_stat(cpu, ipi_irqs[i])); >> + seq_printf(p, "%10u ", kstat_irqs_cpu(irq, cpu)); >> seq_printf(p, " %s\n", ipi_types[i]); > > How attached are we to that custom IPI printout? AIUI we *could* give > them > a "prettier" name in request_percpu_irq() and let the standard procfs > printout take the wheel. I wish. Unfortunately, /proc/interrupts is likely to be considered ABI, and I'm really worried to change this (see what happened last time we tried to update /proc/cpuinfo to be less braindead...). M. -- Jazz is not dead. It just smells funny...