From: Derrick Stolee <derrickstolee@github.com>
To: Taylor Blau <me@ttaylorr.com>, Junio C Hamano <junio@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: tb/commit-graph-genv2-upgrade-fix
Date: Tue, 26 Jul 2022 07:29:22 -0400 [thread overview]
Message-ID: <d1d460f6-e70f-b17f-73a5-e56d604dd9d5@github.com> (raw)
In-Reply-To: <Yt8RcDeSht56gU5v@nand.local>
On 7/25/22 5:56 PM, Taylor Blau wrote:
> On Fri, Jul 22, 2022 at 06:01:10PM -0700, Junio C Hamano wrote:
>> * tb/commit-graph-genv2-upgrade-fix (2022-07-15) 3 commits
>> - commit-graph: fix corrupt upgrade from generation v1 to v2
>> - commit-graph: introduce `repo_find_commit_pos_in_graph()`
>> - t5318: demonstrate commit-graph generation v2 corruption
>>
>> There was a bug in the codepath to upgrade generation information
>> in commit-graph from v1 to v2 format, which has been corrected.
>>
>> Will merge to 'next'?
>> source: <cover.1657667404.git.me@ttaylorr.com>
>
> Yeah, I think that this one is ready to go. It's the minimal fix I would
> consider acceptable for squashing this bug, but it should do what we
> need.
>
> Stolee gave it a positive review, and I doubt he has any objections.
I agree that this is ready for 'next'.
Thanks,
-Stolee
next prev parent reply other threads:[~2022-07-26 11:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-23 1:01 What's cooking in git.git (Jul 2022, #07; Fri, 22) Junio C Hamano
2022-07-23 2:28 ` en/merge-restore-to-pristine (Was: Re: What's cooking in git.git (Jul 2022, #07; Fri, 22)) Elijah Newren
2022-07-23 13:48 ` mt/doc-config " Matheus Tavares
2022-07-25 21:56 ` tb/commit-graph-genv2-upgrade-fix Taylor Blau
2022-07-26 11:29 ` Derrick Stolee [this message]
2022-07-26 22:05 ` ds/midx-with-less-memory Jeff King
2022-07-27 11:29 ` ds/midx-with-less-memory Derrick Stolee
2022-07-27 15:10 ` ds/midx-with-less-memory Junio C Hamano
2022-07-27 19:12 ` ds/midx-with-less-memory Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1d460f6-e70f-b17f-73a5-e56d604dd9d5@github.com \
--to=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=junio@pobox.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.