From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com [209.85.219.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 620F5110D for ; Mon, 13 Jun 2022 07:22:28 +0000 (UTC) Received: by mail-qv1-f48.google.com with SMTP id j2so3794754qvp.9 for ; Mon, 13 Jun 2022 00:22:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :content-transfer-encoding:user-agent:mime-version; bh=t8GkcF/AscIjmYX1Ft+2LOWOMCGcc3ou443uyI/gHgM=; b=lgYBehJwnc7p76Sp7QYODbs+eJsn9x/aAZca0AhE5KDXVc2emmsRxjtpfkhG0ym3jF +YmyjmCo8KwGowRdjt9uIvuUoTlmDmEhKvtAV4CSG4hTEjA91HAM5qlNsrTQS1SRX91R LFvp/Mktzkcb1CVjqHCgBxNr9WvYpOAxf+96MGlGzCOnNiSwu1/E0KM1WiGropKJpSPJ I1FGxJQBE5G5ow1BWz+8k8tlsSYxFVWF+sox/Wak2AzR/lG0tAdRt9KAZDThpdGND1Zh 2o8Dtj8SUUB+OwaZDXw05iMGYlfFzStAu7j7cL8cCzdwPXdi8qQXd8eBti7wRpJI/O1K B+xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=t8GkcF/AscIjmYX1Ft+2LOWOMCGcc3ou443uyI/gHgM=; b=DZvx9UicjBVciETeM949UynZAIS2E0Mwlwi38gHgCxBb+zqofzigO4lgoQxk4fR4LM ymVu+ThBRMQJ+6N9pfrSj82xke3iOMIpr3UOjM1ZB8/+YngOt6/TMSRkwqRcbJQE7TXS Wq0vZxhXIC6/9QPLXLHy73GQqip0l19S22EX6MrQ2x1co7GPosbuyK4If9b9dlDWgJLx r+e7lU3IofqrU19wQeA63oM3N0UfAwbDK+OEZto0gL2pGzG4PFuyCUQh30avx/w9r7iR DpIEHu2hwSIvIxqjnLlBQVzZOaNcdWPaPy1a11PZJHaoMg4lr2IRzj4ePtntwuAV29ua 3lGw== X-Gm-Message-State: AOAM531Mha3TV+PEzFj4hYa03UPVfutOp188S5NdF8X/a/KdJesyUY9R dPMXPzxKAFZmkWV/M1v0/44= X-Google-Smtp-Source: ABdhPJzJwQGuL0izMZeZrCmNmnxm8u/ohN3iHcmN+Ftx1/l43JyjW+szv6Fscr1wrYk++4pmje2xJg== X-Received: by 2002:ad4:5b81:0:b0:465:ded8:780 with SMTP id 1-20020ad45b81000000b00465ded80780mr45550533qvp.119.1655104947222; Mon, 13 Jun 2022 00:22:27 -0700 (PDT) Received: from p200300f6ef062c0090c03b551078f99d.dip0.t-ipconnect.de (p200300f6ef062c0090c03b551078f99d.dip0.t-ipconnect.de. [2003:f6:ef06:2c00:90c0:3b55:1078:f99d]) by smtp.gmail.com with ESMTPSA id y6-20020a05622a004600b002f9399ccefasm4637163qtw.34.2022.06.13.00.22.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jun 2022 00:22:26 -0700 (PDT) Message-ID: Subject: Re: [PATCH 34/34] iio: inkern: fix coding style warnings From: Nuno =?ISO-8859-1?Q?S=E1?= To: Geert Uytterhoeven Cc: Joe Simmons-Talbott , Nuno =?ISO-8859-1?Q?S=E1?= , NXP Linux Team , Linux-Renesas , "open list:BROADCOM NVRAM DRIVER" , Linux ARM , chrome-platform@lists.linux.dev, Lad Prabhakar , linux-mediatek@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-msm , linux-iio@vger.kernel.org, openbmc@lists.ozlabs.org, Cai Huoqing , Benjamin Fair , Jishnu Prakash , Linus Walleij , Lars-Peter Clausen , Alexandre Torgue , Amit Kucheria , Andy Gross , Michael Hennerich , Haibo Chen , Benson Leung , "Rafael J. Wysocki" , Alexandre Belloni , Christophe Branchereau , Patrick Venture , Arnd Bergmann , Nancy Yuen , Sascha Hauer , Daniel Lezcano , Gwendal Grignou , Saravanan Sekar , Tali Perry , Maxime Coquelin , Paul Cercueil , Thara Gopinath , Avi Fishman , Lorenzo Bianconi , Claudiu Beznea , Pengutronix Kernel Team , Andy Shevchenko , Fabrice Gasnier , Matthias Brugger , Tomer Maimon , Bjorn Andersson , Nicolas Ferre , Jonathan Cameron , Zhang Rui , Shawn Guo , Guenter Roeck , Fabio Estevam , Olivier Moysan , Eugen Hristev , Miquel Raynal Date: Mon, 13 Jun 2022 09:23:16 +0200 In-Reply-To: References: <20220610084545.547700-1-nuno.sa@analog.com> <20220610084545.547700-35-nuno.sa@analog.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.2 Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Sun, 2022-06-12 at 19:39 +0200, Geert Uytterhoeven wrote: > Hi Nuno, >=20 > On Fri, Jun 10, 2022 at 9:52 PM Nuno S=C3=A1 > wrote: > > On Fri, 2022-06-10 at 11:53 -0400, Joe Simmons-Talbott wrote: > > > On Fri, Jun 10, 2022 at 10:45:45AM +0200, Nuno S=C3=A1 wrote: > > > > Just cosmetics. No functional change intended... > > > >=20 > > > > Signed-off-by: Nuno S=C3=A1 >=20 > > > > --- a/drivers/iio/inkern.c > > > > +++ b/drivers/iio/inkern.c > > > > @@ -45,13 +45,13 @@ int iio_map_array_register(struct iio_dev > > > > *indio_dev, struct iio_map *maps) > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 int i =3D 0, ret =3D 0; > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct iio_map_internal = *mapi; > > > >=20 > > > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (maps =3D=3D NULL) > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (!maps) > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 return 0; > > > >=20 > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 mutex_lock(&iio_map_list= _lock); > > > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 while (maps[i].consumer_dev_n= ame !=3D NULL) { > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 while (!maps[i].consumer_dev_= name) { > > >=20 > > > Shouldn't this be?: > > > while (maps[i].consumer_dev_name) { > >=20 > > Ups... Nice catch! I was probably in bot mode already. >=20 > When making a change with no functional change intended, it is always > a good idea to compare the generated assembler before/after.=C2=A0 I.e. >=20 > =C2=A0=C2=A0=C2=A0 make drivers/iio/inkern.s > =C2=A0=C2=A0=C2=A0 mv drivers/iio/inkern.s drivers/iio/inkern.s.orig > =C2=A0=C2=A0=C2=A0 [make your change] > =C2=A0=C2=A0=C2=A0 make drivers/iio/inkern.s > =C2=A0=C2=A0=C2=A0 diff -u drivers/iio/inkern.s{.orig,} >=20 Ah thx... That's indeed a good idea! - Nuno S=C3=A1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4849CC433EF for ; Mon, 13 Jun 2022 07:22:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U5IrmGgH6Dc7pYZC3mPVTJDvgOR7o1Bb9ZJ123/BJqY=; b=qpwJv0j+1UjFui Q5HPZ+bi9R3Icg5Itg4eWc1SY7xydYZ7hB1MZv5qNB7/EPvs4SGfJ4sSZvvnHGiV5FqOYGlZSCvpS GqoaoizuFdveyfBFHZty72hvzU6uVdidFCt1YVaIXBnWdNoP6oPg39TYsQx3Kzs7KurDw6lwFnpVT vWs91ByCKojwiZQSW9g2AUP0Ao1xg88KRNxSxz0/WBPqj8P39NwHd+76BGIcSFoi9hrLPZwhabDnN N86ar6d42OrksUwVuqSAK0ys9RbIhL8K2ZH5CVf39zkIgbBSyjXgy+GEFeXLQw/HmxWu+kXo71DlR 8Zbvw7PKEOZlyStYdutg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o0ePB-001wyj-VJ; Mon, 13 Jun 2022 07:22:34 +0000 Received: from mail-qv1-xf34.google.com ([2607:f8b0:4864:20::f34]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o0eP8-001wxB-11; Mon, 13 Jun 2022 07:22:31 +0000 Received: by mail-qv1-xf34.google.com with SMTP id o43so3808523qvo.4; Mon, 13 Jun 2022 00:22:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :content-transfer-encoding:user-agent:mime-version; bh=t8GkcF/AscIjmYX1Ft+2LOWOMCGcc3ou443uyI/gHgM=; b=lgYBehJwnc7p76Sp7QYODbs+eJsn9x/aAZca0AhE5KDXVc2emmsRxjtpfkhG0ym3jF +YmyjmCo8KwGowRdjt9uIvuUoTlmDmEhKvtAV4CSG4hTEjA91HAM5qlNsrTQS1SRX91R LFvp/Mktzkcb1CVjqHCgBxNr9WvYpOAxf+96MGlGzCOnNiSwu1/E0KM1WiGropKJpSPJ I1FGxJQBE5G5ow1BWz+8k8tlsSYxFVWF+sox/Wak2AzR/lG0tAdRt9KAZDThpdGND1Zh 2o8Dtj8SUUB+OwaZDXw05iMGYlfFzStAu7j7cL8cCzdwPXdi8qQXd8eBti7wRpJI/O1K B+xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=t8GkcF/AscIjmYX1Ft+2LOWOMCGcc3ou443uyI/gHgM=; b=vv92TY0nnGAIFFeqXeJNqXpKZQSW1hRkfeWeUObIMAg3XEzdyxUoiHgRTqoyRAwxrD F0szZpf/dwdjdCXwsMqxo244CnUchnR+HN4MmhMCUKaJLdaMEF9mEsKJZnzpLW9uWgQV aTNqhoCUxMdxinGoWktK/fL14fWASL3mRvqRvSKpIqpowZB+rB6nPoufbToHaS3BeKrC 3OB0JY6oOPDEvY9Q/hsUf92pClN0iwtgRSQX9vnce1A3KMgtePo2j7CTmoWOdo7gJnIi yiNXIwTUqstVwhVEja7Dw7rFZuwk/24dKdpmxGrcfS+jt+oKFzp5mEkw1+OJlOyerOm3 5ppA== X-Gm-Message-State: AOAM5301SXHqGAzRbIkf7dToAFpMDv7i5Y72LqGbFjHO3TvOywkWIGWV XPSz9HEhz3FPpS73/p/pCHw= X-Google-Smtp-Source: ABdhPJzJwQGuL0izMZeZrCmNmnxm8u/ohN3iHcmN+Ftx1/l43JyjW+szv6Fscr1wrYk++4pmje2xJg== X-Received: by 2002:ad4:5b81:0:b0:465:ded8:780 with SMTP id 1-20020ad45b81000000b00465ded80780mr45550533qvp.119.1655104947222; Mon, 13 Jun 2022 00:22:27 -0700 (PDT) Received: from p200300f6ef062c0090c03b551078f99d.dip0.t-ipconnect.de (p200300f6ef062c0090c03b551078f99d.dip0.t-ipconnect.de. [2003:f6:ef06:2c00:90c0:3b55:1078:f99d]) by smtp.gmail.com with ESMTPSA id y6-20020a05622a004600b002f9399ccefasm4637163qtw.34.2022.06.13.00.22.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jun 2022 00:22:26 -0700 (PDT) Message-ID: Subject: Re: [PATCH 34/34] iio: inkern: fix coding style warnings From: Nuno =?ISO-8859-1?Q?S=E1?= To: Geert Uytterhoeven Cc: Joe Simmons-Talbott , Nuno =?ISO-8859-1?Q?S=E1?= , NXP Linux Team , Linux-Renesas , "open list:BROADCOM NVRAM DRIVER" , Linux ARM , chrome-platform@lists.linux.dev, Lad Prabhakar , linux-mediatek@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-msm , linux-iio@vger.kernel.org, openbmc@lists.ozlabs.org, Cai Huoqing , Benjamin Fair , Jishnu Prakash , Linus Walleij , Lars-Peter Clausen , Alexandre Torgue , Amit Kucheria , Andy Gross , Michael Hennerich , Haibo Chen , Benson Leung , "Rafael J. Wysocki" , Alexandre Belloni , Christophe Branchereau , Patrick Venture , Arnd Bergmann , Nancy Yuen , Sascha Hauer , Daniel Lezcano , Gwendal Grignou , Saravanan Sekar , Tali Perry , Maxime Coquelin , Paul Cercueil , Thara Gopinath , Avi Fishman , Lorenzo Bianconi , Claudiu Beznea , Pengutronix Kernel Team , Andy Shevchenko , Fabrice Gasnier , Matthias Brugger , Tomer Maimon , Bjorn Andersson , Nicolas Ferre , Jonathan Cameron , Zhang Rui , Shawn Guo , Guenter Roeck , Fabio Estevam , Olivier Moysan , Eugen Hristev , Miquel Raynal Date: Mon, 13 Jun 2022 09:23:16 +0200 In-Reply-To: References: <20220610084545.547700-1-nuno.sa@analog.com> <20220610084545.547700-35-nuno.sa@analog.com> User-Agent: Evolution 3.44.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220613_002230_113185_E05DEEC3 X-CRM114-Status: GOOD ( 16.16 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org T24gU3VuLCAyMDIyLTA2LTEyIGF0IDE5OjM5ICswMjAwLCBHZWVydCBVeXR0ZXJob2V2ZW4gd3Jv dGU6Cj4gSGkgTnVubywKPiAKPiBPbiBGcmksIEp1biAxMCwgMjAyMiBhdCA5OjUyIFBNIE51bm8g U8OhIDxub25hbWUubnVub0BnbWFpbC5jb20+Cj4gd3JvdGU6Cj4gPiBPbiBGcmksIDIwMjItMDYt MTAgYXQgMTE6NTMgLTA0MDAsIEpvZSBTaW1tb25zLVRhbGJvdHQgd3JvdGU6Cj4gPiA+IE9uIEZy aSwgSnVuIDEwLCAyMDIyIGF0IDEwOjQ1OjQ1QU0gKzAyMDAsIE51bm8gU8OhIHdyb3RlOgo+ID4g PiA+IEp1c3QgY29zbWV0aWNzLiBObyBmdW5jdGlvbmFsIGNoYW5nZSBpbnRlbmRlZC4uLgo+ID4g PiA+IAo+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IE51bm8gU8OhIDxudW5vLnNhQGFuYWxvZy5jb20+ Cj4gCj4gPiA+ID4gLS0tIGEvZHJpdmVycy9paW8vaW5rZXJuLmMKPiA+ID4gPiArKysgYi9kcml2 ZXJzL2lpby9pbmtlcm4uYwo+ID4gPiA+IEBAIC00NSwxMyArNDUsMTMgQEAgaW50IGlpb19tYXBf YXJyYXlfcmVnaXN0ZXIoc3RydWN0IGlpb19kZXYKPiA+ID4gPiAqaW5kaW9fZGV2LCBzdHJ1Y3Qg aWlvX21hcCAqbWFwcykKPiA+ID4gPiDCoMKgwqDCoMKgwqDCoCBpbnQgaSA9IDAsIHJldCA9IDA7 Cj4gPiA+ID4gwqDCoMKgwqDCoMKgwqAgc3RydWN0IGlpb19tYXBfaW50ZXJuYWwgKm1hcGk7Cj4g PiA+ID4gCj4gPiA+ID4gLcKgwqDCoMKgwqDCoCBpZiAobWFwcyA9PSBOVUxMKQo+ID4gPiA+ICvC oMKgwqDCoMKgwqAgaWYgKCFtYXBzKQo+ID4gPiA+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoCByZXR1cm4gMDsKPiA+ID4gPiAKPiA+ID4gPiDCoMKgwqDCoMKgwqDCoCBtdXRleF9sb2Nr KCZpaW9fbWFwX2xpc3RfbG9jayk7Cj4gPiA+ID4gLcKgwqDCoMKgwqDCoCB3aGlsZSAobWFwc1tp XS5jb25zdW1lcl9kZXZfbmFtZSAhPSBOVUxMKSB7Cj4gPiA+ID4gK8KgwqDCoMKgwqDCoCB3aGls ZSAoIW1hcHNbaV0uY29uc3VtZXJfZGV2X25hbWUpIHsKPiA+ID4gCj4gPiA+IFNob3VsZG4ndCB0 aGlzIGJlPzoKPiA+ID4gd2hpbGUgKG1hcHNbaV0uY29uc3VtZXJfZGV2X25hbWUpIHsKPiA+IAo+ ID4gVXBzLi4uIE5pY2UgY2F0Y2ghIEkgd2FzIHByb2JhYmx5IGluIGJvdCBtb2RlIGFscmVhZHku Cj4gCj4gV2hlbiBtYWtpbmcgYSBjaGFuZ2Ugd2l0aCBubyBmdW5jdGlvbmFsIGNoYW5nZSBpbnRl bmRlZCwgaXQgaXMgYWx3YXlzCj4gYSBnb29kIGlkZWEgdG8gY29tcGFyZSB0aGUgZ2VuZXJhdGVk IGFzc2VtYmxlciBiZWZvcmUvYWZ0ZXIuwqAgSS5lLgo+IAo+IMKgwqDCoCBtYWtlIGRyaXZlcnMv aWlvL2lua2Vybi5zCj4gwqDCoMKgIG12IGRyaXZlcnMvaWlvL2lua2Vybi5zIGRyaXZlcnMvaWlv L2lua2Vybi5zLm9yaWcKPiDCoMKgwqAgW21ha2UgeW91ciBjaGFuZ2VdCj4gwqDCoMKgIG1ha2Ug ZHJpdmVycy9paW8vaW5rZXJuLnMKPiDCoMKgwqAgZGlmZiAtdSBkcml2ZXJzL2lpby9pbmtlcm4u c3sub3JpZyx9Cj4gCgpBaCB0aHguLi4gVGhhdCdzIGluZGVlZCBhIGdvb2QgaWRlYSEKCi0gTnVu byBTw6EKCgoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpMaW51eC1tZWRpYXRlayBtYWlsaW5nIGxpc3QKTGludXgtbWVkaWF0ZWtAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LW1lZGlhdGVrCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A84BBC433EF for ; Thu, 16 Jun 2022 02:43:10 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4LNmgd1Q0Mz3f9G for ; Thu, 16 Jun 2022 12:43:09 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=lgYBehJw; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::f32; helo=mail-qv1-xf32.google.com; envelope-from=noname.nuno@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=lgYBehJw; dkim-atps=neutral Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4LM31L5lZ6z2xX6 for ; Mon, 13 Jun 2022 17:22:30 +1000 (AEST) Received: by mail-qv1-xf32.google.com with SMTP id q104so3791138qvq.8 for ; Mon, 13 Jun 2022 00:22:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :content-transfer-encoding:user-agent:mime-version; bh=t8GkcF/AscIjmYX1Ft+2LOWOMCGcc3ou443uyI/gHgM=; b=lgYBehJwnc7p76Sp7QYODbs+eJsn9x/aAZca0AhE5KDXVc2emmsRxjtpfkhG0ym3jF +YmyjmCo8KwGowRdjt9uIvuUoTlmDmEhKvtAV4CSG4hTEjA91HAM5qlNsrTQS1SRX91R LFvp/Mktzkcb1CVjqHCgBxNr9WvYpOAxf+96MGlGzCOnNiSwu1/E0KM1WiGropKJpSPJ I1FGxJQBE5G5ow1BWz+8k8tlsSYxFVWF+sox/Wak2AzR/lG0tAdRt9KAZDThpdGND1Zh 2o8Dtj8SUUB+OwaZDXw05iMGYlfFzStAu7j7cL8cCzdwPXdi8qQXd8eBti7wRpJI/O1K B+xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=t8GkcF/AscIjmYX1Ft+2LOWOMCGcc3ou443uyI/gHgM=; b=2qGZqXvniP3YVRwcM4232rQuAyPC5Dtthq3YruJx1ztdDyYhxNoDQmC8W6DEqGXiBS /77SRPgarCNuzbOuCydmSPtjBNiW8RelNmsQUi38lGK/g3SDR8BLm7LJgQCQxW9V3ppp wtdfEezjKyLnJq4dq/F29Geut02aoh6EEk2qiCP3qJIunyadM43qv+QBgiFwpmC60vB1 YS/EcbZd8hIko4Hf1EKw0yz8bkxCFCNy1PvBpMaPxWX0N1Y0AmSYXJjpdSuI11eGQFBl tGEdZ4YRVcVtHKfoEI2IQJd/APy3fXZyxjJI4GoPBHJIy7e0COStRaMGfyxqS9KFhO/t DALA== X-Gm-Message-State: AOAM533W40cauEO5D2rXK4+rh4le3f6GPz0MIcRtZoOxsJugGNDnwpj8 R+2yBebPrlmBbDeYgs9JWw4= X-Google-Smtp-Source: ABdhPJzJwQGuL0izMZeZrCmNmnxm8u/ohN3iHcmN+Ftx1/l43JyjW+szv6Fscr1wrYk++4pmje2xJg== X-Received: by 2002:ad4:5b81:0:b0:465:ded8:780 with SMTP id 1-20020ad45b81000000b00465ded80780mr45550533qvp.119.1655104947222; Mon, 13 Jun 2022 00:22:27 -0700 (PDT) Received: from p200300f6ef062c0090c03b551078f99d.dip0.t-ipconnect.de (p200300f6ef062c0090c03b551078f99d.dip0.t-ipconnect.de. [2003:f6:ef06:2c00:90c0:3b55:1078:f99d]) by smtp.gmail.com with ESMTPSA id y6-20020a05622a004600b002f9399ccefasm4637163qtw.34.2022.06.13.00.22.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jun 2022 00:22:26 -0700 (PDT) Message-ID: Subject: Re: [PATCH 34/34] iio: inkern: fix coding style warnings From: Nuno =?ISO-8859-1?Q?S=E1?= To: Geert Uytterhoeven Date: Mon, 13 Jun 2022 09:23:16 +0200 In-Reply-To: References: <20220610084545.547700-1-nuno.sa@analog.com> <20220610084545.547700-35-nuno.sa@analog.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.2 MIME-Version: 1.0 X-Mailman-Approved-At: Thu, 16 Jun 2022 12:05:36 +1000 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Daniel Lezcano , Tomer Maimon , "Rafael J. Wysocki" , linux-iio@vger.kernel.org, Linus Walleij , Amit Kucheria , Alexandre Torgue , Nuno =?ISO-8859-1?Q?S=E1?= , Paul Cercueil , Miquel Raynal , Guenter Roeck , Fabio Estevam , linux-stm32@st-md-mailman.stormreply.com, chrome-platform@lists.linux.dev, Lars-Peter Clausen , Benjamin Fair , openbmc@lists.ozlabs.org, Jishnu Prakash , Haibo Chen , Andy Shevchenko , Andy Gross , NXP Linux Team , Olivier Moysan , Zhang Rui , Christophe Brancher eau , Bjorn Andersson , Tali Perry , Saravanan Sekar , Michael Hennerich , linux-arm-msm , Sascha Hauer , Nicolas Ferre , Lad Prabhakar , Fabrice Gasnier , linux-mediatek@lists.infradead.org, Eugen Hristev , Matthias Brugger , Gwendal Grignou , Joe Simmons-Talbott , Benson Leung , Pengutronix Kernel Team , Linux ARM , Lorenzo Bianconi , Avi Fishman , Patrick Venture , "open list:BROADCOM NVRAM DRIVER" , Thara Gopinath , Linux-Renesas , Arnd Bergmann , Maxime Coquelin , Cai Huoqing , Shawn Guo , Claudiu Beznea , Jonathan Cameron Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Sun, 2022-06-12 at 19:39 +0200, Geert Uytterhoeven wrote: > Hi Nuno, >=20 > On Fri, Jun 10, 2022 at 9:52 PM Nuno S=C3=A1 > wrote: > > On Fri, 2022-06-10 at 11:53 -0400, Joe Simmons-Talbott wrote: > > > On Fri, Jun 10, 2022 at 10:45:45AM +0200, Nuno S=C3=A1 wrote: > > > > Just cosmetics. No functional change intended... > > > >=20 > > > > Signed-off-by: Nuno S=C3=A1 >=20 > > > > --- a/drivers/iio/inkern.c > > > > +++ b/drivers/iio/inkern.c > > > > @@ -45,13 +45,13 @@ int iio_map_array_register(struct iio_dev > > > > *indio_dev, struct iio_map *maps) > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 int i =3D 0, ret =3D 0; > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct iio_map_internal = *mapi; > > > >=20 > > > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (maps =3D=3D NULL) > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (!maps) > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 return 0; > > > >=20 > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 mutex_lock(&iio_map_list= _lock); > > > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 while (maps[i].consumer_dev_n= ame !=3D NULL) { > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 while (!maps[i].consumer_dev_= name) { > > >=20 > > > Shouldn't this be?: > > > while (maps[i].consumer_dev_name) { > >=20 > > Ups... Nice catch! I was probably in bot mode already. >=20 > When making a change with no functional change intended, it is always > a good idea to compare the generated assembler before/after.=C2=A0 I.e. >=20 > =C2=A0=C2=A0=C2=A0 make drivers/iio/inkern.s > =C2=A0=C2=A0=C2=A0 mv drivers/iio/inkern.s drivers/iio/inkern.s.orig > =C2=A0=C2=A0=C2=A0 [make your change] > =C2=A0=C2=A0=C2=A0 make drivers/iio/inkern.s > =C2=A0=C2=A0=C2=A0 diff -u drivers/iio/inkern.s{.orig,} >=20 Ah thx... That's indeed a good idea! - Nuno S=C3=A1