From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C4DEEC07545 for ; Wed, 25 Oct 2023 02:03:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Hh/Y1fsRTEkMx99MleC9+ioXPSoTp3kBxzUajfNX7is=; b=kgc4OIKG4ThfMP 2+FihVKce52dUP0Izh5IfKwSY3XhC4j18kweClxjh4CZtXLftABFfoMs2SrHQaaS6/M6YdBtLdtY+ FYo/h4/Nu4auaVSQIJTp58qvprz1MALUjhH1djCyph/+Nuosba0ZMwThdVrpwb9bvD2g+X269KFAT oxxelSCXd4qyZdz/b8OA2Ot1xQbJKmtjJB/C9SH0JZfj4o4y+2nzSYm9rB1PE3QVeXJMur4jFzR8D L9BRb11dRQtJ0uzPZ+aELL5UhHmD+LEwaMpW3JE/75VvoiVCooQtvg9ZHChONmUb0dJyUid858GNp NAng8DlMtWjamNqdL7lA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qvTEQ-00B9sQ-14; Wed, 25 Oct 2023 02:02:50 +0000 Received: from out30-131.freemail.mail.aliyun.com ([115.124.30.131]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qvTEL-00B9rb-2R for linux-arm-kernel@lists.infradead.org; Wed, 25 Oct 2023 02:02:48 +0000 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R481e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046051;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0VusYSvA_1698199355; Received: from 30.97.48.63(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VusYSvA_1698199355) by smtp.aliyun-inc.com; Wed, 25 Oct 2023 10:02:36 +0800 Message-ID: Date: Wed, 25 Oct 2023 10:02:51 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] arm64: mm: drop tlb flush operation when clearing the access bit To: Barry Song <21cnbao@gmail.com> Cc: catalin.marinas@arm.com, will@kernel.org, akpm@linux-foundation.org, v-songbaohua@oppo.com, yuzhao@google.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: From: Baolin Wang In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231024_190246_057377_4D197345 X-CRM114-Status: GOOD ( 31.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAxMC8yNS8yMDIzIDc6MzEgQU0sIEJhcnJ5IFNvbmcgd3JvdGU6Cj4gT24gV2VkLCBPY3Qg MjUsIDIwMjMgYXQgNzoxNuKAr0FNIEJhcnJ5IFNvbmcgPDIxY25iYW9AZ21haWwuY29tPiB3cm90 ZToKPj4KPj4gT24gVHVlLCBPY3QgMjQsIDIwMjMgYXQgODo1N+KAr1BNIEJhb2xpbiBXYW5nCj4+ IDxiYW9saW4ud2FuZ0BsaW51eC5hbGliYWJhLmNvbT4gd3JvdGU6Cj4+Pgo+Pj4gTm93IHB0ZXBf Y2xlYXJfZmx1c2hfeW91bmcoKSBpcyBvbmx5IGNhbGxlZCBieSBmb2xpb19yZWZlcmVuY2VkKCkg dG8KPj4+IGNoZWNrIGlmIHRoZSBmb2xpbyB3YXMgcmVmZXJlbmNlZCwgYW5kIG5vdyBpdCB3aWxs IGNhbGwgYSB0bGIgZmx1c2ggb24KPj4+IEFSTTY0IGFyY2hpdGVjdHVyZS4gSG93ZXZlciB0aGUg dGxiIGZsdXNoIGNhbiBiZSBleHBlbnNpdmUgb24gQVJNNjQKPj4+IHNlcnZlcnMsIGVzcGVjaWFs bHkgZm9yIHRoZSBzeXN0ZW1zIHdpdGggYSBsYXJnZSBDUFUgbnVtYmVycy4KPj4+Cj4+PiBTaW1p bGFyIHRvIHRoZSB4ODYgYXJjaGl0ZWN0dXJlLCBiZWxvdyBjb21tZW50cyBhbHNvIGFwcGx5IGVx dWFsbHkgdG8KPj4+IEFSTTY0IGFyY2hpdGVjdHVyZS4gU28gd2UgY2FuIGRyb3AgdGhlIHRsYiBm bHVzaCBvcGVyYXRpb24gaW4KPj4+IHB0ZXBfY2xlYXJfZmx1c2hfeW91bmcoKSBvbiBBUk02NCBh cmNoaXRlY3R1cmUgdG8gaW1wcm92ZSB0aGUgcGVyZm9ybWFuY2UuCj4+PiAiCj4+PiAvKiBDbGVh cmluZyB0aGUgYWNjZXNzZWQgYml0IHdpdGhvdXQgYSBUTEIgZmx1c2gKPj4+ICAgKiBkb2Vzbid0 IGNhdXNlIGRhdGEgY29ycnVwdGlvbi4gWyBJdCBjb3VsZCBjYXVzZSBpbmNvcnJlY3QKPj4+ICAg KiBwYWdlIGFnaW5nIGFuZCB0aGUgKG1pc3Rha2VuKSByZWNsYWltIG9mIGhvdCBwYWdlcywgYnV0 IHRoZQo+Pj4gICAqIGNoYW5jZSBvZiB0aGF0IHNob3VsZCBiZSByZWxhdGl2ZWx5IGxvdy4gXQo+ Pj4gICAqCj4+PiAgICogU28gYXMgYSBwZXJmb3JtYW5jZSBvcHRpbWl6YXRpb24gZG9uJ3QgZmx1 c2ggdGhlIFRMQiB3aGVuCj4+PiAgICogY2xlYXJpbmcgdGhlIGFjY2Vzc2VkIGJpdCwgaXQgd2ls bCBldmVudHVhbGx5IGJlIGZsdXNoZWQgYnkKPj4+ICAgKiBhIGNvbnRleHQgc3dpdGNoIG9yIGEg Vk0gb3BlcmF0aW9uIGFueXdheS4gWyBJbiB0aGUgcmFyZQo+Pj4gICAqIGV2ZW50IG9mIGl0IG5v dCBnZXR0aW5nIGZsdXNoZWQgZm9yIGEgbG9uZyB0aW1lIHRoZSBkZWxheQo+Pj4gICAqIHNob3Vs ZG4ndCByZWFsbHkgbWF0dGVyIGJlY2F1c2UgdGhlcmUncyBubyByZWFsIG1lbW9yeQo+Pj4gICAq IHByZXNzdXJlIGZvciBzd2Fwb3V0IHRvIHJlYWN0IHRvLiBdCj4+PiAgICovCj4+PiAiCj4+PiBS dW5uaW5nIHRoZSB0aHBzY2FsZSB0byBzaG93IHNvbWUgb2J2aW91cyBpbXByb3ZlbWVudHMgZm9y IGNvbXBhY3Rpb24KPj4+IGxhdGVuY3kgd2l0aCB0aGlzIHBhdGNoOgo+Pj4gICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgYmFzZSAgICAgICAgICAgICAgICAgICBwYXRjaGVkCj4+PiBBbWVh biAgICAgZmF1bHQtYm90aC0xICAgICAgMTA5My4xOSAoICAgMC4wMCUpICAgICAxMDg0LjU3ICog ICAwLjc5JSoKPj4+IEFtZWFuICAgICBmYXVsdC1ib3RoLTMgICAgICAyNTY2LjIyICggICAwLjAw JSkgICAgIDIyMjguNDUgKiAgMTMuMTYlKgo+Pj4gQW1lYW4gICAgIGZhdWx0LWJvdGgtNSAgICAg IDM1OTEuMjIgKCAgIDAuMDAlKSAgICAgMzE0Ni43MyAqICAxMi4zOCUqCj4+PiBBbWVhbiAgICAg ZmF1bHQtYm90aC03ICAgICAgNDE1Ny4yNiAoICAgMC4wMCUpICAgICA0MTEzLjY3ICogICAxLjA1 JSoKPj4+IEFtZWFuICAgICBmYXVsdC1ib3RoLTEyICAgICA2MTg0Ljc5ICggICAwLjAwJSkgICAg IDUyMTguNzAgKiAgMTUuNjIlKgo+Pj4gQW1lYW4gICAgIGZhdWx0LWJvdGgtMTggICAgIDkxMDMu NzAgKCAgIDAuMDAlKSAgICAgNzczOS43MSAqICAxNC45OCUqCj4+PiBBbWVhbiAgICAgZmF1bHQt Ym90aC0yNCAgICAxMjM0MS43MyAoICAgMC4wMCUpICAgIDEwNjg0LjIzICogIDEzLjQzJSoKPj4+ IEFtZWFuICAgICBmYXVsdC1ib3RoLTMwICAgIDE1NTE5LjAwICggICAwLjAwJSkgICAgMTM2OTUu MTQgKiAgMTEuNzUlKgo+Pj4gQW1lYW4gICAgIGZhdWx0LWJvdGgtMzIgICAgMTYxODkuMTUgKCAg IDAuMDAlKSAgICAxNDM2NS43MyAqICAxMS4yNiUqCj4+PiAgICAgICAgICAgICAgICAgICAgICAg ICBiYXNlICAgICAgIHBhdGNoZWQKPj4+IER1cmF0aW9uIFVzZXIgICAgICAgICAxNjcuNzggICAg ICAxNjEuMDMKPj4+IER1cmF0aW9uIFN5c3RlbSAgICAgIDE4MzYuNjYgICAgIDE2NzMuMDEKPj4+ IER1cmF0aW9uIEVsYXBzZWQgICAgIDIwNzQuNTggICAgIDIwNTkuNzUKPj4+Cj4+PiBCYXJyeSBT b25nIHN1Ym1pdHRlZCBhIHNpbWlsYXIgcGF0Y2ggWzFdIGJlZm9yZSwgdGhhdCByZXBsYWNlcyB0 aGUKPj4+IHB0ZXBfY2xlYXJfZmx1c2hfeW91bmdfbm90aWZ5KCkgd2l0aCBwdGVwX2NsZWFyX3lv dW5nX25vdGlmeSgpIGluCj4+PiBmb2xpb19yZWZlcmVuY2VkX29uZSgpLiBIb3dldmVyLCBJJ20g bm90IHN1cmUgaWYgcmVtb3ZpbmcgdGhlIHRsYiBmbHVzaAo+Pj4gb3BlcmF0aW9uIGlzIGFwcGxp Y2FibGUgdG8gZXZlcnkgYXJjaGl0ZWN0dXJlIGluIGtlcm5lbCwgc28gZHJvcHBpbmcKPj4+IHRo ZSB0bGIgZmx1c2ggZm9yIEFSTTY0IHNlZW1zIGEgc2Vuc2libGUgY2hhbmdlLgo+Pj4KPj4+IE5v dGU6IEkgYW0gb2theSBmb3IgYm90aCBhcHByb2FjaCwgaWYgc29tZW9uZSBjYW4gaGVscCB0byBl bnN1cmUgdGhhdAo+Pj4gYWxsIGFyY2hpdGVjdHVyZXMgZG8gbm90IG5lZWQgdGhlIHRsYiBmbHVz aCB3aGVuIGNsZWFyaW5nIHRoZSBhY2Nlc3NlZAo+Pj4gYml0LCB0aGVuIEkgYWxzbyB0aGluayBC YXJyeSdzIHBhdGNoIGlzIGJldHRlciAoaG9wZSBCYXJyeSBjYW4gcmVzZW5kCj4+PiBoaXMgcGF0 Y2gpLgo+Pj4KPj4KPj4gVGhhbmtzIQo+Pgo+PiBwdGVwX2NsZWFyX2ZsdXNoX3lvdW5nKCkgd2l0 aCAiZmx1c2giIGluIGl0cyBuYW1lIGNsZWFybHkgc2F5cyBpdCBuZWVkcyBhCj4+IGZsdXNoLiBi dXQgaXQgaGFwcGVucyBpbiBhcm02NCwgYWxsIG90aGVyIGNvZGUgd2hpY2ggbmVlZHMgYSBmbHVz aCBoYXMKPj4gY2FsbGVkIG90aGVyIHZhcmlhbnRzLCBmb3IgZXhhbXBsZSBfX2ZsdXNoX3RsYl9w YWdlX25vc3luYygpOgo+Pgo+PiBzdGF0aWMgaW5saW5lIHZvaWQgYXJjaF90bGJiYXRjaF9hZGRf cGVuZGluZyhzdHJ1Y3QKPj4gYXJjaF90bGJmbHVzaF91bm1hcF9iYXRjaCAqYmF0Y2gsCj4+ICAg c3RydWN0IG1tX3N0cnVjdCAqbW0sIHVuc2lnbmVkIGxvbmcgdWFkZHIpCj4+IHsKPj4gICBfX2Zs dXNoX3RsYl9wYWdlX25vc3luYyhtbSwgdWFkZHIpOwo+PiB9Cj4+Cj4+IHNvIGl0IHNlZW1zIGZv bGlvX3JlZmVyZW5jZWQgaXMgdGhlIG9ubHkgbGVmdCB1c2VyIG9mIHRoaXMKPj4gcHRlcF9jbGVh cl9mbHVzaF95b3VuZygpLgo+PiBUaGUgZmFjdCBtYWtlcyBCYW9saW4ncyBwYXRjaCBsb29rIHNh ZmUgbm93Lgo+Pgo+PiBidXQgdGhpcyBmdW5jdGlvbiBzdGlsbCBoYXMgImZsdXNoIiBpbiBpdHMg bmFtZSwgc28gb25lIGRheSwgb25lIHBlcnNvbiBtaWdodAo+PiBjYWxsIGl0IHdpdGggdGhlIHVu ZGVyc3RhbmRpbmcgdGhhdCBpdCB3aWxsIGZsdXNoIHRsYiBidXQgYWN0dWFsbHkgaXQKPj4gd29u J3QuIFRoaXMgaXMKPj4gYmFkIHNtZWxsIGluIGNvZGUuCgpBZ3JlZS4gSSB0aGluayB0aGlzIGlz IGpzdXQgYSBzdGFydCwgd2UgY2FuIHJlcGxhY2UgCnB0ZXBfY2xlYXJfZmx1c2hfeW91bmcoKSBv bmNlIG90aGVyIGFyY2hpdGVjdHVyZXMgaGF2ZSBjb21wbGV0ZWQgdGhlIApjb252ZXJzaW9uLCBp ZiB3ZSBjYW4gY29uZmlybSB0aGF0IG90aGVyIGFyY2hpdGVjdHVyZXMgYWxzbyBkbyBub3QgCnJl cXVpcmUgdGxiIGZsdXNoIHdoZW4gY2xlYXJpbmcgdGhlIGFjY2Vzc2VkIGJpdC4KCj4+IEkgZ3Vl c3Mgb25lIHNpZGUgZWZmZWN0IG9mIG5vdCBmbHVzaGluZyB0bGIgd2hpbGUgY2xlYXJpbmcgdGhl IGFjY2Vzcwo+PiBmbGFnIGlzIHRoYXQKPj4gaGFyZHdhcmUgd29uJ3Qgc2VlIHRoaXMgY2xlYXJl ZCBmbGFnIGluIHRoZSB0bGIsIHNvIGl0IG1pZ2h0IG5vdCBzZXQgdGhpcyBiaXQgaW4KPj4gbWVt b3J5IGV2ZW4gdGhvdWdoIHRoZSBiaXQgaGFzIGJlZW4gY2xlYXJlZCBiZWZvcmUgaW4gbWVtb3J5 KGJ1dCBub3QgaW4gdGxiKQo+PiB3aGlsZSB0aGUgcGFnZSBpcyBhY2Nlc3NlZCAqYWdhaW4qLiA+ Pgo+PiBuZXh0IHRpbWUsIHNvbWVvbmUgcmVhZHMgdGhlIGFjY2VzcyBmbGFnIGluIG1lbW9yeSBh Z2FpbiBieSBmb2xpb19yZWZlcmVuY2VkLAo+PiBoZS9zaGUgd2lsbCBzZWUgdGhlIHBhZ2UgaXMg Y29sZCBhcyBoYXJkd2FyZSBoYXMgbG9zdCBhIGNoYW5jZSB0byBzZXQKPj4gdGhlIGJpdCBhZ2Fp bgo+PiBzaW5jZSBpdCBmaW5kcyB0bGIgYWxyZWFkeSBoYXMgYSB0cnVlIGFjY2VzcyBmbGFnLgo+ Pgo+PiBCdXQgYW55d2F5LCB0bGIgaXMgc28gc21hbGwsIGl0IHdpbGwgYmUgZmx1c2hlZCBieSBj b250ZXh0IHN3aXRjaCBhbmQKPj4gb3RoZXIgcnVubmluZwo+PiBjb2RlIHNvb24uIHNvIGl0IHNl ZW1zIHdlIGRvbid0IGFjdHVhbGx5IHJlcXVpcmUgdGhlIGFjY2VzcyBmbGFnIGJlaW5nIGluc3Rh bnRseQo+PiB1cGRhdGVkLiB0aGUgdGltZSBnYXAsIGluIHdoaWNoIGFjY2VzcyBmbGFnIG1pZ2h0 IGxvc2UgdGhlIG5ldyBzZXQgYnkgaGFyZHdhcmUsCj4+IHNlZW1zIHRvIGJlIHRvbyBzaG9ydCB0 byByZWFsbHkgYWZmZWN0IHRoZSBhY2N1cmFjeSBvZiBwYWdlIHJlY2xhbWF0aW9uLiBidXQgaXRz Cj4+IGNvc3QgaXMgbGFyZ2UuCj4+Cj4+IChBKS4gQ29uc3RhbnQgZmx1c2ggY29zdCB2cy4gKEIp LiB2ZXJ5IHZlcnkgb2NjYXNpb25hbCByZWNsYWltZWQgaG90Cj4+IHBhZ2UsICBCIG1pZ2h0Cj4+ IGJlIGEgY29ycmVjdCBjaG9pY2UuCj4gCj4gUGx1cywgSSBkb3VidCBCIGlzIHJlYWxseSBnb2lu ZyB0byBoYXBwZW4uIGFzIGFmdGVyIGEgcGFnZSBpcyBwcm9tb3RlZCB0bwo+IHRoZSBoZWFkIG9m IGxydSBsaXN0IG9yIG5ldyBnZW5lcmF0aW9uLCBpdCBuZWVkcyBhIGxvbmcgdGltZSB0byBzbGlk ZSBiYWNrCj4gdG8gdGhlIGluYWN0aXZlIGxpc3QgdGFpbCBvciB0byB0aGUgY2FuZGlkYXRlIGdl bmVyYXRpb24gb2YgbWdscnUuIHRoZSB0aW1lCj4gc2hvdWxkIGhhdmUgYmVlbiBsYXJnZSBlbm91 Z2ggZm9yIHRsYiB0byBiZSBmbHVzaGVkLiBJZiB0aGUgcGFnZSBpcyByZWFsbHkKPiBob3QsIHRo ZSBoYXJkd2FyZSB3aWxsIGdldCBzZWNvbmQsIHRoaXJkLCBmb3VydGggZXRjIG9wcG9ydHVuaXR5 IHRvIHNldCBhbgo+IGFjY2VzcyBmbGFnIGluIHRoZSBsb25nIHRpbWUgaW4gd2hpY2ggdGhlIHBh Z2UgaXMgcmUtbW92ZWQgdG8gdGhlIHRhaWwKPiBhcyB0aGUgcGFnZSBjYW4gYmUgYWNjZXNzZWQg bXVsdGlwbGUgdGltZXMgaWYgaXQgaXMgcmVhbGx5IGhvdC4KClRoYW5rcyBCYXJyeSwgdGhhdCdz IGFsc28gd2hhdCBJIHRob3VnaHQuIE9uIHRoZSBvdGhlciBoYW5kLCBldmVuIGlmIAp0aGVyZSBp cyBubyB0bGIgZmx1c2ggZm9yIGEgbG9uZyB0aW1lLCBJIHRoaW5rIHRoZSBzeXN0ZW0gaXMgbm90 IHVuZGVyIAptZW1vcnkgcHJlc3N1cmUgYXQgdGhhdCB0aW1lLCBzbyB0aGUgaW5jb3JyZWN0IHBh Z2UgYWdpbmcgd291bGQgbm90IGhhdmUgCm11Y2ggaW1wYWN0LgoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxp c3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72EDDC25B6D for ; Wed, 25 Oct 2023 02:02:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 001BF6B0302; Tue, 24 Oct 2023 22:02:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ECCE76B0305; Tue, 24 Oct 2023 22:02:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D6CF56B0306; Tue, 24 Oct 2023 22:02:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C1DCE6B0302 for ; Tue, 24 Oct 2023 22:02:47 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 983EF12061E for ; Wed, 25 Oct 2023 02:02:47 +0000 (UTC) X-FDA: 81382335174.23.7195F8D Received: from out30-111.freemail.mail.aliyun.com (out30-111.freemail.mail.aliyun.com [115.124.30.111]) by imf05.hostedemail.com (Postfix) with ESMTP id 70B66100013 for ; Wed, 25 Oct 2023 02:02:41 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf05.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.111 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698199366; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BlNrEeBm3pvzEaRgFUZT/A9PzBROjnBRtd807jZv6M4=; b=WhsEz2B3JgPXl73M/eUKObOSBdum/S3X+ZgP18vUMpqwU0jwCrmE2wqyMNik3t4W84iqbm mu+25w2fuRAhLiyA9oofjNO31j+asBOUjB/S1Z1yr+67HFkO2ApSmdXpY270v6b4a5yfL2 mhvtFUCjQRXYvXZEiKC84MPSsSoabNU= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf05.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.111 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698199366; a=rsa-sha256; cv=none; b=STcgxxS8pzVH6P1H9T3mb222REc5UtUbZYkf6c6DQItf6r5UCCpCD+WvHw+kEm85mDL/Zr /HSPNN29kniUflEMfczKh9DFktE2gImCcgYfIW/PGIpP2PjdqGi0ZuP8vWydFMjUhboA1X Otfr6a6QrWLluH4S0lKWk8QUV+s9qKM= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R481e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046051;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0VusYSvA_1698199355; Received: from 30.97.48.63(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VusYSvA_1698199355) by smtp.aliyun-inc.com; Wed, 25 Oct 2023 10:02:36 +0800 Message-ID: Date: Wed, 25 Oct 2023 10:02:51 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] arm64: mm: drop tlb flush operation when clearing the access bit To: Barry Song <21cnbao@gmail.com> Cc: catalin.marinas@arm.com, will@kernel.org, akpm@linux-foundation.org, v-songbaohua@oppo.com, yuzhao@google.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: From: Baolin Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 70B66100013 X-Stat-Signature: sc8t8giyrbc9h3wxrregnqjrwennu9im X-HE-Tag: 1698199361-955466 X-HE-Meta: U2FsdGVkX1/rWsMN76C+4EgI9dpF9o1BeGyI10c3Zowl5Tbfw5T9Z69I/1jRZ/PZsQcFfZjzxoP0/pesN1UD4ef1n3YsqZYUW1T0qYkxOz12Lad+mj3XIKqr/hf3bM5aOCATevOLCYRPvw9UHL6Qv3EfTyS6poZHbNR+/KWDBbEHj7W8R9oNRSS3+t/iYB0H2QtPohd1wvLu3N6Vtk5QQ3doY2OGCwhFkIJMxINTM4k2CxgpJkS5AU/hTfeVEhAXPPcV+pnwmYssBrdyz63JpgTLnDNV1Lh2LSIvGDIshdWIuQ9+mH2TYJArz2fftUZPXv+Jvf9d3MqHo39WABvyK0dRNPuixhSS811bX3wm0MiOucaWXCIihwz3j8dZEDTAFnTYSqih6yu8rtC7dQdjbl5cf9k1e4reOG2nXmf3tUfSGP7iPCkYlIKoX2eDVrymhUd+BuVEp4LPBQJy7SS9UcEBCUoDqEANSJtPsvU1O8NPZYLIrmn5YhbYXFFHREJptSTP6sz+eDTYUqiBybkM4i20sINrbqO34yy4RdKFg9hwGPUpGSw+8x9eoNN25IWW+bFI7HCWPqcaMEbNypKjhLkP9YnqqkClgrtnVT5qCY3/Y4+AxDW4bamJiIfxF8JLUPdvZoAnvGMennZLo1yYNeEbqbfd3wVCwKhG2C+QhOmyJaJM3FIIYErxwqUwrGsTGUcVa2XO1qewa8aIQhFSBYAQJTLu09GhtAp/IuWumx8TrKjmnoNY628Tu2UGTwMvIyfuKG6XXw+0fRb+QNJwq7ZNt4L5FGbfV64n+LGeX4weJ1D87PkuqPKcGCUwXwYihecaxyrjBIbTgW3bbxUaLgKQxpdi5MxvZ/YiYyoFzZFCN0L939pVRfMvqZQw9s2whbxoWQpOyWcXk2JAGhGk3wxUhCjxYjOZlfU0Wy5O9rpVK1VGlP2oq7Qpnw3EUyHMqs4onrkBTWE96cP8SK1 ensZGLiD T8o0Az7rd9/eNJL3WxEt/MEq7xbceVAIidrJb6oFZEIU8w7kcPrPjiH5CobnxnxorFA62x7Crul+5OVue1yrBYPE7oj/N2q0T+8oi7eXosQP7zH5bL77XmUoTbg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/25/2023 7:31 AM, Barry Song wrote: > On Wed, Oct 25, 2023 at 7:16 AM Barry Song <21cnbao@gmail.com> wrote: >> >> On Tue, Oct 24, 2023 at 8:57 PM Baolin Wang >> wrote: >>> >>> Now ptep_clear_flush_young() is only called by folio_referenced() to >>> check if the folio was referenced, and now it will call a tlb flush on >>> ARM64 architecture. However the tlb flush can be expensive on ARM64 >>> servers, especially for the systems with a large CPU numbers. >>> >>> Similar to the x86 architecture, below comments also apply equally to >>> ARM64 architecture. So we can drop the tlb flush operation in >>> ptep_clear_flush_young() on ARM64 architecture to improve the performance. >>> " >>> /* Clearing the accessed bit without a TLB flush >>> * doesn't cause data corruption. [ It could cause incorrect >>> * page aging and the (mistaken) reclaim of hot pages, but the >>> * chance of that should be relatively low. ] >>> * >>> * So as a performance optimization don't flush the TLB when >>> * clearing the accessed bit, it will eventually be flushed by >>> * a context switch or a VM operation anyway. [ In the rare >>> * event of it not getting flushed for a long time the delay >>> * shouldn't really matter because there's no real memory >>> * pressure for swapout to react to. ] >>> */ >>> " >>> Running the thpscale to show some obvious improvements for compaction >>> latency with this patch: >>> base patched >>> Amean fault-both-1 1093.19 ( 0.00%) 1084.57 * 0.79%* >>> Amean fault-both-3 2566.22 ( 0.00%) 2228.45 * 13.16%* >>> Amean fault-both-5 3591.22 ( 0.00%) 3146.73 * 12.38%* >>> Amean fault-both-7 4157.26 ( 0.00%) 4113.67 * 1.05%* >>> Amean fault-both-12 6184.79 ( 0.00%) 5218.70 * 15.62%* >>> Amean fault-both-18 9103.70 ( 0.00%) 7739.71 * 14.98%* >>> Amean fault-both-24 12341.73 ( 0.00%) 10684.23 * 13.43%* >>> Amean fault-both-30 15519.00 ( 0.00%) 13695.14 * 11.75%* >>> Amean fault-both-32 16189.15 ( 0.00%) 14365.73 * 11.26%* >>> base patched >>> Duration User 167.78 161.03 >>> Duration System 1836.66 1673.01 >>> Duration Elapsed 2074.58 2059.75 >>> >>> Barry Song submitted a similar patch [1] before, that replaces the >>> ptep_clear_flush_young_notify() with ptep_clear_young_notify() in >>> folio_referenced_one(). However, I'm not sure if removing the tlb flush >>> operation is applicable to every architecture in kernel, so dropping >>> the tlb flush for ARM64 seems a sensible change. >>> >>> Note: I am okay for both approach, if someone can help to ensure that >>> all architectures do not need the tlb flush when clearing the accessed >>> bit, then I also think Barry's patch is better (hope Barry can resend >>> his patch). >>> >> >> Thanks! >> >> ptep_clear_flush_young() with "flush" in its name clearly says it needs a >> flush. but it happens in arm64, all other code which needs a flush has >> called other variants, for example __flush_tlb_page_nosync(): >> >> static inline void arch_tlbbatch_add_pending(struct >> arch_tlbflush_unmap_batch *batch, >> struct mm_struct *mm, unsigned long uaddr) >> { >> __flush_tlb_page_nosync(mm, uaddr); >> } >> >> so it seems folio_referenced is the only left user of this >> ptep_clear_flush_young(). >> The fact makes Baolin's patch look safe now. >> >> but this function still has "flush" in its name, so one day, one person might >> call it with the understanding that it will flush tlb but actually it >> won't. This is >> bad smell in code. Agree. I think this is jsut a start, we can replace ptep_clear_flush_young() once other architectures have completed the conversion, if we can confirm that other architectures also do not require tlb flush when clearing the accessed bit. >> I guess one side effect of not flushing tlb while clearing the access >> flag is that >> hardware won't see this cleared flag in the tlb, so it might not set this bit in >> memory even though the bit has been cleared before in memory(but not in tlb) >> while the page is accessed *again*. >> >> next time, someone reads the access flag in memory again by folio_referenced, >> he/she will see the page is cold as hardware has lost a chance to set >> the bit again >> since it finds tlb already has a true access flag. >> >> But anyway, tlb is so small, it will be flushed by context switch and >> other running >> code soon. so it seems we don't actually require the access flag being instantly >> updated. the time gap, in which access flag might lose the new set by hardware, >> seems to be too short to really affect the accuracy of page reclamation. but its >> cost is large. >> >> (A). Constant flush cost vs. (B). very very occasional reclaimed hot >> page, B might >> be a correct choice. > > Plus, I doubt B is really going to happen. as after a page is promoted to > the head of lru list or new generation, it needs a long time to slide back > to the inactive list tail or to the candidate generation of mglru. the time > should have been large enough for tlb to be flushed. If the page is really > hot, the hardware will get second, third, fourth etc opportunity to set an > access flag in the long time in which the page is re-moved to the tail > as the page can be accessed multiple times if it is really hot. Thanks Barry, that's also what I thought. On the other hand, even if there is no tlb flush for a long time, I think the system is not under memory pressure at that time, so the incorrect page aging would not have much impact.