From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-184.mta0.migadu.com (out-184.mta0.migadu.com [91.218.175.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D52631940A1 for ; Tue, 23 Dec 2025 07:36:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.184 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766475400; cv=none; b=O5it0RPqkD0xVa/LtFwESk/H5aXQDTg0G/r69Dvzos+eDczI7HNQb7/DQSCjgWuHt00uAyC8cd4vQSmWyAMoMEGcqri+EyoorBFQJE4Jr+KbaRcvahrmolr/hRbI+UyLOzmPoO3ec6PBLfNxggmy83ktjSMJbk5MH5tovCm4jpk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766475400; c=relaxed/simple; bh=RXFXzlM94y7J9cL6n70mGltPf6pZraGleBfUfnqfVaA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Eh2vYNaeHll7YU2hRZXpvq9erRSdocOCey3/++fvFpPKoFkh0aK56XkDPogHKNS3ori32DZaW6tdrZkq9VKBXu4aoGNdKVJkutADogtP3Er7BhY0k3grcElIvFRRQ3Lj6pci4WWlmNfHRKyVBEwuAGPKmMqOFqqz+olr7xbebCY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=DbMxoXZj; arc=none smtp.client-ip=91.218.175.184 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="DbMxoXZj" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1766475393; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vU4D8eVlA0WNfHgjVyUPRNgZqusNXdUnzSVKoGOZJXU=; b=DbMxoXZjq4Nrp7MllryAKeSeF5guIHdtNVeFc1E/f+EZ3Sk6OOHx78ip8+oziqBlhG0QhH 9cQ3YYg2lDkb3fG1mZ95lP0AVAtBS6vzQJQXNeVQ/KARz7vifN+BXRNdhEbGlFFBOlhTQJ 5lRErhPjSeQpla29Qpv5BmTEt6nD7E4= Date: Tue, 23 Dec 2025 07:36:30 +0000 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v2 1/2] net: phy: adin: enable configuration of the LP Termination Register To: Osose Itua , netdev@vger.kernel.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, michael.hennerich@analog.com, jerome.oufella@savoirfairelinux.com References: <20251222222210.3651577-1-osose.itua@savoirfairelinux.com> <20251222222210.3651577-2-osose.itua@savoirfairelinux.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: <20251222222210.3651577-2-osose.itua@savoirfairelinux.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 22/12/2025 22:21, Osose Itua wrote: > The ADIN1200/ADIN1300 provide a control bit that selects between normal > receive termination and the lowest common mode impedance for 100BASE-TX > operation. This behavior is controlled through the Low Power Termination > register (B_100_ZPTM_EN_DIMRX). > > Bit 0 of this register enables normal termination when set (this is the > default), and selects the lowest common mode impedance when cleared. > > Signed-off-by: Osose Itua > --- > drivers/net/phy/adin.c | 34 ++++++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > > diff --git a/drivers/net/phy/adin.c b/drivers/net/phy/adin.c > index 7fa713ca8d45..e8b778cb191d 100644 > --- a/drivers/net/phy/adin.c > +++ b/drivers/net/phy/adin.c > @@ -4,6 +4,7 @@ > * > * Copyright 2019 Analog Devices Inc. > */ > +#include This kind of include is not used in kernel. You don't need to include anything in this file to have EINVAL defined. > #include > #include > #include > @@ -89,6 +90,9 @@