From: Markus Elfring <Markus.Elfring@web.de>
To: Wang Zhaolong <wangzhaolong1@huawei.com>, linux-unionfs@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Amir Goldstein <amir73il@gmail.com>,
Miklos Szeredi <miklos@szeredi.hu>,
Yang Erkun <yangerkun@huawei.com>, Zhang Yi <yi.zhang@huawei.com>
Subject: Re: [PATCH] overlayfs: fix potential NULL pointer dereferences in file handle code
Date: Tue, 29 Apr 2025 20:34:25 +0200 [thread overview]
Message-ID: <d1eeea14-4a5c-4f7e-9e54-e552bc1d239f@web.de> (raw)
In-Reply-To: <20250429001308.370040-1-wangzhaolong1@huawei.com>
…
> Fix these potential NULL pointer dereferences by adding appropriate NULL
> checks before accessing the file handle structure members.
How do you think about to omit the word “potential” here?
> V1 -> V2:
> - Reworked ovl_verify_fh() …
* You may specify patch version descriptions behind a marker line.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.15-rc4#n796
Please synchronise the version indication in the subject prefix accordingly.
* Would you like to reconsider the assignment also for the variable “err” similarly?
Regards,
Markus
next prev parent reply other threads:[~2025-04-29 18:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 0:13 [PATCH] overlayfs: fix potential NULL pointer dereferences in file handle code Wang Zhaolong
2025-04-29 12:01 ` Miklos Szeredi
2025-04-30 9:56 ` Wang Zhaolong
2025-04-29 18:34 ` Markus Elfring [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-04-28 11:11 Wang Zhaolong
2025-04-28 11:48 ` Markus Elfring
2025-04-28 13:01 ` Wang Zhaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1eeea14-4a5c-4f7e-9e54-e552bc1d239f@web.de \
--to=markus.elfring@web.de \
--cc=amir73il@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=wangzhaolong1@huawei.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.