From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1509FC77B70 for ; Fri, 14 Apr 2023 10:19:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230128AbjDNKTU (ORCPT ); Fri, 14 Apr 2023 06:19:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230115AbjDNKTQ (ORCPT ); Fri, 14 Apr 2023 06:19:16 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0AFFA7EF8; Fri, 14 Apr 2023 03:19:11 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 5052A6603221; Fri, 14 Apr 2023 11:19:09 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1681467550; bh=VeLJmPRvnvEQ5IsnqXZVpDeqo2cwm0kmKEbVshVuBp8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=D4l4IvXvCtqC3q5kEPR63kKHkXr3NXvxuaNRo9Tu3sa2jvRz7b6V543y+h/1EObv5 UzpIhgf2ablwIZJHwB3fKsigC0ozALklq9Bu1D9+Bk635GloxxsT2oTvjFU+0E7m8a hux5psPRVFbuKQT/p1/o1MSsLzFyReEIeuvshJ6BUZ/1ywpiWV59Sht2JvsCOG+EKc fm9fWjVZn+XubQ2RVUMNyKx1Ll1e6qF2eJcAft3lXVL65oktw3u5RhmWgODO9O8Myh ZkC33DerM75vwRrpMwG+MTzFxteIVSodfbzBMp41kGdwTGH2beS9ACWzW4gLXXAIys VEMo3Vlw5OoMA== Message-ID: Date: Fri, 14 Apr 2023 12:19:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2 7/7] leds: leds-mt6323: Add support for WLEDs and MT6332 Content-Language: en-US To: Alexandre Mergnat , pavel@ucw.cz Cc: lee@kernel.org, sean.wang@mediatek.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com References: <20230412153310.241046-1-angelogioacchino.delregno@collabora.com> <20230412153310.241046-8-angelogioacchino.delregno@collabora.com> <00c0b699-ba1a-951c-185a-ef8f09abf6f3@baylibre.com> From: AngeloGioacchino Del Regno In-Reply-To: <00c0b699-ba1a-951c-185a-ef8f09abf6f3@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Il 13/04/23 16:15, Alexandre Mergnat ha scritto: > On 12/04/2023 17:33, AngeloGioacchino Del Regno wrote: >> Add basic code to turn on and off WLEDs and wire up MT6332 support >> to take advantage of it. >> This is a simple approach due to to the aforementioned PMIC supporting >> only on/off status so, at the time of writing, it is impossible for me >> to validate more advanced functionality due to lack of hardware. >> >> Signed-off-by: AngeloGioacchino Del Regno >> --- >>   drivers/leds/leds-mt6323.c | 171 +++++++++++++++++++++++++++++++++++-- >>   1 file changed, 164 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/leds/leds-mt6323.c b/drivers/leds/leds-mt6323.c >> index 5d95dbd9a761..202b38ac32f6 100644 >> --- a/drivers/leds/leds-mt6323.c >> +++ b/drivers/leds/leds-mt6323.c ..snip.. >> @@ -418,6 +538,7 @@ static int mt6323_led_probe(struct platform_device *pdev) >>       int ret; >>       unsigned int status; >>       u32 reg; >> +    u8 max_leds; >>       leds = devm_kzalloc(dev, sizeof(*leds), GFP_KERNEL); >>       if (!leds) >> @@ -428,6 +549,7 @@ static int mt6323_led_probe(struct platform_device *pdev) >>       leds->pdata = device_get_match_data(dev); >>       regs = leds->pdata->regs; >>       spec = leds->pdata->spec; >> +    max_leds = spec->max_leds + spec->max_wleds; > > I haven't access to the datasheet so I have to ask you: > Why the max leds value is the addition of max led and wled ? > > IMO, the datasheed give you the max supported led OR wled on its bus function to > the maximum supplied current by the PMIC (I assume LED or WLED have different > need). Or the PMIC has 2 bus, one for led and another for wled ? > I don't have access to the datasheet for MT6332 as well - but anyway, the only purpose of the max_leds variable is to validate the maximum number of 'reg' spaces that we're supposed to read from devicetree, that's all. The alternative would've been to check if there's any led, then any wled in the mt6323_hwspec from platform data - then: if only wleds, max_leds = wleds; else if only leds, max_leds = leds; else if leds and wleds, max_leds = leds + wleds; You see that it doesn't make any sense to do such check, and we can go with just adding wleds+leds. Regards, Angelo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C3D7C77B6E for ; Fri, 14 Apr 2023 10:20:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mtVRyJASqCiDkCZYywdDuaBQuSJslD+PFEkRxgtD9oc=; b=kLu4P7qfpFvRth QqR7RWBXBVYWVO3dk+cdFLb3iQuzlyZCqpbcEnyPpmy1Fq/sNHFTY3Wa2img9WF+oiciDd22wA7Io FPYt25q2xYdkYLAEADJoC4MFpVyDvxvioTbOunK2JaEF/mIOKyn/cEAYIzLkbfiljip9Hw1JQpG94 +JLKs3pDzkifCx7zyl+PyhEe2VT2E9fSdjxsWcfzN0buja785U6IrT3W8eJLCfFTEvYs6KO0IAJ2W UHkXhLqE/AmDQKjjjazIYJCVToAS8SUlwYHRdncNjfEO1pEkSmY4rjWPKxJ+YwpX5JXuQAF2DisJv KxH8vlT3HVtQnEZOo2Lg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pnGWX-0092yG-2B; Fri, 14 Apr 2023 10:19:21 +0000 Received: from madras.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e5ab]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pnGWU-0092vK-2u; Fri, 14 Apr 2023 10:19:20 +0000 Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 5052A6603221; Fri, 14 Apr 2023 11:19:09 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1681467550; bh=VeLJmPRvnvEQ5IsnqXZVpDeqo2cwm0kmKEbVshVuBp8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=D4l4IvXvCtqC3q5kEPR63kKHkXr3NXvxuaNRo9Tu3sa2jvRz7b6V543y+h/1EObv5 UzpIhgf2ablwIZJHwB3fKsigC0ozALklq9Bu1D9+Bk635GloxxsT2oTvjFU+0E7m8a hux5psPRVFbuKQT/p1/o1MSsLzFyReEIeuvshJ6BUZ/1ywpiWV59Sht2JvsCOG+EKc fm9fWjVZn+XubQ2RVUMNyKx1Ll1e6qF2eJcAft3lXVL65oktw3u5RhmWgODO9O8Myh ZkC33DerM75vwRrpMwG+MTzFxteIVSodfbzBMp41kGdwTGH2beS9ACWzW4gLXXAIys VEMo3Vlw5OoMA== Message-ID: Date: Fri, 14 Apr 2023 12:19:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2 7/7] leds: leds-mt6323: Add support for WLEDs and MT6332 Content-Language: en-US To: Alexandre Mergnat , pavel@ucw.cz Cc: lee@kernel.org, sean.wang@mediatek.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com References: <20230412153310.241046-1-angelogioacchino.delregno@collabora.com> <20230412153310.241046-8-angelogioacchino.delregno@collabora.com> <00c0b699-ba1a-951c-185a-ef8f09abf6f3@baylibre.com> From: AngeloGioacchino Del Regno In-Reply-To: <00c0b699-ba1a-951c-185a-ef8f09abf6f3@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230414_031919_159444_DE643905 X-CRM114-Status: GOOD ( 19.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SWwgMTMvMDQvMjMgMTY6MTUsIEFsZXhhbmRyZSBNZXJnbmF0IGhhIHNjcml0dG86Cj4gT24gMTIv MDQvMjAyMyAxNzozMywgQW5nZWxvR2lvYWNjaGlubyBEZWwgUmVnbm8gd3JvdGU6Cj4+IEFkZCBi YXNpYyBjb2RlIHRvIHR1cm4gb24gYW5kIG9mZiBXTEVEcyBhbmQgd2lyZSB1cCBNVDYzMzIgc3Vw cG9ydAo+PiB0byB0YWtlIGFkdmFudGFnZSBvZiBpdC4KPj4gVGhpcyBpcyBhIHNpbXBsZSBhcHBy b2FjaCBkdWUgdG8gdG8gdGhlIGFmb3JlbWVudGlvbmVkIFBNSUMgc3VwcG9ydGluZwo+PiBvbmx5 IG9uL29mZiBzdGF0dXMgc28sIGF0IHRoZSB0aW1lIG9mIHdyaXRpbmcsIGl0IGlzIGltcG9zc2li bGUgZm9yIG1lCj4+IHRvIHZhbGlkYXRlIG1vcmUgYWR2YW5jZWQgZnVuY3Rpb25hbGl0eSBkdWUg dG8gbGFjayBvZiBoYXJkd2FyZS4KPj4KPj4gU2lnbmVkLW9mZi1ieTogQW5nZWxvR2lvYWNjaGlu byBEZWwgUmVnbm8gPGFuZ2Vsb2dpb2FjY2hpbm8uZGVscmVnbm9AY29sbGFib3JhLmNvbT4KPj4g LS0tCj4+IMKgIGRyaXZlcnMvbGVkcy9sZWRzLW10NjMyMy5jIHwgMTcxICsrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrLS0KPj4gwqAgMSBmaWxlIGNoYW5nZWQsIDE2NCBpbnNlcnRp b25zKCspLCA3IGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9sZWRzL2xl ZHMtbXQ2MzIzLmMgYi9kcml2ZXJzL2xlZHMvbGVkcy1tdDYzMjMuYwo+PiBpbmRleCA1ZDk1ZGJk OWE3NjEuLjIwMmIzOGFjMzJmNiAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9sZWRzL2xlZHMtbXQ2 MzIzLmMKPj4gKysrIGIvZHJpdmVycy9sZWRzL2xlZHMtbXQ2MzIzLmMKCi4uc25pcC4uCgo+PiBA QCAtNDE4LDYgKzUzOCw3IEBAIHN0YXRpYyBpbnQgbXQ2MzIzX2xlZF9wcm9iZShzdHJ1Y3QgcGxh dGZvcm1fZGV2aWNlICpwZGV2KQo+PiDCoMKgwqDCoMKgIGludCByZXQ7Cj4+IMKgwqDCoMKgwqAg dW5zaWduZWQgaW50IHN0YXR1czsKPj4gwqDCoMKgwqDCoCB1MzIgcmVnOwo+PiArwqDCoMKgIHU4 IG1heF9sZWRzOwo+PiDCoMKgwqDCoMKgIGxlZHMgPSBkZXZtX2t6YWxsb2MoZGV2LCBzaXplb2Yo KmxlZHMpLCBHRlBfS0VSTkVMKTsKPj4gwqDCoMKgwqDCoCBpZiAoIWxlZHMpCj4+IEBAIC00Mjgs NiArNTQ5LDcgQEAgc3RhdGljIGludCBtdDYzMjNfbGVkX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9k ZXZpY2UgKnBkZXYpCj4+IMKgwqDCoMKgwqAgbGVkcy0+cGRhdGEgPSBkZXZpY2VfZ2V0X21hdGNo X2RhdGEoZGV2KTsKPj4gwqDCoMKgwqDCoCByZWdzID0gbGVkcy0+cGRhdGEtPnJlZ3M7Cj4+IMKg wqDCoMKgwqAgc3BlYyA9IGxlZHMtPnBkYXRhLT5zcGVjOwo+PiArwqDCoMKgIG1heF9sZWRzID0g c3BlYy0+bWF4X2xlZHMgKyBzcGVjLT5tYXhfd2xlZHM7Cj4gCj4gSSBoYXZlbid0IGFjY2VzcyB0 byB0aGUgZGF0YXNoZWV0IHNvIEkgaGF2ZSB0byBhc2sgeW91Ogo+IFdoeSB0aGUgbWF4IGxlZHMg dmFsdWUgaXMgdGhlIGFkZGl0aW9uIG9mIG1heCBsZWQgYW5kIHdsZWQgPwo+IAo+IElNTywgdGhl IGRhdGFzaGVlZCBnaXZlIHlvdSB0aGUgbWF4IHN1cHBvcnRlZCBsZWQgT1Igd2xlZCBvbiBpdHMg YnVzIGZ1bmN0aW9uIHRvIAo+IHRoZSBtYXhpbXVtIHN1cHBsaWVkIGN1cnJlbnQgYnkgdGhlIFBN SUMgKEkgYXNzdW1lIExFRCBvciBXTEVEIGhhdmUgZGlmZmVyZW50IAo+IG5lZWQpLiBPciB0aGUg UE1JQyBoYXMgMiBidXMsIG9uZSBmb3IgbGVkIGFuZCBhbm90aGVyIGZvciB3bGVkID8KPiAKCkkg ZG9uJ3QgaGF2ZSBhY2Nlc3MgdG8gdGhlIGRhdGFzaGVldCBmb3IgTVQ2MzMyIGFzIHdlbGwgLSBi dXQgYW55d2F5LCB0aGUgb25seQpwdXJwb3NlIG9mIHRoZSBtYXhfbGVkcyB2YXJpYWJsZSBpcyB0 byB2YWxpZGF0ZSB0aGUgbWF4aW11bSBudW1iZXIgb2YgJ3JlZycKc3BhY2VzIHRoYXQgd2UncmUg c3VwcG9zZWQgdG8gcmVhZCBmcm9tIGRldmljZXRyZWUsIHRoYXQncyBhbGwuCgpUaGUgYWx0ZXJu YXRpdmUgd291bGQndmUgYmVlbiB0byBjaGVjayBpZiB0aGVyZSdzIGFueSBsZWQsIHRoZW4gYW55 IHdsZWQgaW4gdGhlCm10NjMyM19od3NwZWMgZnJvbSBwbGF0Zm9ybSBkYXRhIC0gdGhlbjoKCmlm IG9ubHkgd2xlZHMsIG1heF9sZWRzID0gd2xlZHM7CmVsc2UgaWYgb25seSBsZWRzLCBtYXhfbGVk cyA9IGxlZHM7CmVsc2UgaWYgbGVkcyBhbmQgd2xlZHMsIG1heF9sZWRzID0gbGVkcyArIHdsZWRz OwoKWW91IHNlZSB0aGF0IGl0IGRvZXNuJ3QgbWFrZSBhbnkgc2Vuc2UgdG8gZG8gc3VjaCBjaGVj aywgYW5kIHdlIGNhbiBnbyB3aXRoCmp1c3QgYWRkaW5nIHdsZWRzK2xlZHMuCgpSZWdhcmRzLApB bmdlbG8KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LWFybS1rZXJuZWwK