From: Guenter Roeck <linux@roeck-us.net>
To: sashiko-reviews@lists.linux.dev
Cc: phucduc.bui@gmail.com, linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v3] watchdog: orion_wdt: Propagate errors from optional IRQ lookup
Date: Mon, 10 Aug 2026 07:28:21 -0700 [thread overview]
Message-ID: <d20da173-3afc-4ebe-a89f-fac6f89c8b73@roeck-us.net> (raw)
In-Reply-To: <20260810083632.3B29D1F000E9@smtp.kernel.org>
On Mon, Aug 10, 2026 at 08:36:31AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
>
> Pre-existing issues:
> - [High] Probe deferral of optional IRQs causes a running watchdog to reset the system.
> - [High] Race condition in driver removal and error paths allows IRQ handler to access unclocked registers.
The first problem can't be addressed without somehow selectively
postponing IRQ handler registration, or in other words re-implementing
probe deferral handling in the driver. We are not going to do that.
Fixing the second problem will require using devm_clk_get_enabled()
and is out of scope for this patch.
Guenter
next prev parent reply other threads:[~2026-08-10 14:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 8:26 [PATCH v3] watchdog: orion_wdt: Propagate errors from optional IRQ lookup phucduc.bui
2026-08-10 8:36 ` sashiko-bot
2026-08-10 14:28 ` Guenter Roeck [this message]
2026-08-10 14:29 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d20da173-3afc-4ebe-a89f-fac6f89c8b73@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-watchdog@vger.kernel.org \
--cc=phucduc.bui@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.