From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98B221DED5D for ; Sat, 14 Jun 2025 19:29:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749929351; cv=none; b=SxpMf5XY9EQHcdBWuhX2NELH9nQNyA4hrk5/3k5yZ5wiHDMAgts/XYiv0lNkPAx+PzHCzkwjdyBcpKtDrGW/aJqZPmIgNjgdxeWDV3a3EypGOjwZRN3VVSMsWez1nbojRoOPsihLv+B4l0JBCMkUcgnRnd1yax8bpzz4pBhuDnk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749929351; c=relaxed/simple; bh=xBWb4Vx+9iYeEzK+u1HVql964u9ityny0CkbK7SzumI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=m5LKsInmAeDRWmf3rGdnFx6+PW2wFo2FGAHmtkmC+7AdaqD/F8ixT4h8Yp84eapeF224Z3lQpLUn1vXdYsT9s5KpyP75qk3K2Xauut+WHkvwjuaR7kQ95gNNhCiLjEfyzKv5Pwxi42PX39XStn42GgkxpQyexrIR4Z9MXxsiLT4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bCr5qJjF; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bCr5qJjF" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55EI0F7W005920 for ; Sat, 14 Jun 2025 19:29:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= RmDl5XdrxtUmGgttdm0D/Ht8p5oObZ7nQYXHWGILly0=; b=bCr5qJjF0J6SsMvA HrPmlNzCZPo38Rcw4jd6fDI6nxDYgrzxRr4e2QW4WYtQr/L3ia8XK+WYzQEY6vjb 7FMzydgwrJitDQOv9xFBhzE+jADVnN5nhaiE080pxEY1jyeP1T8Zhr4yzvT4iH1S OdWE5Rr+Dzy5UdXHyqTCkyTHmn7hrhQNX1Aok3JUdkrXqineR34JZxr86goV2qpq Jgvab2eAZIrifMrjAqkNOywqzDXVdmuVyTDF87Z29DQMm0NcCB80pfGUFPAd7Omv UE7O8Sc6jizSFa5waEJePPxR34lY7lu6IlL0ZxTwcOzdYrYyzVPCRKd9nnsJP7q0 WjzgbA== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4791hc8y4m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 14 Jun 2025 19:29:08 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4a5ae436badso6648181cf.2 for ; Sat, 14 Jun 2025 12:29:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749929347; x=1750534147; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RmDl5XdrxtUmGgttdm0D/Ht8p5oObZ7nQYXHWGILly0=; b=wytzMhWBLcjeVoU+4zyWgh8X/lq/LeEQ/utD6zRNTXg1b2c64lnu26igxfIwmhyFMk n/E9bB8XzbteC5pKZQMfirg4m4lCHAlL7Dj/OiVYl1NRVcr8yj9QFpFrs0KCbXkoyjMf 1lqI/KhKpD9BvQxEzNAAWPnt+78WGB1U7hdqzEMHXy4qulPHG6QLCgzwbd6zEaoF9ojf 89z9Bfc//hRuJpHiTpWalC2wzT+T0hggn/9royecUwqGXYs+hS5Ibbc5usstKohEwbAH plloINEJFxtw5vN2+9AWTYqBrs6y8K4xj6OmZ1FYZbFsNdEox84nFoF0KvGb2Rrk3cAQ 1iIQ== X-Forwarded-Encrypted: i=1; AJvYcCUymtCDlwvn7V6u2mHe43W4fbHlJz/mYhl84wRvobRxqvMibHmdIk3cATL1mgWCeFU7DmXsGFssiilJxYel@vger.kernel.org X-Gm-Message-State: AOJu0Yw0p81Gji1M3s1TtHoSKe+asgG5iOiDmnvx1uCHj+oc33H0eEd7 K+FApLltF4JrNM7Z2bm6nYJYHOn7D0UFK/monTFh+Kul+GUo1mk94o2hq/5r+mFTc7FzwmAPzA5 kehdxcxZHKMiSifKkMAxYBeekXfyA/f2pvP/019sl1QDroy/wBdtpoFKQ/+fCpLzZ2zfo X-Gm-Gg: ASbGncvz6saVYsPdaNxuAEoF8zL4tq8+IbrRb7DZ+VSWuE9tY9kCH9yRDl1Eh36A8GV VVqKeq7bhtJvR4do+OcS/tBbLfzg2s5K6urBizyNRfhRaJxAnE26ZD4C5y+nueppQdPG2qVnGl1 A+juKrK8yyRt9eaj2n4Y6fyDLzGSnfiaaX8cLcfaEEULarFmvWFJh4MNorWbHSHDWK9t4mK+CCP 5K6R0PJR/LZI7hAZepcVuWBgAFGiZd5LL9WC45zr2jfjE4TGGfInUiRiX4R/P9LQLPErgxJPj+E o0R4woOvieK27NL6P/5SZuQhDeXHI3mdYxtr13UA1eKwXmpTd7n8tOCvt4lhuuLnp661Y2acd9S pIY8= X-Received: by 2002:a05:622a:1903:b0:494:5984:1022 with SMTP id d75a77b69052e-4a73c5a4600mr22418591cf.11.1749929347187; Sat, 14 Jun 2025 12:29:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHGsVKnNQLpvRnu1ZQSmUOek/Q9FOFzcJQZRaWYRHRFg0qSnSfgW4C3Go5265XFYUDWcy5Q2w== X-Received: by 2002:a05:622a:1903:b0:494:5984:1022 with SMTP id d75a77b69052e-4a73c5a4600mr22418361cf.11.1749929346692; Sat, 14 Jun 2025 12:29:06 -0700 (PDT) Received: from [192.168.143.225] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-adec88fee81sm354561566b.91.2025.06.14.12.29.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 14 Jun 2025 12:29:06 -0700 (PDT) Message-ID: Date: Sat, 14 Jun 2025 21:29:02 +0200 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 08/10] dt-bindings: media: qcom: Add Qualcomm MIPI C-/D-PHY schema for CSIPHY IPs To: Vladimir Zapolskiy , Konrad Dybcio , Krzysztof Kozlowski , Krzysztof Kozlowski , Rob Herring , Bjorn Andersson , Konrad Dybcio , Bryan O'Donoghue Cc: Conor Dooley , Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Neil Armstrong , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org References: <20250612011531.2923701-1-vladimir.zapolskiy@linaro.org> <20250612011531.2923701-9-vladimir.zapolskiy@linaro.org> <6e411e89-ce1e-4d6a-8d48-b800554f830e@kernel.org> <9e38a09b-1521-4196-b179-d29c62e143bc@linaro.org> <4848f13b-3b2c-4210-933c-b4f28d7c6ae7@oss.qualcomm.com> <9bd4ff5d-7c51-4e21-91e8-17c6bcab7f67@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <9bd4ff5d-7c51-4e21-91e8-17c6bcab7f67@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjE0MDE2MiBTYWx0ZWRfX1KvHOIIigfyW Y+6dSrYUSqW5QAk/tRC1h3MNTu6bM2jMebm4AvwCgSYoY7Kcxk6DFQ0fshwLhNt5KRypPgoYWgU wkkmaq3LjFYKWhijE6p0kN8Hj7Qhw6gKS90iKk74frwBxgIMIge81uYwNf7Ki28bNRQOWm+CDds dv1UyCaQvVKDByivk8LdScStx5vUTPqCAcchiwfEJy9XkJZ8bojj/UQbgvAsFQIANSLRAy773u6 liQ/tQkvbqb7Dz18Xwf92+EyjJfQENs8iUK+lAeSqN8e+qo9WEaB6tYElc3a1Fsq3mpuxW6tBLL u1ExjMVzWtaqZVlur+lj4J0ROhAHgCh/+I8HptbeFc/o1xochHahISP/FwK0rqvEt21rG6pHCL0 qiL2Ww6vbP/JY/9m2TSzRA5Qnm95ndUxd6l0avtZGgN2Aa0/Y75oZyPkpILWDbxzDNUkWqvH X-Authority-Analysis: v=2.4 cv=CqK/cm4D c=1 sm=1 tr=0 ts=684dcd84 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6IFa9wvqVegA:10 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=b0AXgi5J3pU-1zpc9bAA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: rFItitSjZbuG8H7XdCo4OaOn6-hw5hs0 X-Proofpoint-GUID: rFItitSjZbuG8H7XdCo4OaOn6-hw5hs0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-14_07,2025-06-13_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 phishscore=0 mlxlogscore=999 priorityscore=1501 lowpriorityscore=0 spamscore=0 malwarescore=0 clxscore=1015 suspectscore=0 mlxscore=0 impostorscore=0 bulkscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506140162 On 6/12/25 6:44 PM, Vladimir Zapolskiy wrote: > On 6/12/25 19:17, Konrad Dybcio wrote: >> On 6/12/25 9:57 AM, Vladimir Zapolskiy wrote: >>> On 6/12/25 10:39, Krzysztof Kozlowski wrote: >>>> On 12/06/2025 09:38, Krzysztof Kozlowski wrote: >>>>> On 12/06/2025 03:15, Vladimir Zapolskiy wrote: >>>>>> Add dt-binding schema for Qualcomm CAMSS CSIPHY IP, which provides >>>>>> MIPI C-PHY/D-PHY interfaces on Qualcomm SoCs. >>>>>> >>>>>> Signed-off-by: Vladimir Zapolskiy >>>>>> --- >>>>>> RFC verion of the change: >>>>>> * https://lore.kernel.org/all/20250513143918.2572689-1-vladimir.zapolskiy@linaro.org/ >>>>>> >>>>>> Changes from RFC to v1: >>>>>> * moved from phy/qcom,csiphy.yaml to media/qcom,csiphy.yaml, >>>>>> * added 'clock-names' property, >>>>>> * removed SM8250 CSIPHY specifics, a generic binding is good enough for now, >>>> >>>> >>>> Now I noticed this... weird change and clearly a no-go. >>>> >>>> Device binding cannot be generic, so it is not good enough for now. >>>> Please write specific bindings for specific hardware. >>>> >>> >>> Can I add platform specific changes on top of the displayed generic one >>> like in Documentation/devicetree/bindings/display/msm/dsi-phy-10nm.yaml >>> etc? >>> >>> The generic compatible is sufficienlty good for adding the enhanced >>> CSIPHY support to any currently present in the upstream platform CAMSS. >>> >>> Obviously I can rename it to something SoC-specific, but then a question >>> arises, if a selected platform has to be a totally new one in the upstream, >>> or it could be among any of platforms with a ready CAMSS, and a backward >>> compatibility is preserved by these series and the new CSIPHY dt bindings. >> >> A YAML file hosting common properties will probably be very welcome, but >> the compatibles must be specific to avoid having to redo this dance in >> a couple years.. > > Right, that's a good way for sure, and I keep this option in my mind. > > My concern is that it might be not a perfect fit particularly for CAMSS > CSIPHY IPs, because likely at least all currently supported in the upstream > CAMSS IPs will get one in one equal hardware descriptions, despite CSIPHY > IPs are obviously different. In other words I anticipate that there will > be just one platform prefixed YAML file with a long list of various platform > specific CSIPHYs, and therefore it's just one potential $ref user of this > hypothetical YAML file containing common device tree properties of CSIPHYs. One big YAML file may be okay too.. think: compatible: enum: - qcom,csiphy-v1.0.0 - qcom,csiphy-v1.2.0 - qcom,csiphy-v2.0.0 clocks: // if oneOf then that many clocks, else that many etc. etc. > >> Then, the camera ip is well-versioned, so you can use that as the 'specific' >> part. It'll also make it easier to resolve the unlikely case of a SoC using >> a mix of different PHY versions. >> > > Many thanks for input and reviews, regression test results of the given > CAMSS driver changes will be also very much appreciated, it may be helpful > for Bryan. I'm afraid I don't have any board which would be both unique and with working camera.. Konrad