Re: [PATCH v2 08/21] appended signatures: import GNUTLS's ASN.1 description files

[sudhakar <sudhakar@linux.ibm.com>]

Hi Daniel,

Thank you for your valuable review. addressed all the below review 
comments in v3.

Thanks,
Sudhakar Kuppusmay

On 2025-05-28 21:25, Daniel Kiper wrote:
> On Thu, Mar 27, 2025 at 01:02:29AM +0530, Sudhakar Kuppusamy wrote:
>> From: Daniel Axtens <dja@axtens.net>
>> 
>> In order to parse PKCS#7 messages and X.509 certificates with 
>> libtasn1,
>> we need some information about how they are encoded.
>> 
>> We get these from GNUTLS, which has the benefit that they support the
>> features we need and are well tested.
>> 
>> The GNUTLS files are from:
>> 
>> - 
>> https://github.com/gnutls/gnutls/blob/857543cc24114431dd5dde0e83c2c44b9b7e6050/lib/gnutls_asn1_tab.c
>> - 
>> https://github.com/gnutls/gnutls/blob/857543cc24114431dd5dde0e83c2c44b9b7e6050/lib/pkix_asn1_tab.c
> 
> Do we import latest versions?

imported latest version in v3

>> The GNUTLS license is LGPLv2.1+, which is GPLv3 compatible, allowing
>> us to import it without issue.
>> 
>> Signed-off-by: Daniel Axtens <dja@axtens.net>
>> Signed-off-by: Sudhakar Kuppusamy <sudhakar@linux.ibm.com>
>> Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
>> Reviewed-by: Avnish Chouhan <avnish@linux.ibm.com>
>> ---
>>  .../commands/appendedsig/gnutls_asn1_tab.c    | 121 +++++
>>  .../commands/appendedsig/pkix_asn1_tab.c      | 484 
>> ++++++++++++++++++
>>  2 files changed, 605 insertions(+)
>>  create mode 100644 grub-core/commands/appendedsig/gnutls_asn1_tab.c
>>  create mode 100644 grub-core/commands/appendedsig/pkix_asn1_tab.c
>> 
>> diff --git a/grub-core/commands/appendedsig/gnutls_asn1_tab.c 
>> b/grub-core/commands/appendedsig/gnutls_asn1_tab.c
>> new file mode 100644
>> index 000000000..ddd1314e6
>> --- /dev/null
>> +++ b/grub-core/commands/appendedsig/gnutls_asn1_tab.c
>> @@ -0,0 +1,121 @@
>> +#include <grub/mm.h>
>> +#include <grub/libtasn1.h>
>> +
>> +const asn1_static_node gnutls_asn1_tab[] = {
> 
> s/gnutls_asn1_tab/grub_gnutls_asn1_tab/g
> 
> [...]
> 
>> diff --git a/grub-core/commands/appendedsig/pkix_asn1_tab.c 
>> b/grub-core/commands/appendedsig/pkix_asn1_tab.c
>> new file mode 100644
>> index 000000000..adef69d95
>> --- /dev/null
>> +++ b/grub-core/commands/appendedsig/pkix_asn1_tab.c
>> @@ -0,0 +1,484 @@
>> +#include <grub/mm.h>
>> +#include <grub/libtasn1.h>
>> +
>> +const asn1_static_node pkix_asn1_tab[] = {
> 
> s/gnutls_asn1_tab/grub_pkix_asn1_tab/g
> 
> Daniel

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel