From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EE7DC2BB84 for ; Wed, 16 Sep 2020 09:48:23 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D84122243 for ; Wed, 16 Sep 2020 09:48:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D84122243 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kIU2a-0008Po-T9; Wed, 16 Sep 2020 09:47:52 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kIU2a-0008Pj-CX for xen-devel@lists.xenproject.org; Wed, 16 Sep 2020 09:47:52 +0000 X-Inumbo-ID: 46c93bec-3f31-4ea5-81d0-b6d9caf56388 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 46c93bec-3f31-4ea5-81d0-b6d9caf56388; Wed, 16 Sep 2020 09:47:51 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1B29BAED9; Wed, 16 Sep 2020 09:48:06 +0000 (UTC) Subject: Re: [PATCH v4 3/4] efi: Enable booting unified hypervisor/kernel/initrd images To: Trammell Hudson Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" , "andrew.cooper3@citrix.com" , "wl@xen.org" References: <20200914115013.814079-1-hudson@trmm.net> <20200914115013.814079-4-hudson@trmm.net> <20200916073209.GR753@Air-de-Roger> From: Jan Beulich Message-ID: Date: Wed, 16 Sep 2020 11:47:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 16.09.2020 10:37, Trammell Hudson wrote: > On Wednesday, September 16, 2020 3:32 AM, Roger Pau Monné wrote: >> On Mon, Sep 14, 2020 at 07:50:12AM -0400, Trammell Hudson wrote: >>> - s2w(&name_string); >> >> Don't you need to check that s2w succeed, so that name_string.w is not >> a random pointer from stack garbage? > > Maybe? I don't see anywhere else in the code that s2w() is > ever checked for a NULL return. Perhaps a better fix would > be to modify the function to panic if it is unable > to allocate. In current code the result of s2w() gets exclusively passed to read_file(), where first thing we have if ( !name ) PrintErrMesg(L"No filename", EFI_OUT_OF_RESOURCES); Jan