From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A0502D7BF for ; Wed, 27 Aug 2025 15:07:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756307226; cv=none; b=VR+IxxejqrJRL7dkwOJVA5NS3uD0PQH6ir5M9crdVShhobcbsAEZVI/czb6SuBDxFteKeMXcAh8/hBUIllAb6FNn4apQsMBOMmUd70YRbP9rCIp1R19ue3zd4bSWAbTmdrAoxkriw8o6H+HrZHiHfOPW2la4+gMGbogJbwyrjvA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756307226; c=relaxed/simple; bh=w+osgCjM+K0Nby+dea+urEvfhmOniFlhzFbofUF9giI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tcXOM6UYD+DMTy1Xu3JA3X1FgS+PoV7jnBKUDJzLtLsXxgXUVlJ1mFU23/Y0lWcQdrgOZdQfBR+Y4DLiC5YqJ8IRxt160R+YjPcgnzkPyuYEAk/BA0u7p/z0PH6BEoGlNAy2AkHA9tG3F78HK8L4UFgvg9fjVzOhgC1RWu17jOI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=L1sbG5+5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="L1sbG5+5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D53CEC4CEEB; Wed, 27 Aug 2025 15:07:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756307226; bh=w+osgCjM+K0Nby+dea+urEvfhmOniFlhzFbofUF9giI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=L1sbG5+5BFvgeLYmDYPdV40yuvejVw6N1uYb0k4nAp46KeEaa5EOF8t60ymeSEt2W Fq+wuNNiKQvwq2CSmsdF0qKH4qDpWLev5k6VVLbw+gqItTD/NxUCV1l8EjqBuek4XV B1ul2WKmjxtrW5euYYcN/ENPqTsn7P4ebwsQ7+CAxvfSdBMAtpWO0zcyqasBkVoYjQ E5Rur/nPju/103iBL72o7dq9EKORyxeOOg5fMt3iotgRDB+3Fvks2+B1gKWem0Djkp MzaWVR4ZP5QC7HPIzj35b37Eu4PA5wAtPEY02/1zpBh8pK1VxoWlAF51WfeGJdVvtB GfqDEkDL5tADg== Message-ID: Date: Wed, 27 Aug 2025 09:07:05 -0600 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 3/3] inet: ping: make ping_port_rover per netns Content-Language: en-US To: Eric Dumazet Cc: "David S . Miller" , Jakub Kicinski , Paolo Abeni , Simon Horman , netdev@vger.kernel.org, eric.dumazet@gmail.com References: <20250827120503.3299990-1-edumazet@google.com> <20250827120503.3299990-4-edumazet@google.com> <8f2d8a47-4531-4d3b-9a64-cf9477b7b41f@kernel.org> From: David Ahern In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 8/27/25 9:00 AM, Eric Dumazet wrote: > On Wed, Aug 27, 2025 at 7:57 AM David Ahern wrote: >> >> On 8/27/25 6:05 AM, Eric Dumazet wrote: >>> @@ -84,12 +82,12 @@ int ping_get_port(struct sock *sk, unsigned short ident) >>> isk = inet_sk(sk); >>> spin_lock(&ping_table.lock); >>> if (ident == 0) { >>> + u16 result = net->ipv4.ping_port_rover + 1; >>> u32 i; >>> - u16 result = ping_port_rover + 1; >>> >>> for (i = 0; i < (1L << 16); i++, result++) { >>> if (!result) >>> - result++; /* avoid zero */ >>> + continue; /* avoid zero */ >>> hlist = ping_hashslot(&ping_table, net, result); >>> sk_for_each(sk2, hlist) { >>> if (!net_eq(sock_net(sk2), net)) >>> @@ -101,7 +99,7 @@ int ping_get_port(struct sock *sk, unsigned short ident) >>> } >>> >>> /* found */ >>> - ping_port_rover = ident = result; >>> + net->ipv4.ping_port_rover = ident = result; >> >> READ_ONCE above and WRITE_ONCE here? > > Note we hold ping_table.lock for both the read and write, > so there is no need for READ_ONCE() or WRITE_ONCE() here. > > Thank you ! missed that. Reviewed-by: David Ahern