RE: [PATCH 3/3] wifi: ath12k: fix firmware crash during reo reinject

[Ping-Ke Shih <pkshih@realtek.com>]

Nicolas Escande <nico.escande@gmail.com> wrote:

[...]

> > -     reo_ent_ring->queue_addr_lo = reo_dest_ring->rx_mpdu_info.peer_meta_data;
> > -     reo_ent_ring->info0 = le32_encode_bits(dst_ind,
> > +     reo_ent_ring->queue_addr_lo = cpu_to_le32(lower_32_bits(rx_tid->paddr));
> > +     queue_addr_hi = upper_32_bits(rx_tid->paddr);
> Shouldn't there be a cpu_to_le32 somewhere here ? It just seems asymetrical
> between the two values extracted from rx_tid->paddr
> > +     reo_ent_ring->info0 = le32_encode_bits(queue_addr_hi,

le32_encode_bits() will convert queue_addr_hi from cpu-order to le-order.

> > +                                            HAL_REO_ENTR_RING_INFO0_QUEUE_ADDR_HI) |
> > +                           le32_encode_bits(dst_ind,
> >                                              HAL_REO_ENTR_RING_INFO0_DEST_IND);
> >
> >       reo_ent_ring->info1 = le32_encode_bits(rx_tid->cur_sn,
>