Re: [PATCH v3 3/4] serial: 8250: skip platform device registration with no runtime ports

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2309 bytes --]

On Fri, 28 Oct 2022, Ilpo Järvinen wrote:

> On Wed, 26 Oct 2022, Ilpo Järvinen wrote:
> 
> > On Tue, 25 Oct 2022, Martin Hundebøll wrote:
> > 
> > > Skip registration of the platform device used for built-in ports, if no
> > > such ports are configured/created.
> > > 
> > > Signed-off-by: Martin Hundebøll <martin@geanix.com>
> > 
> > For patches 1-3:
> > 
> > Tested-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> > Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> > 
> > Please include these tags into the next version of your submission.
> > Thank you.
> 
> Actually, I just found out that some set of cmdline parameters do no 
> longer work the same. So I'm retracting both of my tags for now.
> 
> =0 did work as expected due to this change which I tested and some other 
> values >4 but there now seems to be problem of the console not showing up 
> like previously when I don't give nr_uarts at all.

NAK from me until the problem is resolved adequately.

Already the patch 1/4 causes an unacceptable reassignment of ttySx 
targets. This is going to break people's cmdline console setups so you 
need to find a better way.

Before any of these patches:

[    0.000000] Command line: console=ttyS0,115200n8 8250.nr_uarts=4
[    0.021031] Kernel command line: console=ttyS0,115200n8 8250.nr_uarts=4
[    0.441924] printk: console [ttyS0] enabled
[    2.243165] printk: console [ttyS0] disabled
[    2.245682] dw-apb-uart.6: ttyS0 at MMIO 0x4010006000 (irq = 33, base_baud = 115200) is a 16550A
[    4.010237] printk: console [ttyS0] enabled
[    5.933887] dw-apb-uart.7: ttyS1 at MMIO 0x4010007000 (irq = 16, base_baud = 6250000) is a 16550A
[    5.952829] dw-apb-uart.8: ttyS2 at MMIO 0x4010008000 (irq = 17, base_baud = 6250000) is a 16550A

After 1/4 ttyS0 is no longer the same:

[    0.000000] Command line: console=ttyS0,115200n8 8250.nr_uarts=4
[    0.021023] Kernel command line: console=ttyS0,115200n8 8250.nr_uarts=4
[    0.441872] printk: console [ttyS0] enabled
[    2.233584] dw-apb-uart.6: ttyS4 at MMIO 0x4010006000 (irq = 33, base_baud = 115200) is a 16550A
[    2.241955] dw-apb-uart.7: ttyS5 at MMIO 0x4010007000 (irq = 16, base_baud = 6250000) is a 16550A
[    2.249804] dw-apb-uart.8: ttyS6 at MMIO 0x4010008000 (irq = 17, base_baud = 6250000) is a 16550A


-- 
 i.