From: David Lechner <dlechner@baylibre.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: stable@vger.kernel.org, stable-commits@vger.kernel.org,
"Michael Hennerich" <michael.hennerich@analog.com>,
"Nuno Sá" <nuno.sa@analog.com>, "Mark Brown" <broonie@kernel.org>
Subject: Re: Patch "spi: axi-spi-engine: Convert to platform remove callback returning void" has been added to the 6.1-stable tree
Date: Tue, 7 May 2024 09:22:48 -0500 [thread overview]
Message-ID: <d2857f45-caa6-4d69-989d-bb95dfcbc7ff@baylibre.com> (raw)
In-Reply-To: <xm5ghowrandbwib2osgihglhwief6buepdcht42uljj65apnya@qgshrnbi2s5r>
On 5/7/24 9:08 AM, Uwe Kleine-König wrote:
> Hello David,
>
> On Tue, May 07, 2024 at 08:59:16AM -0500, David Lechner wrote:
>> On 5/7/24 1:13 AM, Uwe Kleine-König wrote:
>>> On Mon, May 06, 2024 at 03:43:47PM -0500, David Lechner wrote:
>>>> Does not meet the criteria for stable.
>>>
>>> It was identified as a dependency of another patch. But I agree to
>>> David, it should be trivial to back this patch out. If you need help,
>>> please tell me.
>>>
>>
>> The "fix" patch isn't something that should be backported to stable
>> either, so we shouldn't need to do anything here other than drop
>> the whole series from the stable queue.
>
> Maybe it's just me, but for me backporting commit 0064db9ce4aa ("spi:
> axi-spi-engine: fix version format string") looks sensible. (Or what do
> you mean with "the \"fix\" patch"?) It's a small fix for a small
> annoyance, but looks harmless enough that I'd tend to include it in
> stable.
>
It's just fixing a theoretical problem, not one that has actually
caused problems for people. The stable guidelines I read [1] said we
shouldn't include fixes like that.
[1]: https://docs.kernel.org/process/stable-kernel-rules.html
So, sure it would probably be harmless to include it without the
other dependencies. But not sure it is worth the effort for only
a theoretical problem.
next prev parent reply other threads:[~2024-05-07 14:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240506193007.271745-1-sashal@kernel.org>
2024-05-06 20:43 ` Patch "spi: axi-spi-engine: Convert to platform remove callback returning void" has been added to the 6.1-stable tree David Lechner
2024-05-07 6:13 ` Uwe Kleine-König
2024-05-07 13:59 ` David Lechner
2024-05-07 14:08 ` Uwe Kleine-König
2024-05-07 14:22 ` David Lechner [this message]
2024-05-07 14:39 ` Mark Brown
2024-05-13 13:07 ` Greg KH
2024-05-13 14:44 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2857f45-caa6-4d69-989d-bb95dfcbc7ff@baylibre.com \
--to=dlechner@baylibre.com \
--cc=broonie@kernel.org \
--cc=michael.hennerich@analog.com \
--cc=nuno.sa@analog.com \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.