From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>,
davem@davemloft.net, netdev@vger.kernel.org
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH v3 net 4/4] wireguard: socket: remove extra call to synchronize_net
Date: Fri, 14 Feb 2020 15:21:59 -0800 [thread overview]
Message-ID: <d29e7d7e-5e60-9790-4851-eaf7bc14a58c@gmail.com> (raw)
In-Reply-To: <20200214225723.63646-5-Jason@zx2c4.com>
On 2/14/20 2:57 PM, Jason A. Donenfeld wrote:
> synchronize_net() is a wrapper around synchronize_rcu(), so there's no
> point in having synchronize_net and synchronize_rcu back to back,
> despite the documentation comment suggesting maybe it's somewhat useful,
> "Wait for packets currently being received to be done." This commit
> removes the extra call.
>
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> Suggested-by: Eric Dumazet <eric.dumazet@gmail.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Thanks !
next prev parent reply other threads:[~2020-02-14 23:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 22:57 [PATCH v3 net 0/4] wireguard fixes for 5.6-rc2 Jason A. Donenfeld
2020-02-14 22:57 ` [PATCH v3 net 1/4] wireguard: selftests: reduce complexity and fix make races Jason A. Donenfeld
2020-02-14 22:57 ` [PATCH v3 net 2/4] wireguard: receive: reset last_under_load to zero Jason A. Donenfeld
2020-02-14 22:57 ` [PATCH v3 net 3/4] wireguard: send: account for mtu=0 devices Jason A. Donenfeld
2020-02-14 23:21 ` Eric Dumazet
2020-02-14 22:57 ` [PATCH v3 net 4/4] wireguard: socket: remove extra call to synchronize_net Jason A. Donenfeld
2020-02-14 23:21 ` Eric Dumazet [this message]
2020-02-17 3:22 ` [PATCH v3 net 0/4] wireguard fixes for 5.6-rc2 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d29e7d7e-5e60-9790-4851-eaf7bc14a58c@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=Jason@zx2c4.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.