All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hansg@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Pratap Nirujogi <pratap.nirujogi@amd.com>,
	Benjamin Chan <benjamin.chan@amd.com>
Cc: "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"open list:AMD HETERO CORE HARDWARE FEEDBACK DRIVER"
	<platform-driver-x86@vger.kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: Re: linux-next: Tree for May 27 (drivers/platform/x86/amd/amd_isp4.c)
Date: Tue, 27 May 2025 21:43:59 +0200	[thread overview]
Message-ID: <d2ac901b-f7d2-46e6-b977-0ad90faa46f2@kernel.org> (raw)
In-Reply-To: <04577a46-9add-420c-b181-29bad582026d@infradead.org>

Hi,

On 27-May-25 8:56 PM, Randy Dunlap wrote:
> 
> 
> On 5/27/25 3:32 AM, Stephen Rothwell wrote:
>> Hi all,
>>
>> Changes since 20250526:
>>
> 
> on x86_64, when
> # CONFIG_MODULES is not set
> 
> ../drivers/platform/x86/amd/amd_isp4.c: In function 'is_isp_i2c_adapter':
> ../drivers/platform/x86/amd/amd_isp4.c:154:35: error: invalid use of undefined type 'struct module'
>   154 |         return !strcmp(adap->owner->name, "i2c_designware_amdisp");
>       |                                   ^~

Hmm, this should not check the owner->name at all.

Instead the i2c_designware_amdisp should set adap->name to something
unique and then this should check adap->name.

Regards,

Hans




  reply	other threads:[~2025-05-27 19:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-27 10:32 linux-next: Tree for May 27 Stephen Rothwell
2025-05-27 18:56 ` linux-next: Tree for May 27 (drivers/platform/x86/amd/amd_isp4.c) Randy Dunlap
2025-05-27 19:43   ` Hans de Goede [this message]
2025-05-27 20:24     ` Nirujogi, Pratap
2025-05-30  7:41       ` Ilpo Järvinen
2025-05-30  7:44         ` Hans de Goede
2025-05-30 15:21           ` Nirujogi, Pratap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d2ac901b-f7d2-46e6-b977-0ad90faa46f2@kernel.org \
    --to=hansg@kernel.org \
    --cc=benjamin.chan@amd.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=pratap.nirujogi@amd.com \
    --cc=rdunlap@infradead.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.