From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0BCA6C43334 for ; Wed, 13 Jul 2022 12:56:25 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 242A583C91; Wed, 13 Jul 2022 14:56:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="YOy3i5fD"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B39E783A25; Wed, 13 Jul 2022 14:56:20 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2047.outbound.protection.outlook.com [40.107.244.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 96C7383E13 for ; Wed, 13 Jul 2022 14:56:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=michal.simek@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FgZrL0jBkBKcx62lBWEdW50BkFGZDhjeeNAy/f74NSpaLsFyd0AU12ROz4YcERJCbyv9kzj7EjB2tMOgM3JX3CEluXbqFlEtodBPrEzPf2PrU2jJpm/+q0w1y2Sl2Cr3u93BFz0tCOy+PAjWvlXznhOE2PJuU19hTCYvb9WJUU3eaTFpstIIt0T4POb6wJjXoEI4Vaa66pfQzDiU0n6XzIifxjjLZE4mN5BuMaJhH/6xf3xzZCM3YQ6aM4rsaUkBQmsjkTgeIwk5cPj7cxtv+LhsSu7ScaX9M08codZSZ6Bi9zKNHk5zAwE98G1E9n8upLt0SHj3WeLReknDIlVB5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eYWWCpLKW1vmq3cYzWfZLi5MJNJBQQBVRKTLkPiPpxI=; b=Jd7F4GqpFrGwYLtLDJG0Oucm/aOJ+ezyU7IHdyWvkuxfaCeg70kxEFOpI1XklAUhQYVYjGdn4wuK0HTV32O+zKIrDjzq738n0W/+WzXXgNo95B7UP9fkZwErGfNf9IhpEObx0Wbn+lkDHgMm21dKGfGNnpTokbeglnmyKRcpQWTBh2Ukkm47vOQYr6rKmrnT0Joj35zqzXlxA1aXPj3mrbxGHfmf9ypU5sxV/DXLm8z21smY+u/9sKBxGsbMu7pQ3JwHJK/zDTribU0t1HSrSdPQxu/0jnbygFID6U+r/t1mqL8oxA7V/o0Pq3/UbI60FdDLQmYD9eMhd9sYNWDdLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lespocky.de smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eYWWCpLKW1vmq3cYzWfZLi5MJNJBQQBVRKTLkPiPpxI=; b=YOy3i5fDxplAu0Mmu9XXeb1fPXZRblyWMlZvowrrd2vClkfY2qfgxdFo8fVOVMlg1+E+K+k9i7Q8fWLTM1lxj/aHOSivP+zwGsUiKNBNcnPx4mEV5mKRh/Kq7C/EhwWefTdz86T+IJi2TOjN6UYlk234jq1/ulefezdSZZrayWg= Received: from BN0PR04CA0174.namprd04.prod.outlook.com (2603:10b6:408:eb::29) by DM6PR12MB4219.namprd12.prod.outlook.com (2603:10b6:5:217::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Wed, 13 Jul 2022 12:56:13 +0000 Received: from BN8NAM11FT066.eop-nam11.prod.protection.outlook.com (2603:10b6:408:eb:cafe::57) by BN0PR04CA0174.outlook.office365.com (2603:10b6:408:eb::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16 via Frontend Transport; Wed, 13 Jul 2022 12:56:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT066.mail.protection.outlook.com (10.13.177.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5438.12 via Frontend Transport; Wed, 13 Jul 2022 12:56:12 +0000 Received: from [10.254.241.52] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 13 Jul 2022 07:56:10 -0500 Message-ID: Date: Wed, 13 Jul 2022 14:56:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 1/2] fpga: Convert SYS_FPGA_CHECK_CTRLC to Kconfig Content-Language: en-US To: Alexander Dahl , CC: Alexander Dahl , Simon Glass , Stefan Roese References: <20220713123307.21314-1-post@lespocky.de> <20220713123307.21314-2-post@lespocky.de> From: Michal Simek In-Reply-To: <20220713123307.21314-2-post@lespocky.de> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4e5360ca-abbc-410c-cc1d-08da64cf10ca X-MS-TrafficTypeDiagnostic: DM6PR12MB4219:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sxPnxvRmuvbUtFEWGlgVJ2YXQjS1PbNflaFmUnNce+5sMAfxNc0rLxLvI/VgaFLHQ+YV6lkO5n6eMKLjJUGAZRWKTzZjQkCew7Yn+qga34FFl/ymJA41yoFhvVCGwJjWQ+OPZbne017nIvAgcBeJCyAQosuSdulc+6SdRIms+3SvPPnW09O2vSdXLUwyDrBCa6GN4aE1Y7x41+S+BqwgHNMAUOZAWGq27T8bPIsr/DujEYtKP91z51TmhXA7sgy+wFxOblKSJuINSQI8ClfcNE7yCgF90u2nBQDBBw2nwUe0VCqhyWj+wwFJ4fH9e9dXzqnFNTCdp6OPuGFR0GzBz+zMGsn7vnU7sO04cPHqm0XmVgBRet55n/PQ5KPDTmW0Jg7K/GDYOYOcu8MdLuxBXu5lwU5aeZ2jcKm9P/MMHSyEpJ9LQ8PvYMLR8DpSw82KCSOxWZSEfCLAwl+GSsDW9okrnxOHaG5obrKSEksfyccCysiHmeLJ8JJNUeQmeg8E71+CQVhpMvvMzh7eRstAxXhcuSWVhXPIQNDGKGCZicmPj5/x2BQEij8U5EsqcbsWA8FE1WaErUp0AS0EwqK7hYXLYsQ6v8K6htCVSQQZzjpnVrUuks7pdTWxH99aTKymoLjTtJA9Scim/OT+4edwAWw9sysT2GIpNmm9SHa33UkeV10fkhbKwiaf4Zby9g0dy0ngC8nFyMxhP1LUFwZsDJuHdb+gAAtLmilEPKms0+Q52NP6iCFRMzAyysI4HDzexnIp7nLzmJ3RMqNCnf69H6TxhhZTXU4ssuOJZfOQnky1PLbVUdD+7UyZHafLg/uny8UGhDM5AhGoKZ8kHEzF6pdxTBnkHgdljQTmmB8S4jVw3se17Q3S25TvN2y1mFiA X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230016)(4636009)(39860400002)(346002)(376002)(396003)(136003)(36840700001)(46966006)(40470700004)(5660300002)(110136005)(336012)(44832011)(2906002)(47076005)(36756003)(40480700001)(426003)(316002)(82310400005)(86362001)(8936002)(31686004)(40460700003)(31696002)(54906003)(81166007)(478600001)(186003)(36860700001)(53546011)(82740400003)(4326008)(70206006)(70586007)(356005)(26005)(83380400001)(41300700001)(2616005)(16526019)(8676002)(16576012)(43740500002)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 12:56:12.8455 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4e5360ca-abbc-410c-cc1d-08da64cf10ca X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT066.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4219 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 7/13/22 14:32, Alexander Dahl wrote: > From: Alexander Dahl > > After commit 8cca60a2cbf2 ("Kconfig: Remove some symbols from the > whitelist") downstream builds failed for boards setting this in > include/configs/… > > Two FPGA drivers consider this definition. 2? board/astro/mcf5373l/fpga.c drivers/fpga/ACEX1K.c drivers/fpga/virtex2.c > > Signed-off-by: Alexander Dahl > --- > README | 3 --- > drivers/fpga/Kconfig | 4 ++++ > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/README b/README > index ff0df3797d..8c31e5c0e3 100644 > --- a/README > +++ b/README > @@ -1346,9 +1346,6 @@ The following options need to be configured: > If defined, a function that provides delays in the FPGA > configuration driver. > > - CONFIG_SYS_FPGA_CHECK_CTRLC > - Allow Control-C to interrupt FPGA configuration > - > CONFIG_SYS_FPGA_CHECK_ERROR > > Check for configuration errors during FPGA bitfile > diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig > index 76719517f5..53d91676e0 100644 > --- a/drivers/fpga/Kconfig > +++ b/drivers/fpga/Kconfig > @@ -91,4 +91,8 @@ config FPGA_ZYNQPL > Enable FPGA driver for loading bitstream in BIT and BIN format > on Xilinx Zynq devices. > > +config SYS_FPGA_CHECK_CTRLC > + bool "Allow Control-C to interrupt FPGA configuration" > + depends on FPGA Please write help message. > + > endmenu And can you please remove this code from drivers/fpga/virtex2.c 48 /* 49 * Don't allow config cycle to be interrupted 50 */ 51 #ifndef CONFIG_SYS_FPGA_CHECK_CTRLC 52 #undef CONFIG_SYS_FPGA_CHECK_CTRLC 53 #endif it doesn't make any sense. And with 2/2 please also remove drivers/fpga/spartan2.c:18:#undef CONFIG_SYS_FPGA_PROG_FEEDBACK drivers/fpga/virtex2.c:44:#ifndef CONFIG_SYS_FPGA_PROG_FEEDBACK drivers/fpga/virtex2.c:45:#define CONFIG_SYS_FPGA_PROG_FEEDBACK Thanks, Michal