From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41F03C73C6D for ; Wed, 10 Jul 2019 06:59:50 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F1D2120651 for ; Wed, 10 Jul 2019 06:59:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QqJkLn2p" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F1D2120651 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58316 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hl6Zx-0006nT-2N for qemu-devel@archiver.kernel.org; Wed, 10 Jul 2019 02:59:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53331) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hl6ZD-0006EH-FF for qemu-devel@nongnu.org; Wed, 10 Jul 2019 02:59:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hl6ZB-0004bb-HG for qemu-devel@nongnu.org; Wed, 10 Jul 2019 02:59:03 -0400 Received: from mail-oi1-x243.google.com ([2607:f8b0:4864:20::243]:35418) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hl6Z7-0004Wb-W3 for qemu-devel@nongnu.org; Wed, 10 Jul 2019 02:58:59 -0400 Received: by mail-oi1-x243.google.com with SMTP id a127so816534oii.2 for ; Tue, 09 Jul 2019 23:58:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=XFC/MHhgEfE1Nr1X5gKwGHcvslnu2HFr4KUXcEkFuLU=; b=QqJkLn2penLobTO8LA6zYjoP4hvpb/K40qkWaKw+EfybH9ukfJ/tDJ1t9fC6IYlELi pk4uBFy7a7UWU433quQrvwkXrckU6QGaO/YRh5NOO0Vh6e7Lm9ENePq+yJYMZ32CfxpT WvdUXe2bPJN3GHA5kx20uD125/yucMjDr6GBiDyUfs3HcOPZdKdEkETph5YwPeXfhAt3 yP894fa7ByRpdi9J0SD+xNHqNCiS/SYaPSIiZpbBjLCtpoECjfmJt0GgKyUjI0i0uP1P nsm9v86iVOIBrdimJa9p6o50cvZb+SLuGDfccpx9gHl2l1ckKRL78OnUQn/rY4iERcKK t0NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XFC/MHhgEfE1Nr1X5gKwGHcvslnu2HFr4KUXcEkFuLU=; b=sycoMeeTD25E92JRZFWmyUWI79PCsHRCgomVA3uDrVyEQxNLzlrSYa/p86TCW7moO/ xHQiP/36+mFELZHipxd/ZWRtTnywXY0x7YIcUIpfAqBJj5XhUG7wrsI/Eh0+KYYyS7wZ N98PT9GFxDk9SEZOlEIKpjNPjUXB3czAqUBdbeBK+a5/dqdwH6xVTlnNitgTY7bGR1h3 2IkNa3U3+9HS1K5oJOZDtOC9Oh2bEhk7t0iJugsAIsRM+T2Q44ecckAuCQMxrunrVd/3 uJf+9jkYCvyu/tos5BpoM51gxmANfh8T7VuoWTdpk+WB2Agi0QnUv/5poNZ+HlCki3AO t6qA== X-Gm-Message-State: APjAAAUkPJuxdFDI21DzbtnTwn0P8es525Kt2dDN7RpFlFLxz/06knb1 gho+aJvkk6a6nZg9Xt8wqY2Z+g== X-Google-Smtp-Source: APXvYqyiWlvXOn9WgM02ds8lR8EvTJyN55e/d9sXN8XZrp+GAUg5yX9LVJptk09Z85aIfligIKaO4g== X-Received: by 2002:aca:5246:: with SMTP id g67mr2224940oib.116.1562741934515; Tue, 09 Jul 2019 23:58:54 -0700 (PDT) Received: from [192.168.43.94] ([172.56.7.82]) by smtp.gmail.com with ESMTPSA id v22sm571659oth.19.2019.07.09.23.58.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Jul 2019 23:58:53 -0700 (PDT) To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-devel@nongnu.org References: <20190705160421.19015-1-alex.bennee@linaro.org> <20190705160421.19015-3-alex.bennee@linaro.org> From: Richard Henderson Openpgp: preference=signencrypt Message-ID: Date: Wed, 10 Jul 2019 08:58:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: <20190705160421.19015-3-alex.bennee@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::243 Subject: Re: [Qemu-devel] [PATCH v1 2/5] tests/tcg: fix up test-i386-fprem.ref generation X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , qemu-arm@nongnu.org, Jan Bobek , Eduardo Habkost , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 7/5/19 6:04 PM, Alex Bennée wrote: > We never shipped the reference data in the source tree because it was > quite big (64M). As a result the only option is to generate it > locally. Although we have a rule to generate the reference file we > missed the dependency and location changes, probably because it is > only run for SLOW test runs. > > The test still fails with mostly incorrect flags and different than > expected NaNs. I'll leave that for the x86 experts to look at. > > Signed-off-by: Alex Bennée > Cc: Paolo Bonzini > Cc: Richard Henderson > Cc: Eduardo Habkost > Cc: Jan Bobek > --- > tests/tcg/i386/Makefile.target | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) There's nothing here to guess that test-i386-fprem is in any way natively runnable. Otherwise you might just end up testing against the installed qemu. On the other hand, at the moment this simply won't run at all, since the input file is missing. So I suppose this is good enough for SLOW. Reviewed-by: Richard Henderson r~ From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:adf:a557:0:0:0:0:0 with SMTP id j23csp4575605wrb; Tue, 9 Jul 2019 23:58:55 -0700 (PDT) X-Received: by 2002:aca:e046:: with SMTP id x67mr2381299oig.3.1562741935033; Tue, 09 Jul 2019 23:58:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562741935; cv=none; d=google.com; s=arc-20160816; b=SN9e4vQKTJwISBinRa8Gqx3JVccZ/6HuS3qFRBq8Yb7onZiMU/CzOECOB6G1WrUr1v e3RA6hTjFj6OEqfSCgKitx9qyLqe1GQc98Mnkl8lTDGNhdcP1jNKFvZWkJQp5XLsm2el yPIygVdxdI9ez8yegmYbEfYZpJxaewhwj4zUbiUwLHB1Xnz5CEtdxWdeVR0U0ZRs7vbh w/MZjESCzkniMyemC+mBzXKUfMAc8DbURQDxDrK6UDlh70AkFhtF43GpzSIbhagA3wx3 bkryMaXpn26ArmNV3kfVA1gerqu0dI4RDD0EWB7ruTEwgAhjAZq6HoJNcR1LSyCniQlQ XzoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:openpgp:from:references:cc:to:subject :dkim-signature; bh=XFC/MHhgEfE1Nr1X5gKwGHcvslnu2HFr4KUXcEkFuLU=; b=pWZy+nhmAAswlGEoeGXL1Hr0fVqpb071xLV3QLXVEs/N68rJt/rhYnjyUvQ94bZXwU oUcAVqnuqL2Lgc0Pl3t6xIJhMgmf/XLD3fXmRHm/wzGlBK8vYc5THuJDgOAuGsRv08QD YIK+ZPHpSWb21AF8kQa0URdKJvjaqb8Jn/kCktu15TIKtqDU6sJpkkQ9YvAx7U77qzjd 4nfKp7YDrqQQFCvPrul6QWOI0D+CYt7geZNHbKwb5N4NOQ8+lt12Yp6Sr+wYv3FkZlpo Xo7Yp2tUYEfX7Qu7kZbNEZvl6N89et/vJBJgzrSYTgmtqhE//zDfAIFVBp9xpXGp7dQd 0tMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QqJkLn2p; spf=pass (google.com: domain of richard.henderson@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=richard.henderson@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id u4sor559242oic.49.2019.07.09.23.58.54 for (Google Transport Security); Tue, 09 Jul 2019 23:58:54 -0700 (PDT) Received-SPF: pass (google.com: domain of richard.henderson@linaro.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QqJkLn2p; spf=pass (google.com: domain of richard.henderson@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=richard.henderson@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=XFC/MHhgEfE1Nr1X5gKwGHcvslnu2HFr4KUXcEkFuLU=; b=QqJkLn2penLobTO8LA6zYjoP4hvpb/K40qkWaKw+EfybH9ukfJ/tDJ1t9fC6IYlELi pk4uBFy7a7UWU433quQrvwkXrckU6QGaO/YRh5NOO0Vh6e7Lm9ENePq+yJYMZ32CfxpT WvdUXe2bPJN3GHA5kx20uD125/yucMjDr6GBiDyUfs3HcOPZdKdEkETph5YwPeXfhAt3 yP894fa7ByRpdi9J0SD+xNHqNCiS/SYaPSIiZpbBjLCtpoECjfmJt0GgKyUjI0i0uP1P nsm9v86iVOIBrdimJa9p6o50cvZb+SLuGDfccpx9gHl2l1ckKRL78OnUQn/rY4iERcKK t0NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XFC/MHhgEfE1Nr1X5gKwGHcvslnu2HFr4KUXcEkFuLU=; b=nS8IXV7G5BwC++cXKsf4htX6kCTvCQW1M9fq2f99WheX6FE7Y6qA+ab4gJQiHZPkms GtTlt1eqO/gfOS7UKlaAGG68vDaJpl9ryIFgelVLiC/kLcKH5WZ6gZJx1oJEkqV59VUW 0NX03xC3qXI5iz7vdQiOd1BhG3rQrKcvhMY8++SkQV2r2bUzJYc4QlNhIULcjVAqbLku DxdLBDeB3wf10hRXFi37ZLfAOo/GmMqVUJkOKUZxtGmNBA8nDkhakquooqEH4fgSIzjV O717bLqAQpeFThZ0Jht4/fZW7jB0ujv8RvBk8w9s9J/iUxp8viClGr/38zfmdwIagjmA RSJg== X-Gm-Message-State: APjAAAUU6ogGIrRfYvaTuoa1Ta44n35gTG9qz/9f7937S1Xc/2Xfxcnq ZWizdbRSttsD/bSFytyzNtWL6/bT X-Google-Smtp-Source: APXvYqyiWlvXOn9WgM02ds8lR8EvTJyN55e/d9sXN8XZrp+GAUg5yX9LVJptk09Z85aIfligIKaO4g== X-Received: by 2002:aca:5246:: with SMTP id g67mr2224940oib.116.1562741934515; Tue, 09 Jul 2019 23:58:54 -0700 (PDT) Return-Path: Received: from [192.168.43.94] ([172.56.7.82]) by smtp.gmail.com with ESMTPSA id v22sm571659oth.19.2019.07.09.23.58.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Jul 2019 23:58:53 -0700 (PDT) Subject: Re: [Qemu-devel] [PATCH v1 2/5] tests/tcg: fix up test-i386-fprem.ref generation To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-devel@nongnu.org Cc: Eduardo Habkost , qemu-arm@nongnu.org, Jan Bobek , Paolo Bonzini , Richard Henderson References: <20190705160421.19015-1-alex.bennee@linaro.org> <20190705160421.19015-3-alex.bennee@linaro.org> From: Richard Henderson Openpgp: preference=signencrypt Message-ID: Date: Wed, 10 Jul 2019 08:58:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: <20190705160421.19015-3-alex.bennee@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: zVwAXjjli6MW On 7/5/19 6:04 PM, Alex Bennée wrote: > We never shipped the reference data in the source tree because it was > quite big (64M). As a result the only option is to generate it > locally. Although we have a rule to generate the reference file we > missed the dependency and location changes, probably because it is > only run for SLOW test runs. > > The test still fails with mostly incorrect flags and different than > expected NaNs. I'll leave that for the x86 experts to look at. > > Signed-off-by: Alex Bennée > Cc: Paolo Bonzini > Cc: Richard Henderson > Cc: Eduardo Habkost > Cc: Jan Bobek > --- > tests/tcg/i386/Makefile.target | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) There's nothing here to guess that test-i386-fprem is in any way natively runnable. Otherwise you might just end up testing against the installed qemu. On the other hand, at the moment this simply won't run at all, since the input file is missing. So I suppose this is good enough for SLOW. Reviewed-by: Richard Henderson r~