From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1BB52563; Tue, 21 Nov 2023 16:53:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ra6Vhd55" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CE4CC433C7; Tue, 21 Nov 2023 16:53:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700585615; bh=dXMSeMNK+WEBDV6rnNty0bayoAnlHmRDxFemjBJL70E=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Ra6Vhd55uJUnkSGETGcDSGW77NyER+qrJBIyENP3uAPYGiRUemWipmmhMGJika2xK OTrvmNCYHM2k6oEaRQqR30ujYKgxmVSXp0Cygnya952ww30PVtxhv01Sgm5Meo06Zw DvXk7eEo7SnZEE+J1XCKENfBU3gUTJhVA1FG5bOkGbZasJKZ+8H8c1+dC1heCKtFhK A2fO2twFLiA+Fpf3daT6uxwCp+STjsR39x4g8T+1YcB/wTIIa5asKzcv6Y3/CuVoGX t/BumSB2tJTR85lpdGri4xW6sGKdpZYAVhXnqe6ufmYrjPMhBl2Q3okB/M4JShskYu I0dIeaL3sUNgg== Message-ID: Date: Tue, 21 Nov 2023 18:53:28 +0200 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 6/7] usb: cdns3-ti: signal reset-on-resume to xHCI for J7200 platform Content-Language: en-US To: =?UTF-8?Q?Th=C3=A9o_Lebrun?= , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Chen , Pawel Laszczak , Nishanth Menon , Vignesh Raghavendra , Tero Kristo Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, =?UTF-8?Q?Gr=C3=A9gory_Clement?= References: <20231120-j7200-usb-suspend-v2-0-038c7e4a3df4@bootlin.com> <20231120-j7200-usb-suspend-v2-6-038c7e4a3df4@bootlin.com> From: Roger Quadros In-Reply-To: <20231120-j7200-usb-suspend-v2-6-038c7e4a3df4@bootlin.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 20/11/2023 19:06, Théo Lebrun wrote: > Pass CDNS3_RESET_ON_RESUME as platform data to cdns3 host role. It will > in turn pass it down to xHCI platform data as XHCI_RESET_ON_RESUME. > > Avoid this warning on resume: > > [ 16.017462] xhci-hcd xhci-hcd.1.auto: xHC error in resume, USBSTS 0x401, Reinit > > When used, remote wakeup is not expected to work. > > Only focus J7200 as other SoC are untested. > > Signed-off-by: Théo Lebrun > --- > drivers/usb/cdns3/cdns3-ti.c | 19 +++++++++++++++++-- > 1 file changed, 17 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/cdns3/cdns3-ti.c b/drivers/usb/cdns3/cdns3-ti.c > index 84f93c2fcd5c..7d56a1acbc54 100644 > --- a/drivers/usb/cdns3/cdns3-ti.c > +++ b/drivers/usb/cdns3/cdns3-ti.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include "core.h" > > /* USB Wrapper register offsets */ > #define USBSS_PID 0x0 > @@ -128,6 +129,7 @@ static int cdns_ti_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > struct device_node *node = pdev->dev.of_node; > + const struct of_dev_auxdata *auxdata; > struct cdns_ti *data; > unsigned long rate; > int error, i; > @@ -177,7 +179,8 @@ static int cdns_ti_probe(struct platform_device *pdev) > > cdns_ti_init_hw(data); > > - error = of_platform_populate(node, NULL, NULL, dev); > + auxdata = of_device_get_match_data(dev); > + error = of_platform_populate(node, NULL, auxdata, dev); > if (error) { > dev_err(dev, "failed to create children: %d\n", error); > return error; > @@ -222,8 +225,20 @@ static const struct dev_pm_ops cdns_ti_pm_ops = { > > #endif /* CONFIG_PM */ > > +static struct cdns3_platform_data cdns_ti_j7200_pdata = { > + .quirks = CDNS3_RESET_ON_RESUME, > +}; We will need to introduce a new data structure "struct cdns_ti_platform_data" and add platform specific details like "reset_on_resume" to it. This is to address what Krzysztof pointed to in patch 4. > + > +static const struct of_dev_auxdata cdns_ti_j7200_auxdata[] = { > + { > + .compatible = "cdns,usb3", > + .platform_data = &cdns_ti_j7200_pdata, > + }, > + {}, > +}; > + > static const struct of_device_id cdns_ti_of_match[] = { > - { .compatible = "ti,j7200-usb", }, > + { .compatible = "ti,j7200-usb", .data = cdns_ti_j7200_auxdata, }, Here we should pass "struct cdns_ti_platform_data" > { .compatible = "ti,j721e-usb", }, > { .compatible = "ti,am64-usb", }, > {}, > -- cheers, -roger From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A22EC61D90 for ; Tue, 21 Nov 2023 16:54:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HrtOZ1VOsQ4qGGWiuiDmsufGNGFR8hr6kiYjCMuSHgc=; b=veEMGts/PXB6bV mA/+kAKeRhoZKpY6kXn7NXMkTDRnxBD587lPdmu14HuC9ZpRLbsN9FzCdAjm4cTpHDaNT7U69gM2w +r78BIiSsI2+2DAtuFtGzsXbYgixE/Ju/LP8gsYH1WYhg3BuGLVVV4UT3WbivJZMqL6XZ/YPDk5Ah CdkIsl+0tkgSR79EycPC+4sLbvdf3kAlwX2i2al3o+IeXFStp4siq/xPrpMM/lCd4ZNOrq6NlGJjS 4HwhA+uFFr7sx0W1ceVrcTfh4z9me1lhI6XObXGcxim20ehvJPa9KOaXz7b1KpzEJG43cbfUqZ5hL qbfHdGvAGIaD3rQWMnJA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r5U0I-00HKeS-1m; Tue, 21 Nov 2023 16:53:38 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r5U0G-00HKdm-1U for linux-arm-kernel@lists.infradead.org; Tue, 21 Nov 2023 16:53:37 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 76C3F61189; Tue, 21 Nov 2023 16:53:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CE4CC433C7; Tue, 21 Nov 2023 16:53:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700585615; bh=dXMSeMNK+WEBDV6rnNty0bayoAnlHmRDxFemjBJL70E=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Ra6Vhd55uJUnkSGETGcDSGW77NyER+qrJBIyENP3uAPYGiRUemWipmmhMGJika2xK OTrvmNCYHM2k6oEaRQqR30ujYKgxmVSXp0Cygnya952ww30PVtxhv01Sgm5Meo06Zw DvXk7eEo7SnZEE+J1XCKENfBU3gUTJhVA1FG5bOkGbZasJKZ+8H8c1+dC1heCKtFhK A2fO2twFLiA+Fpf3daT6uxwCp+STjsR39x4g8T+1YcB/wTIIa5asKzcv6Y3/CuVoGX t/BumSB2tJTR85lpdGri4xW6sGKdpZYAVhXnqe6ufmYrjPMhBl2Q3okB/M4JShskYu I0dIeaL3sUNgg== Message-ID: Date: Tue, 21 Nov 2023 18:53:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 6/7] usb: cdns3-ti: signal reset-on-resume to xHCI for J7200 platform Content-Language: en-US To: =?UTF-8?Q?Th=C3=A9o_Lebrun?= , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Chen , Pawel Laszczak , Nishanth Menon , Vignesh Raghavendra , Tero Kristo Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, =?UTF-8?Q?Gr=C3=A9gory_Clement?= References: <20231120-j7200-usb-suspend-v2-0-038c7e4a3df4@bootlin.com> <20231120-j7200-usb-suspend-v2-6-038c7e4a3df4@bootlin.com> From: Roger Quadros In-Reply-To: <20231120-j7200-usb-suspend-v2-6-038c7e4a3df4@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231121_085336_585737_E4A2402E X-CRM114-Status: GOOD ( 22.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAyMC8xMS8yMDIzIDE5OjA2LCBUaMOpbyBMZWJydW4gd3JvdGU6Cj4gUGFzcyBDRE5TM19S RVNFVF9PTl9SRVNVTUUgYXMgcGxhdGZvcm0gZGF0YSB0byBjZG5zMyBob3N0IHJvbGUuIEl0IHdp bGwKPiBpbiB0dXJuIHBhc3MgaXQgZG93biB0byB4SENJIHBsYXRmb3JtIGRhdGEgYXMgWEhDSV9S RVNFVF9PTl9SRVNVTUUuCj4gCj4gQXZvaWQgdGhpcyB3YXJuaW5nIG9uIHJlc3VtZToKPiAKPiAg IFsgICAxNi4wMTc0NjJdIHhoY2ktaGNkIHhoY2ktaGNkLjEuYXV0bzogeEhDIGVycm9yIGluIHJl c3VtZSwgVVNCU1RTIDB4NDAxLCBSZWluaXQKPiAKPiBXaGVuIHVzZWQsIHJlbW90ZSB3YWtldXAg aXMgbm90IGV4cGVjdGVkIHRvIHdvcmsuCj4gCj4gT25seSBmb2N1cyBKNzIwMCBhcyBvdGhlciBT b0MgYXJlIHVudGVzdGVkLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFRow6lvIExlYnJ1biA8dGhlby5s ZWJydW5AYm9vdGxpbi5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvdXNiL2NkbnMzL2NkbnMzLXRpLmMg fCAxOSArKysrKysrKysrKysrKysrKy0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxNyBpbnNlcnRpb25z KCspLCAyIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3VzYi9jZG5zMy9j ZG5zMy10aS5jIGIvZHJpdmVycy91c2IvY2RuczMvY2RuczMtdGkuYwo+IGluZGV4IDg0ZjkzYzJm Y2Q1Yy4uN2Q1NmExYWNiYzU0IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvdXNiL2NkbnMzL2NkbnMz LXRpLmMKPiArKysgYi9kcml2ZXJzL3VzYi9jZG5zMy9jZG5zMy10aS5jCj4gQEAgLTE2LDYgKzE2 LDcgQEAKPiAgI2luY2x1ZGUgPGxpbnV4L29mX3BsYXRmb3JtLmg+Cj4gICNpbmNsdWRlIDxsaW51 eC9wbV9ydW50aW1lLmg+Cj4gICNpbmNsdWRlIDxsaW51eC9wcm9wZXJ0eS5oPgo+ICsjaW5jbHVk ZSAiY29yZS5oIgo+ICAKPiAgLyogVVNCIFdyYXBwZXIgcmVnaXN0ZXIgb2Zmc2V0cyAqLwo+ICAj ZGVmaW5lIFVTQlNTX1BJRAkJMHgwCj4gQEAgLTEyOCw2ICsxMjksNyBAQCBzdGF0aWMgaW50IGNk bnNfdGlfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAgewo+ICAJc3RydWN0 IGRldmljZSAqZGV2ID0gJnBkZXYtPmRldjsKPiAgCXN0cnVjdCBkZXZpY2Vfbm9kZSAqbm9kZSA9 IHBkZXYtPmRldi5vZl9ub2RlOwo+ICsJY29uc3Qgc3RydWN0IG9mX2Rldl9hdXhkYXRhICphdXhk YXRhOwo+ICAJc3RydWN0IGNkbnNfdGkgKmRhdGE7Cj4gIAl1bnNpZ25lZCBsb25nIHJhdGU7Cj4g IAlpbnQgZXJyb3IsIGk7Cj4gQEAgLTE3Nyw3ICsxNzksOCBAQCBzdGF0aWMgaW50IGNkbnNfdGlf cHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAgCj4gIAljZG5zX3RpX2luaXRf aHcoZGF0YSk7Cj4gIAo+IC0JZXJyb3IgPSBvZl9wbGF0Zm9ybV9wb3B1bGF0ZShub2RlLCBOVUxM LCBOVUxMLCBkZXYpOwo+ICsJYXV4ZGF0YSA9IG9mX2RldmljZV9nZXRfbWF0Y2hfZGF0YShkZXYp Owo+ICsJZXJyb3IgPSBvZl9wbGF0Zm9ybV9wb3B1bGF0ZShub2RlLCBOVUxMLCBhdXhkYXRhLCBk ZXYpOwo+ICAJaWYgKGVycm9yKSB7Cj4gIAkJZGV2X2VycihkZXYsICJmYWlsZWQgdG8gY3JlYXRl IGNoaWxkcmVuOiAlZFxuIiwgZXJyb3IpOwo+ICAJCXJldHVybiBlcnJvcjsKPiBAQCAtMjIyLDgg KzIyNSwyMCBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGRldl9wbV9vcHMgY2Ruc190aV9wbV9vcHMg PSB7Cj4gIAo+ICAjZW5kaWYgLyogQ09ORklHX1BNICovCj4gIAo+ICtzdGF0aWMgc3RydWN0IGNk bnMzX3BsYXRmb3JtX2RhdGEgY2Ruc190aV9qNzIwMF9wZGF0YSA9IHsKPiArCS5xdWlya3MgPSBD RE5TM19SRVNFVF9PTl9SRVNVTUUsCj4gK307CgpXZSB3aWxsIG5lZWQgdG8gaW50cm9kdWNlIGEg bmV3IGRhdGEgc3RydWN0dXJlICJzdHJ1Y3QgY2Ruc190aV9wbGF0Zm9ybV9kYXRhIgphbmQgYWRk IHBsYXRmb3JtIHNwZWNpZmljIGRldGFpbHMgbGlrZSAicmVzZXRfb25fcmVzdW1lIiB0byBpdC4K VGhpcyBpcyB0byBhZGRyZXNzIHdoYXQgS3J6eXN6dG9mIHBvaW50ZWQgdG8gaW4gcGF0Y2ggNC4K Cj4gKwo+ICtzdGF0aWMgY29uc3Qgc3RydWN0IG9mX2Rldl9hdXhkYXRhIGNkbnNfdGlfajcyMDBf YXV4ZGF0YVtdID0gewo+ICsJewo+ICsJCS5jb21wYXRpYmxlID0gImNkbnMsdXNiMyIsCj4gKwkJ LnBsYXRmb3JtX2RhdGEgPSAmY2Ruc190aV9qNzIwMF9wZGF0YSwKPiArCX0sCj4gKwl7fSwKPiAr fTsKPiArCj4gIHN0YXRpYyBjb25zdCBzdHJ1Y3Qgb2ZfZGV2aWNlX2lkIGNkbnNfdGlfb2ZfbWF0 Y2hbXSA9IHsKPiAtCXsgLmNvbXBhdGlibGUgPSAidGksajcyMDAtdXNiIiwgfSwKPiArCXsgLmNv bXBhdGlibGUgPSAidGksajcyMDAtdXNiIiwgLmRhdGEgPSBjZG5zX3RpX2o3MjAwX2F1eGRhdGEs IH0sCgpIZXJlIHdlIHNob3VsZCBwYXNzICJzdHJ1Y3QgY2Ruc190aV9wbGF0Zm9ybV9kYXRhIgoK PiAgCXsgLmNvbXBhdGlibGUgPSAidGksajcyMWUtdXNiIiwgfSwKPiAgCXsgLmNvbXBhdGlibGUg PSAidGksYW02NC11c2IiLCB9LAo+ICAJe30sCj4gCgotLSAKY2hlZXJzLAotcm9nZXIKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJu ZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRw Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK