From: Tejun Heo <tj@kernel.org>
To: cuitao <cuitao@kylinos.cn>
Cc: mkoutny@suse.com, cgroups@vger.kernel.org, hannes@cmpxchg.org
Subject: Re: [PATCH v2] cgroup/rdma: refactor resource parsing with match_table_t/match_token()
Date: Tue, 21 Apr 2026 06:42:34 -1000 [thread overview]
Message-ID: <d2d00a690c69213cad3d469f0ef478a9@kernel.org> (raw)
In-Reply-To: <20260420045233.116375-1-cuitao@kylinos.cn>
Hello,
A few things for a respin:
- Can you use your real name in the Signed-off-by? Something like
"Firstname Lastname <email>" rather than the account handle.
- The patch also drops this comment in rdmacg_resource_set_max():
/*
* No user of the rpool and all entries are set to max, so
* safe to delete this rpool.
*/
That's unrelated to the parser refactor. Please keep it, or split
it out as a separate cleanup patch.
- The old strncmp(value, RDMACG_MAX_STR, strlen(value)) also silently
accepted "hca_handle=" (empty value) as "max" because strncmp with
n=0 always returns 0. v2 fixes this too - worth mentioning in the
changelog alongside the "ma" case.
Thanks.
--
tejun
next prev parent reply other threads:[~2026-04-21 16:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-14 2:09 [PATCH] cgroup/rdma: fix strncmp prefix match in parse_resource() cuitao
2026-04-15 13:37 ` Michal Koutný
2026-04-17 6:43 ` 崔涛
2026-04-17 9:53 ` Michal Koutný
2026-04-20 1:08 ` Tao Cui
2026-04-20 4:52 ` [PATCH v2] cgroup/rdma: refactor resource parsing with match_table_t/match_token() cuitao
2026-04-21 16:42 ` Tejun Heo [this message]
2026-04-22 2:17 ` [PATCH v3] " Tao Cui
2026-04-22 17:25 ` Tejun Heo
2026-04-23 17:10 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2d00a690c69213cad3d469f0ef478a9@kernel.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=cuitao@kylinos.cn \
--cc=hannes@cmpxchg.org \
--cc=mkoutny@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.