From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Avi Weiss <thnkslprpt@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Lorenzo Stoakes <ljs@kernel.org>,
"Liam R . Howlett" <liam@infradead.org>,
Vlastimil Babka <vbabka@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/2] mm/memory: improve insert_pages() error handling
Date: Thu, 10 Sep 2026 12:06:17 +0200 [thread overview]
Message-ID: <d2f4e7fd-b077-4150-8b2f-e81435d04408@kernel.org> (raw)
In-Reply-To: <cover.1788022178.git.thnkslprpt@gmail.com>
On 8/29/26 19:11, Avi Weiss wrote:
> Improve insert_pages() error handling.
>
> The first patch simplifies error handling by initializing the error
> status to zero and assigning error codes at their respective failure
> sites.
>
> The second patch returns -ENOMEM when walk_to_pmd() fails. A NULL
> return from walk_to_pmd() indicates failure to allocate an upper
> page-table level, so -ENOMEM is more appropriate than -EFAULT and is
> consistent with the subsequent pte_alloc() failure.
>
> Changes in v3:
>
> * drop the walk_to_pmd() rename following review
> * use the mm/memory: prefix consistently across the series
> * carry review tags from v2
> * rebase onto current mm-new
Double-checked, LGTM.
--
Cheers,
David
prev parent reply other threads:[~2026-09-10 10:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-29 17:11 [PATCH v3 0/2] mm/memory: improve insert_pages() error handling Avi Weiss
2026-08-29 17:11 ` [PATCH v3 1/2] mm/memory: simplify error handling in insert_pages() Avi Weiss
2026-09-10 15:33 ` Lorenzo Stoakes (ARM)
2026-08-29 17:11 ` [PATCH v3 2/2] mm/memory: return -ENOMEM for page-table allocation failure " Avi Weiss
2026-09-10 10:06 ` David Hildenbrand (Arm) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2f4e7fd-b077-4150-8b2f-e81435d04408@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=thnkslprpt@gmail.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.