Re: [PATCH v2 4/7] mm/mglru: exclude folios promoted by aging from protected in inc_min_seq()

[Ridong Chen <ridong.chen@linux.dev>]

On 8/28/2026 7:47 AM, Barry Song (Xiaomi) wrote:
> Some folios may have been promoted during aging, so don't count them
> as protected, similar to sort_folio().
> 
> Signed-off-by: Barry Song (Xiaomi) <baohua@kernel.org>
> Reviewed-by: Baoquan He <baoquan.he@linux.dev>
> Tested-by: Xueyuan Chen <xueyuan.chen21@gmail.com>
> ---
>   mm/vmscan.c | 16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index b10d1703d907..2b33d3f44682 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -3952,17 +3952,17 @@ static bool inc_min_seq(struct lruvec *lruvec, int type, int swappiness)
>   			if (gen_increased) {
>   				delta += nr_pages;
>   				list_move_tail(&folio->lru, &lrugen->folios[new_gen][type][zone]);
> +
> +				/* don't count the workingset being lazily promoted */
> +				if (refs + workingset != BIT(LRU_REFS_WIDTH) + 1) {
> +					int tier = lru_tier_from_refs(refs, workingset);
> +
> +					WRITE_ONCE(lrugen->protected[hist][type][tier],
> +						   lrugen->protected[hist][type][tier] + nr_pages);
> +				}
>   			} else {
>   				list_move(&folio->lru, &lrugen->folios[new_gen][type][zone]);
>   			}
> -			/* don't count the workingset being lazily promoted */
> -			if (refs + workingset != BIT(LRU_REFS_WIDTH) + 1) {
> -				int tier = lru_tier_from_refs(refs, workingset);
> -
> -				WRITE_ONCE(lrugen->protected[hist][type][tier],
> -					   lrugen->protected[hist][type][tier] + nr_pages);
> -			}
> -
>   			if (!--remaining)
>   				break;
>   		}

Reviewd-by: Ridong Chen <ridong.chen@linux.dev>

-- 
Best regards
Ridong