From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 18/39] drm/i915: Differentiate between ggtt->mutex and ppgtt->mutex Date: Thu, 3 Jan 2019 13:43:42 +0000 Message-ID: References: <20190102094139.24014-1-chris@chris-wilson.co.uk> <20190102094139.24014-18-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id B67716E3A7 for ; Thu, 3 Jan 2019 13:43:45 +0000 (UTC) In-Reply-To: <20190102094139.24014-18-chris@chris-wilson.co.uk> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck1pa2EncyByZXBseSBoZXJlIHJlbWluZGVkIG1lIHRoYXQgdGhlIHBhdGNoIGxvb2tzIGZhbWls aWFyIGFuZCBpbmRlZWQgSSAKci1iLWVkIGl0IGJhY2sgaW4gU2VwdGVtYmVyLgoKQ2FuIGtlZXAg aXQgYWZ0ZXIgdGhlIGJsYW5rIGxpbmUgYWRqdXN0bWVudCBhbmQgb3JkZXJpbmcgc2h1ZmZsZXMg b2YgY291cnNlLgoKTm90IHN1cmUgb24gdGhlIGlzX2dndHQgdnMgdGhlIHN1YmNsYXNzIGlkIC0g cGVyaGFwcyBldmVuIGl0IHdvdWxkIG1ha2UgCm1vcmUgc2Vuc2UgdG8gc2V0IGlzX2dndHQgYmVm b3JlIHRoZSBjYWxsIHRvIGk5MTVfYWRkcmVzc19zcGFjZV9pbml0IGFuZCAKdGhlbiBpbnNpZGUg ZGVyaXZlIHRoZSBsb2NrIHN1YmNsYXNzIGZyb20gaXQuIEFsdGhvdWdoIGV2ZW4gdGhhdCBpcyBu b3QgCmZ1bGx5IGVsZWdhbnQuIE1heWJlIGlzX2dndHQgZ25lbmVyaWMgZmxhZyB0byBpOTE1X2Fk ZHJlc3Nfc3BhY2VfaW5pdCB0byAKZG8gYm90aCB0YXNrcz8KClJlZ2FyZHMsCgpUdnJ0a28KCk9u IDAyLzAxLzIwMTkgMDk6NDEsIENocmlzIFdpbHNvbiB3cm90ZToKPiBXZSBoYXZlIHR3byBjbGFz c2VzIG9mIFZNLCBnbG9iYWwgR1RUIGFuZCBwZXItcHJvY2VzcyBHVFQuIEluIG9yZGVyIHRvCj4g YWxsb3cgb3Vyc2VsdmVzIHRoZSBmcmVlZG9tIHRvIG1peCBib3RoIGFsb25nIGNhbGwgY2hhaW5z LCBkaXN0aW5ndWlzaAo+IHRoZSB0d28gY2xhc3NlcyB3aXRoIHJlZ2FyZHMgdG8gdGhlaXIgbXV0 ZXggYW5kIGxvY2tkZXAgbWFwcy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNo cmlzQGNocmlzLXdpbHNvbi5jby51az4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZ2VtX2d0dC5jICAgICAgIHwgMTAgKysrKystLS0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9nZW1fZ3R0LmggICAgICAgfCAgMiArKwo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUv c2VsZnRlc3RzL21vY2tfZ3R0LmMgfCAgNiArKystLS0KPiAgIDMgZmlsZXMgY2hhbmdlZCwgMTAg aW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dl bV9ndHQuYwo+IGluZGV4IDg1MmRiYzFmMTg1Zi4uOGY5M2IxZGZmYmI5IDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jCj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMKPiBAQCAtNDc0LDggKzQ3NCw3IEBAIHN0YXRpYyB2b2lk IHZtX2ZyZWVfcGFnZShzdHJ1Y3QgaTkxNV9hZGRyZXNzX3NwYWNlICp2bSwgc3RydWN0IHBhZ2Ug KnBhZ2UpCj4gICAJc3Bpbl91bmxvY2soJnZtLT5mcmVlX3BhZ2VzLmxvY2spOwo+ICAgfQo+ICAg Cj4gLXN0YXRpYyB2b2lkIGk5MTVfYWRkcmVzc19zcGFjZV9pbml0KHN0cnVjdCBpOTE1X2FkZHJl c3Nfc3BhY2UgKnZtLAo+IC0JCQkJICAgIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp dikKPiArc3RhdGljIHZvaWQgaTkxNV9hZGRyZXNzX3NwYWNlX2luaXQoc3RydWN0IGk5MTVfYWRk cmVzc19zcGFjZSAqdm0sIGludCBzdWJjbGFzcykKPiAgIHsKPiAgIAkvKgo+ICAgCSAqIFRoZSB2 bS0+bXV0ZXggbXVzdCBiZSByZWNsYWltIHNhZmUgKGZvciB1c2UgaW4gdGhlIHNocmlua2VyKS4K PiBAQCAtNDgzLDYgKzQ4Miw3IEBAIHN0YXRpYyB2b2lkIGk5MTVfYWRkcmVzc19zcGFjZV9pbml0 KHN0cnVjdCBpOTE1X2FkZHJlc3Nfc3BhY2UgKnZtLAo+ICAgCSAqIGF0dGVtcHQgaG9sZGluZyB0 aGUgbG9jayBpcyBpbW1lZGlhdGVseSByZXBvcnRlZCBieSBsb2NrZGVwLgo+ICAgCSAqLwo+ICAg CW11dGV4X2luaXQoJnZtLT5tdXRleCk7Cj4gKwlsb2NrZGVwX3NldF9zdWJjbGFzcygmdm0tPm11 dGV4LCBzdWJjbGFzcyk7Cj4gICAJaTkxNV9nZW1fc2hyaW5rZXJfdGFpbnRzX211dGV4KCZ2bS0+ bXV0ZXgpOwo+ICAgCj4gICAJR0VNX0JVR19PTighdm0tPnRvdGFsKTsKPiBAQCAtMTU0OCw3ICsx NTQ4LDcgQEAgc3RhdGljIHN0cnVjdCBpOTE1X2h3X3BwZ3R0ICpnZW44X3BwZ3R0X2NyZWF0ZShz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSkKPiAgIAkvKiBGcm9tIGJkdywgdGhlcmUgaXMg c3VwcG9ydCBmb3IgcmVhZC1vbmx5IHBhZ2VzIGluIHRoZSBQUEdUVC4gKi8KPiAgIAlwcGd0dC0+ dm0uaGFzX3JlYWRfb25seSA9IHRydWU7Cj4gICAKPiAtCWk5MTVfYWRkcmVzc19zcGFjZV9pbml0 KCZwcGd0dC0+dm0sIGk5MTUpOwo+ICsJaTkxNV9hZGRyZXNzX3NwYWNlX2luaXQoJnBwZ3R0LT52 bSwgVk1fQ0xBU1NfUFBHVFQpOwo+ICAgCj4gICAJLyogVGhlcmUgYXJlIG9ubHkgZmV3IGV4Y2Vw dGlvbnMgZm9yIGdlbiA+PTYuIGNodiBhbmQgYnh0Lgo+ICAgCSAqIEFuZCB3ZSBhcmUgbm90IHN1 cmUgYWJvdXQgdGhlIGxhdHRlciBzbyBwbGF5IHNhZmUgZm9yIG5vdy4KPiBAQCAtMTk5Nyw3ICsx OTk3LDcgQEAgc3RhdGljIHN0cnVjdCBpOTE1X2h3X3BwZ3R0ICpnZW42X3BwZ3R0X2NyZWF0ZShz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSkKPiAgIAo+ICAgCXBwZ3R0LT5iYXNlLnZtLnRv dGFsID0gSTkxNV9QREVTICogR0VONl9QVEVTICogSTkxNV9HVFRfUEFHRV9TSVpFOwo+ICAgCj4g LQlpOTE1X2FkZHJlc3Nfc3BhY2VfaW5pdCgmcHBndHQtPmJhc2Uudm0sIGk5MTUpOwo+ICsJaTkx NV9hZGRyZXNzX3NwYWNlX2luaXQoJnBwZ3R0LT5iYXNlLnZtLCBWTV9DTEFTU19QUEdUVCk7Cj4g ICAKPiAgIAlwcGd0dC0+YmFzZS52bS5hbGxvY2F0ZV92YV9yYW5nZSA9IGdlbjZfYWxsb2NfdmFf cmFuZ2U7Cj4gICAJcHBndHQtPmJhc2Uudm0uY2xlYXJfcmFuZ2UgPSBnZW42X3BwZ3R0X2NsZWFy X3JhbmdlOwo+IEBAIC0zNDM0LDcgKzM0MzQsNyBAQCBpbnQgaTkxNV9nZ3R0X2luaXRfaHcoc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAgCSAqIGFuZCBiZXlvbmQgdGhlIGVu ZCBvZiB0aGUgR1RUIGlmIHdlIGRvIG5vdCBwcm92aWRlIGEgZ3VhcmQuCj4gICAJICovCj4gICAJ bXV0ZXhfbG9jaygmZGV2X3ByaXYtPmRybS5zdHJ1Y3RfbXV0ZXgpOwo+IC0JaTkxNV9hZGRyZXNz X3NwYWNlX2luaXQoJmdndHQtPnZtLCBkZXZfcHJpdik7Cj4gKwlpOTE1X2FkZHJlc3Nfc3BhY2Vf aW5pdCgmZ2d0dC0+dm0sIFZNX0NMQVNTX0dHVFQpOwo+ICAgCj4gICAJZ2d0dC0+dm0uaXNfZ2d0 dCA9IHRydWU7Cj4gICAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9n ZW1fZ3R0LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuaAo+IGluZGV4IGUy MzYwZjE2NDI3YS4uOTIyOWIwM2Q2MjliIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZ2VtX2d0dC5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1f Z3R0LmgKPiBAQCAtMjg4LDYgKzI4OCw4IEBAIHN0cnVjdCBpOTE1X2FkZHJlc3Nfc3BhY2Ugewo+ ICAgCWJvb2wgY2xvc2VkOwo+ICAgCj4gICAJc3RydWN0IG11dGV4IG11dGV4OyAvKiBwcm90ZWN0 cyB2bWEgYW5kIG91ciBsaXN0cyAqLwo+ICsjZGVmaW5lIFZNX0NMQVNTX0dHVFQgMAo+ICsjZGVm aW5lIFZNX0NMQVNTX1BQR1RUIDEKPiAgIAo+ICAgCXU2NCBzY3JhdGNoX3B0ZTsKPiAgIAlzdHJ1 Y3QgaTkxNV9wYWdlX2RtYSBzY3JhdGNoX3BhZ2U7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L3NlbGZ0ZXN0cy9tb2NrX2d0dC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvc2Vs ZnRlc3RzL21vY2tfZ3R0LmMKPiBpbmRleCA2YWU0MThjNzYwMTUuLjk3NmM4NjJiMzg0MiAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9zZWxmdGVzdHMvbW9ja19ndHQuYwo+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0cy9tb2NrX2d0dC5jCj4gQEAgLTcwLDcg KzcwLDcgQEAgbW9ja19wcGd0dChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSwKPiAgIAlw cGd0dC0+dm0udG90YWwgPSByb3VuZF9kb3duKFU2NF9NQVgsIFBBR0VfU0laRSk7Cj4gICAJcHBn dHQtPnZtLmZpbGUgPSBFUlJfUFRSKC1FTk9ERVYpOwo+ICAgCj4gLQlpOTE1X2FkZHJlc3Nfc3Bh Y2VfaW5pdCgmcHBndHQtPnZtLCBpOTE1KTsKPiArCWk5MTVfYWRkcmVzc19zcGFjZV9pbml0KCZw cGd0dC0+dm0sIFZNX0NMQVNTX1BQR1RUKTsKPiAgIAo+ICAgCXBwZ3R0LT52bS5jbGVhcl9yYW5n ZSA9IG5vcF9jbGVhcl9yYW5nZTsKPiAgIAlwcGd0dC0+dm0uaW5zZXJ0X3BhZ2UgPSBtb2NrX2lu c2VydF9wYWdlOwo+IEBAIC0xMDIsNiArMTAyLDcgQEAgdm9pZCBtb2NrX2luaXRfZ2d0dChzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSkKPiAgIAlzdHJ1Y3QgaTkxNV9nZ3R0ICpnZ3R0ID0g Jmk5MTUtPmdndHQ7Cj4gICAKPiAgIAlnZ3R0LT52bS5pOTE1ID0gaTkxNTsKPiArCWdndHQtPnZt LmlzX2dndHQgPSB0cnVlOwo+ICAgCj4gICAJZ2d0dC0+Z21hZHIgPSAoc3RydWN0IHJlc291cmNl KSBERUZJTkVfUkVTX01FTSgwLCAyMDQ4ICogUEFHRV9TSVpFKTsKPiAgIAlnZ3R0LT5tYXBwYWJs ZV9lbmQgPSByZXNvdXJjZV9zaXplKCZnZ3R0LT5nbWFkcik7Cj4gQEAgLTExNyw5ICsxMTgsOCBA QCB2b2lkIG1vY2tfaW5pdF9nZ3R0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1KQo+ICAg CWdndHQtPnZtLnZtYV9vcHMuc2V0X3BhZ2VzICAgPSBnZ3R0X3NldF9wYWdlczsKPiAgIAlnZ3R0 LT52bS52bWFfb3BzLmNsZWFyX3BhZ2VzID0gY2xlYXJfcGFnZXM7Cj4gICAKPiAtCWk5MTVfYWRk cmVzc19zcGFjZV9pbml0KCZnZ3R0LT52bSwgaTkxNSk7Cj4gICAKPiAtCWdndHQtPnZtLmlzX2dn dHQgPSB0cnVlOwo+ICsJaTkxNV9hZGRyZXNzX3NwYWNlX2luaXQoJmdndHQtPnZtLCBWTV9DTEFT U19HR1RUKTsKPiAgIH0KPiAgIAo+ICAgdm9pZCBtb2NrX2ZpbmlfZ2d0dChzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZSAqaTkxNSkKPiAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4Cg==