All of lore.kernel.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 2/4] powerpc: Add device tree utility functions to zImage
Date: Wed, 21 Mar 2007 18:10:21 +0100	[thread overview]
Message-ID: <d33fab3c1f5376bc078ea1b805babbdc@kernel.crashing.org> (raw)
In-Reply-To: <20070321063150.04BA4DDE9F@ozlabs.org>

> @@ -262,6 +253,10 @@ void start(void *sp)
>  	printf("\n\rzImage starting: loaded at 0x%p (sp: 0x%p)\n\r",
>  	       _start, sp);
>
> +	/* Ensure that the device tree has a /chosen node */
> +	if (! finddevice("/chosen"))
> +		create_node(NULL, "chosen");
> +
>  	vmlinux = prep_kernel();
>  	initrd = prep_initrd(vmlinux, loader_info.initrd_addr,
>  			     loader_info.initrd_size);

So this is done early, and unconditional now?  Just
double checking, not enough context (for me, anyway)
in the patch itself.


Segher

  parent reply	other threads:[~2007-03-21 17:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-21  6:30 [0/4] Further zImage work David Gibson
2007-03-21  6:31 ` [PATCH 1/4] powerpc: Add gcc format warnings to zImage printf() David Gibson
2007-03-21 15:03   ` Milton Miller
2007-03-22  1:35     ` David Gibson
2007-03-21  6:31 ` [PATCH 2/4] powerpc: Add device tree utility functions to zImage David Gibson
2007-03-21 15:03   ` Milton Miller
2007-03-22  3:02     ` David Gibson
2007-03-21 17:10   ` Segher Boessenkool [this message]
2007-03-21 23:31     ` David Gibson
2007-03-21 21:57   ` Scott Wood
2007-03-22  1:36     ` David Gibson
2007-03-21  6:31 ` [PATCH 4/4] powerpc: New reg.h for the zImage David Gibson
2007-03-21  6:31 ` [PATCH 3/4] powerpc: Clean up zImage handling of the command line David Gibson
2007-03-22  5:48 ` [0/4] Further zImage work (spin 2) David Gibson
2007-03-22  5:59   ` [PATCH 1/4] powerpc: Add gcc format warnings to zImage printf() David Gibson
2007-03-22  6:02   ` [PATCH 4/4] powerpc: New reg.h for the zImage David Gibson
2007-03-22  6:02   ` [PATCH 3/4] powerpc: Clean up zImage handling of the command line David Gibson
2007-03-22  6:02   ` [PATCH 2/4] powerpc: Add device tree utility functions to zImage David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d33fab3c1f5376bc078ea1b805babbdc@kernel.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.