From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 508A71514E0 for ; Wed, 27 Mar 2024 18:53:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=44.202.169.37 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711565620; cv=none; b=DuzmUONPnuvorKu4C0dJkGX+7tTBvb/zo0Xs4Cf8ctPyLyiKaYaZal+9aRe6ZtFrUsXKZiSuKhcP2A74Si7k8oSFsXFvjlGTqJ9xBZPfudIU74ITWWsJqFNutLCUop1EmeZOBGBU4JPkh5ej7rd2YwJx6dumXC+pK1T6RDloZrk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711565620; c=relaxed/simple; bh=DRriF96XBdtDbA0stDmuq0Ozvtm/4dViy+piu1EqTFA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pyb76jVpjTyIV+YCkaP1MHMI8DjfR3/9PigchRmYhm/OE5wqMPTejy3jpJryEZcZXCd1MtCYfOXnKb5IaR00l5AvTN/ODfPfJMIcSTLFH9Pj3tECqc79IY+I+zl+TWLRLs6kjn43ghHoHaKHxfnoFimQXzzEc/31gL56rtX7U6A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=embeddedor.com; spf=pass smtp.mailfrom=embeddedor.com; dkim=pass (2048-bit key) header.d=embeddedor.com header.i=@embeddedor.com header.b=Tf0ipOtp; arc=none smtp.client-ip=44.202.169.37 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=embeddedor.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=embeddedor.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=embeddedor.com header.i=@embeddedor.com header.b="Tf0ipOtp" Received: from eig-obgw-5003a.ext.cloudfilter.net ([10.0.29.159]) by cmsmtp with ESMTPS id pWKkrzz1dQr4SpYP4riWRl; Wed, 27 Mar 2024 18:53:38 +0000 Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with ESMTPS id pYP3rt4mlsT9BpYP3rnuFb; Wed, 27 Mar 2024 18:53:37 +0000 X-Authority-Analysis: v=2.4 cv=LIutQ4W9 c=1 sm=1 tr=0 ts=66046b31 a=1YbLdUo/zbTtOZ3uB5T3HA==:117 a=zXgy4KOrraTBHT4+ULisNA==:17 a=IkcTkHD0fZMA:10 a=K6JAEmCyrfEA:10 a=wYkD_t78qR0A:10 a=VwQbUJbxAAAA:8 a=0yL73Cyy68KADmUz8mEA:9 a=QEXdDO2ut3YA:10 a=AjGcO6oz07-iQ99wixmX:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=gdIFR+CqW2Hj2dXzDKpIE02t+3L7EdU4qxKK93B9/Fo=; b=Tf0ipOtpi0jeAMo4neqo5oMZiS ATSJyTc5sBz7hKoQdpI8on6+u7RfGRaI8vKMNAKx9ceiayArBeevctN7FVjjs6ls5K4ktPWNGCMjm Fq6Nd8R63PrT6CZC9bzR4cVyUs1qe14QkX8fsg9/4RND+GG/1vGWHLB/17yFZXcTlV4D8Jme1UssB J3z/Ukd0wr3JkRgkDf9yzX0CXWofYVCqWPwLXIZpWXat3J/pPrTY4ZJKLGlfo1Pcuw26KaX6H1ykU zaRsPG6fURPbfDEcePieD07SDhCFdVdImb6qph1AamMkZwYh0GLtMuote+aUg4pgrkdQG0onCuoKn Ne4umHSQ==; Received: from [201.172.173.147] (port=36948 helo=[192.168.15.10]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96.2) (envelope-from ) id 1rpYP2-003XoZ-2f; Wed, 27 Mar 2024 13:53:36 -0500 Message-ID: Date: Wed, 27 Mar 2024 12:53:35 -0600 Precedence: bulk X-Mailing-List: linux-hardening@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2][next] wifi: wil6210: Annotate a couple of structs with __counted_by() Content-Language: en-US To: "Gustavo A. R. Silva" , Kalle Valo Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: From: "Gustavo A. R. Silva" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 201.172.173.147 X-Source-L: No X-Exim-ID: 1rpYP2-003XoZ-2f X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.15.10]) [201.172.173.147]:36948 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 13 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfPY4F22j2Sflfa8cko4eTrruhO903BbThEabyE1Im9g2AieC9UAxrVa9QDKOojPMo5BDOZaAM8ZeK1RUdZu2QaNwx90ivZSV2DI/WIkXKu9IKWRgR+Za OwruiGsOYy9iTm6wCePB0M3YXufeGb3Z1+Ptb0cWSZPkei3PtgIe+CJJo8bfYYxIfLp3jZRwokRHYYXoaksZweNHvAIxEK0JwZcrr+BP0pA4MDa/+DbluNMP Hi all, Please, drop this. The following patches replaces it: https://lore.kernel.org/linux-hardening/ZgRqjGShTl3y5FFB@neat/ Thanks -- Gustavo On 3/27/24 11:43, Gustavo A. R. Silva wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for > array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > Signed-off-by: Gustavo A. R. Silva > --- > Changes in v2: > - Annotate one more struct. > - Update Subject line. > > v1: > - Link: https://lore.kernel.org/linux-hardening/ZgODZOB4fOBvKl7R@neat/ > > drivers/net/wireless/ath/wil6210/wmi.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/ath/wil6210/wmi.h b/drivers/net/wireless/ath/wil6210/wmi.h > index 71bf2ae27a98..38f64524019e 100644 > --- a/drivers/net/wireless/ath/wil6210/wmi.h > +++ b/drivers/net/wireless/ath/wil6210/wmi.h > @@ -474,7 +474,7 @@ struct wmi_start_scan_cmd { > struct { > u8 channel; > u8 reserved; > - } channel_list[]; > + } channel_list[] __counted_by(num_channels); > } __packed; > > #define WMI_MAX_PNO_SSID_NUM (16) > @@ -3320,7 +3320,7 @@ struct wmi_set_link_monitor_cmd { > u8 rssi_hyst; > u8 reserved[12]; > u8 rssi_thresholds_list_size; > - s8 rssi_thresholds_list[]; > + s8 rssi_thresholds_list[] __counted_by(rssi_thresholds_list_size); > } __packed; > > /* wmi_link_monitor_event_type */