From: Sinan Kaya <okaya@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Oza Pawandeep <poza@codeaurora.org>,
linux-pci@vger.kernel.org,
open list <linux-kernel@vger.kernel.org>,
Keith Busch <keith.busch@intel.com>,
Lukas Wunner <lukas@wunner.de>,
linux-arm-msm@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V5 3/3] PCI: Mask and unmask hotplug interrupts during reset
Date: Fri, 20 Jul 2018 23:07:20 -0700 [thread overview]
Message-ID: <d34eb5da-0ae1-d455-93e2-2432ec7931ea@kernel.org> (raw)
In-Reply-To: <2febe688-f973-5ff5-f61d-0451ad7d36ae@kernel.org>
On 7/20/2018 7:58 PM, Sinan Kaya wrote:
> We need to figure out how to gracefully return inside hotplug driver
> if link down happened and there is an error pending.
How about adding the following into the hotplug ISR?
1. check if firmware first is disabled
2. check if there is a fatal error pending in the device_status register
of the PCI Express capability on the root port.
3. bail out from hotplug routine if this is the case.
4. otherwise, existing behavior.
WARNING: multiple messages have this Message-ID (diff)
From: Sinan Kaya <okaya@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Lukas Wunner <lukas@wunner.de>,
Oza Pawandeep <poza@codeaurora.org>,
linux-pci@vger.kernel.org,
open list <linux-kernel@vger.kernel.org>,
Keith Busch <keith.busch@intel.com>,
linux-arm-msm@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V5 3/3] PCI: Mask and unmask hotplug interrupts during reset
Date: Fri, 20 Jul 2018 23:07:20 -0700 [thread overview]
Message-ID: <d34eb5da-0ae1-d455-93e2-2432ec7931ea@kernel.org> (raw)
In-Reply-To: <2febe688-f973-5ff5-f61d-0451ad7d36ae@kernel.org>
On 7/20/2018 7:58 PM, Sinan Kaya wrote:
> We need to figure out how to gracefully return inside hotplug driver
> if link down happened and there is an error pending.
How about adding the following into the hotplug ISR?
1. check if firmware first is disabled
2. check if there is a fatal error pending in the device_status register
of the PCI Express capability on the root port.
3. bail out from hotplug routine if this is the case.
4. otherwise, existing behavior.
WARNING: multiple messages have this Message-ID (diff)
From: okaya@kernel.org (Sinan Kaya)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V5 3/3] PCI: Mask and unmask hotplug interrupts during reset
Date: Fri, 20 Jul 2018 23:07:20 -0700 [thread overview]
Message-ID: <d34eb5da-0ae1-d455-93e2-2432ec7931ea@kernel.org> (raw)
In-Reply-To: <2febe688-f973-5ff5-f61d-0451ad7d36ae@kernel.org>
On 7/20/2018 7:58 PM, Sinan Kaya wrote:
> We need to figure out how to gracefully return inside hotplug driver
> if link down happened and there is an error pending.
How about adding the following into the hotplug ISR?
1. check if firmware first is disabled
2. check if there is a fatal error pending in the device_status register
of the PCI Express capability on the root port.
3. bail out from hotplug routine if this is the case.
4. otherwise, existing behavior.
next prev parent reply other threads:[~2018-07-21 6:07 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 22:52 [PATCH V5 0/3] PCI: separate hotplug handling from fatal error handling Sinan Kaya
2018-07-02 22:52 ` Sinan Kaya
2018-07-02 22:52 ` Sinan Kaya
2018-07-02 22:52 ` [PATCH V5 1/3] PCI: pciehp: implement mask and unmask interrupt functions Sinan Kaya
2018-07-02 22:52 ` Sinan Kaya
2018-07-02 22:52 ` Sinan Kaya
2018-07-02 22:52 ` [PATCH V5 2/3] PCI: pciehp: reuse pciehp_mask/unmask_irq() in reset_slot() Sinan Kaya
2018-07-02 22:52 ` Sinan Kaya
2018-07-02 22:52 ` Sinan Kaya
2018-07-02 22:52 ` Sinan Kaya
2018-07-02 22:52 ` [PATCH V5 3/3] PCI: Mask and unmask hotplug interrupts during reset Sinan Kaya
2018-07-02 22:52 ` Sinan Kaya
2018-07-02 22:52 ` Sinan Kaya
2018-07-02 22:52 ` Sinan Kaya
2018-07-03 8:34 ` Lukas Wunner
2018-07-03 10:52 ` poza
2018-07-03 10:52 ` poza at codeaurora.org
2018-07-03 10:52 ` poza
2018-07-03 12:04 ` okaya
2018-07-03 12:04 ` okaya at codeaurora.org
2018-07-03 12:04 ` okaya
2018-07-03 11:30 ` okaya
2018-07-03 11:30 ` okaya
2018-07-03 11:30 ` okaya at codeaurora.org
2018-07-03 11:30 ` okaya
2018-07-03 13:11 ` poza
2018-07-03 13:11 ` poza at codeaurora.org
2018-07-03 13:11 ` poza
2018-07-03 13:25 ` Sinan Kaya
2018-07-03 13:25 ` Sinan Kaya
2018-07-03 13:25 ` Sinan Kaya
2018-07-03 13:31 ` Sinan Kaya
2018-07-03 13:31 ` Sinan Kaya
2018-07-03 13:31 ` Sinan Kaya
2018-07-03 13:59 ` Lukas Wunner
2018-07-03 14:10 ` poza
2018-07-03 14:10 ` poza at codeaurora.org
2018-07-03 14:10 ` poza
2018-07-03 14:17 ` Lukas Wunner
2018-07-03 15:34 ` Sinan Kaya
2018-07-03 15:34 ` Sinan Kaya
2018-07-03 15:34 ` Sinan Kaya
2018-07-29 12:32 ` Lukas Wunner
2018-07-03 14:12 ` Lukas Wunner
2018-07-03 14:29 ` poza
2018-07-03 14:29 ` poza at codeaurora.org
2018-07-03 14:29 ` poza
2018-07-29 12:19 ` Lukas Wunner
2018-07-03 14:34 ` Lukas Wunner
2018-07-03 15:12 ` poza
2018-07-03 15:12 ` poza at codeaurora.org
2018-07-03 15:12 ` poza
2018-07-03 15:49 ` Sinan Kaya
2018-07-03 15:49 ` Sinan Kaya
2018-07-03 15:49 ` Sinan Kaya
2018-07-03 15:43 ` Sinan Kaya
2018-07-03 15:43 ` Sinan Kaya
2018-07-08 17:14 ` Lukas Wunner
2018-07-09 14:48 ` Sinan Kaya
2018-07-09 14:48 ` Sinan Kaya
2018-07-09 14:48 ` Sinan Kaya
2018-07-09 16:00 ` Lukas Wunner
2018-07-10 18:30 ` Sinan Kaya
2018-07-10 18:30 ` Sinan Kaya
2018-07-10 18:30 ` Sinan Kaya
2018-07-10 18:30 ` Sinan Kaya
2018-07-20 20:01 ` Bjorn Helgaas
2018-07-20 20:01 ` Bjorn Helgaas
2018-07-20 20:01 ` Bjorn Helgaas
2018-07-21 2:58 ` Sinan Kaya
2018-07-21 2:58 ` Sinan Kaya
2018-07-21 2:58 ` Sinan Kaya
2018-07-21 6:07 ` Sinan Kaya [this message]
2018-07-21 6:07 ` Sinan Kaya
2018-07-21 6:07 ` Sinan Kaya
2018-07-25 8:29 ` poza
2018-07-25 8:29 ` poza at codeaurora.org
2018-07-29 18:02 ` Lukas Wunner
2018-07-31 18:44 ` [PATCH V5 0/3] PCI: separate hotplug handling from fatal error handling Bjorn Helgaas
2018-07-31 18:44 ` Bjorn Helgaas
2018-07-31 18:44 ` Bjorn Helgaas
2018-07-31 18:54 ` Sinan Kaya
2018-07-31 18:54 ` Sinan Kaya
2018-07-31 18:54 ` Sinan Kaya
2018-07-31 20:16 ` Bjorn Helgaas
2018-07-31 20:16 ` Bjorn Helgaas
2018-07-31 20:16 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d34eb5da-0ae1-d455-93e2-2432ec7931ea@kernel.org \
--to=okaya@kernel.org \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=keith.busch@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=poza@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.